From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09AFB280A5A for ; Wed, 17 Jun 2026 01:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781659859; cv=none; b=nkrR5m29IaN+PPkVtpaJWN80m8RITk3UhpCOVPFHx5TSSikOUH/WjLeIVjrNEUv0I1/1stK0WmehhVffeNDdDM+wHmD6gl4j6THbDcz6EnFMRAb+7CXpBMfZOuHVyQ1aHz01o2JzqITJ7uwjVI4ZrMzxqKafRxgoJBuD5XqjKEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781659859; c=relaxed/simple; bh=f3QMIYqJLV45dB3OOU5q66tRA/gy39q6iYmhKOD+IPw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=giFVIzrsmgitlnFZfFTxIh08LR/0iCYZUtyqY1b0uURDb4BFF5s7Mj+/BJfJluRL5Bxf+hW2+HbujR14dhhLGMuywq9FAvPy2bgoutPcvuVz8VEkpzRWnlGbxtuPB0XcjuKxHsCcKomtAyA/3JNropgGYzUAdhIq8DY/8v5zq0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZpvqCmxV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HZQCJ5KT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZpvqCmxV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HZQCJ5KT" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GLT3Lt274806 for ; Wed, 17 Jun 2026 01:30:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LFFy8N8tIeg6Ssx2D/z9+qb38nAO75a0/SRz3wzKEQg=; b=ZpvqCmxVyH3L+Cgw 5EKtXn+S+jl/1y6uT0pA/26UNpa/d4wFil+KiVaije1Qb7WDLlhKoZaIZNlYxmj4 S9jWXnnDMCk/YjA248gUtseDxZCXfUWUobqgniv9gKTsvScEc44D9ByFu5Q2MhNX bR+7d7h4rmeu2AA8LIh72IokzGW8gMCHW7sO8JiB2mkEpvz6ZOw6XftWujQGnpXu 8gqflYLZ5kwtBomp/DOjdyu/TaXCgc86FFoWJTqTEgEh5J8VYQxLoRlZZa9XOpSK gLrTR9Kb7XzAVh3VNrSAV/sq40w6ISGZHdXCs6vyM1/OjXgAlWDrvK2Lu8/9IiSf MLaakg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueemgnky-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Jun 2026 01:30:53 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8421f5d76aaso3683428b3a.2 for ; Tue, 16 Jun 2026 18:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781659853; x=1782264653; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LFFy8N8tIeg6Ssx2D/z9+qb38nAO75a0/SRz3wzKEQg=; b=HZQCJ5KTqDBd6UeG5IgshXz+klL8GtoReKssMYBHQ8g1iNeHtE8+X5je6ZZQHy79AN bGplfB07Gn7WBcH73+d61xdX7MArjsAm9bzqWErlpJlC9sY84XsILEY0AKgRk8L1Mum5 rwLYWeDx6CRs+JDCfBBzqWcqTwCii07CTRwDs8p9e/DMs3kvYl2RwKRKHdZxuc9spgFO /+jJCTSMzNTlc+ht99i0i5LuqkZU8CAfM24/6hgVTQpazpzb2+bAMSEQZ6zE/kEAHlzx FdnptUkl+TC10KK8y9djLew2ek/dYCc3AnfNDRmGGgl6pps7WMbCLCWvv2Zwt/tcdSbU 87wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781659853; x=1782264653; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LFFy8N8tIeg6Ssx2D/z9+qb38nAO75a0/SRz3wzKEQg=; b=VlXT6g+OWCDExDWKA3QSm2H9m8hldLegbb3o5+N6hzuxT7tRNXtZhnCmqIbMzK2kJE p3c9DlrBImuHqVsY7udEWdlIU2EMpz1e4nw0lcoLBWQJr9IUEb3Y75oMb0rdjRFrUYlb MyF2QOkWUCKLXfmOaHV1bxsmbRJzXi/Gz25EuVLjHVduktplqrovRLOmT8fqAtZin2Cm K6a+jOLcZMpZJJ3ITtpsul6GdZBl/BXvRZUbMwOv9AfvO2wbMxoB4I1EXpTl7o3Da8uw j9Ks/M8ZM/8GxkFlLYI61Y6/Ckfx1tCMuSaHmcJ0xm6h+NOOFKdwMopqd/kiugG1nzer BZ5g== X-Forwarded-Encrypted: i=1; AFNElJ8RtL8yS8kfap3y+lm5Sr1WpRRs397HduAHMeBRiFv74f7ljKLrVzLStrOsz63xkimJ+EdFlIYeQqYhzd8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5kROBDU0RzB0VqPs9FMvNbBoLea/ZFYr08I9Zs/IWvRxzp2Ll 7+g2apHr/4tp6uPbH7IP9PTbjK53W6ptlD+jR3gj+2CjMRQKVMORtIWtsG2pLF8Re3wNfkViw6Z 1UhE6E+wnhMPAyy5/9uwjpcjYNo6NAoJiSkJ/ep0YfDWU5yHLvE+INHC5bOjwqJkQwwQ= X-Gm-Gg: Acq92OGSO5uO9QXr3JCtJzxnJdalwHz2CtBX/5eq9MH4Uyydrc4LzpBB25YIqY6PVtc Hl7MLGVkAmqalljHY3OtKBx0rbGFMe3e2WBXaQc9XlsqAmDOjM3YEYwUPPmyIkkf4ISC6ReO8YD IrY5a+mFKEK02G6NSrx1ZkM1VL/xFw4WuN5DXJaWja9dNdZBNB13ILCAi3ofjNDiCKtRT+jmKC6 AUosax0jqAhGTEPCh/6PSYW8Kf8DLqt9T5agMSYjl+8ezejbFK6+fv7NySttJjjWe04zVUZLrBO oZ4bimiehMBna5NE13oRpabFxY762/Z2c2wqCHW7e3+2ON1k4ZlmRJ+B/Q+E8WKQcQnsFE1ZIub pfU7/o2b7ThvR8NYHkt7VWk4gxSfmOCOdxZC4ceANBf3rw1MIVVkN2UYnNTuRo0OBzx71WWm7VB k61XXg/dr7UVQ6ng== X-Received: by 2002:a05:6a00:2e07:b0:81e:ef16:b288 with SMTP id d2e1a72fcca58-84524540500mr1574726b3a.22.1781659853199; Tue, 16 Jun 2026 18:30:53 -0700 (PDT) X-Received: by 2002:a05:6a00:2e07:b0:81e:ef16:b288 with SMTP id d2e1a72fcca58-84524540500mr1574699b3a.22.1781659852720; Tue, 16 Jun 2026 18:30:52 -0700 (PDT) Received: from [10.133.33.63] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434ac9c4c0sm12958951b3a.3.2026.06.16.18.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 18:30:52 -0700 (PDT) Message-ID: <8a4e7f81-959c-4966-b90c-1ee4ceb9ec9c@oss.qualcomm.com> Date: Wed, 17 Jun 2026 09:30:46 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: Add PMIH0108 haptics device node To: Konrad Dybcio , linux-arm-msm@vger.kernel.org, Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Stephen Boyd , Bjorn Andersson , Konrad Dybcio Cc: David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , kernel@oss.qualcomm.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260616-qcom-spmi-haptics-v1-0-d24e422de6b4@oss.qualcomm.com> <20260616-qcom-spmi-haptics-v1-4-d24e422de6b4@oss.qualcomm.com> <6b3155ea-b583-4f82-8313-7a057fd78066@oss.qualcomm.com> Content-Language: en-US From: Fenglin Wu In-Reply-To: <6b3155ea-b583-4f82-8313-7a057fd78066@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE3MDAxMSBTYWx0ZWRfXyNM3QTIbxV8e j8g5mDCujl8Q3FAAHXlMD+KCiWRIOAb5JTwcywthUli7krAErDqvX4xEWk92NH2+gySk3jMoJWq hNz2GmCE0j0mrpzJnVAETYozI/b2r/U= X-Authority-Analysis: v=2.4 cv=D4d37PRj c=1 sm=1 tr=0 ts=6a31f8cd cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=kLZ2Z8zhSb2u0Y7Hii4A:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: 1qaaAiCsUbVqcVrun5dzgICzMuXMp5oc X-Proofpoint-ORIG-GUID: 1qaaAiCsUbVqcVrun5dzgICzMuXMp5oc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE3MDAxMSBTYWx0ZWRfX42PgU1ch0CcR HsP6IeTyfOwlaSsnMrX6Gfgl2vf6rKQPxZ6NdZbIh19kzKlDeDtX7ngOoNURMmvoDZ+UEWGpk2C F8iXs1EDni+rVNAEHSNgay8qwdSmkajmj3xGnu0w0xxgDa89uosxFC7XKQVlKqkEBh+gvNijjqt zU9OelbA/gQJA5sgvK2pQEp2rL60tNzO5+e3QCLrFHevmJL+Oeeo/MeVnHdrHnkAAamPjfqZQ1s 0ui82ZXBHTFxIKtZvf7UwR2UaiHQ9GkxQQb75SLsn2BgrIZk7HUd/PusYVklZgvBf3mGtokSLfJ IstThkMo04kaC9OVjF067/AnXQGbKk4cbYESakfJ3ee75B964yt5Q0RCfWDYybEhr0CcaJW8gmB hBxrYcL0G0ADgZcSilf+pQoExCytXTKzJlwfxSOZcCJ+AVnU7IIVDol8zQNCUAwigneF+Ca3zUK YSFSVFu++O0lUTFBmuA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_05,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606170011 On 6/16/2026 6:27 PM, Konrad Dybcio wrote: > On 6/16/26 12:08 PM, Fenglin Wu wrote: >> Add haptics device node in the PMIH0108 PMIC base dtsi files, and enable >> it on several boards according to the LRA (Linear Resonant Actuator) >> component mounted on each of them. >> >> Signed-off-by: Fenglin Wu >> --- >> arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 7 +++++++ >> arch/arm64/boot/dts/qcom/kaanapali-qrd.dts | 7 +++++++ >> arch/arm64/boot/dts/qcom/pmih0108-kaanapali.dtsi | 9 +++++++++ >> arch/arm64/boot/dts/qcom/pmih0108.dtsi | 9 +++++++++ >> arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 7 +++++++ >> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 7 +++++++ > One commit per board, please > >> 6 files changed, 46 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts >> index 07247dc98b70..7e3f59fc008e 100644 >> --- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts >> +++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts >> @@ -952,6 +952,13 @@ wifi@0 { >> }; >> }; >> >> +&pmih0108_e1_haptics { >> + status = "okay"; > 'status' should go last > >> + >> + qcom,lra-period-us = <6667>; >> + qcom,vmax-mv = <3600>; > Do these properties depend on the physical characteristics on what's > connected to the other end of the haptics driver? Correct. They are basically the parameters of the LRA that's used on the board. You can find details of them in the binding document. > > Konrad