From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753832AbdARWBc (ORCPT ); Wed, 18 Jan 2017 17:01:32 -0500 Received: from mout.web.de ([212.227.17.11]:57366 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753208AbdARWAi (ORCPT ); Wed, 18 Jan 2017 17:00:38 -0500 Subject: [PATCH 5/5] um: ubd: Improve size determinations in do_ubd_request() To: user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, Anton Ivanov , Dan Williams , Hannes Reinecke , Jeff Dike , Jens Axboe , Richard Weinberger References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <8a539d85-ff17-296c-75be-913731c2febc@users.sourceforge.net> Date: Wed, 18 Jan 2017 23:00:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:1CtDUU8CI48XBdvDa+qbPXIJnxM3V6L6X+ujSuBCO54ov4vovgA UVx0PC/7X4+i3BCFoCUVbzpV5AzOKM9JMvCuglPIC2fRRYmdd+CNB7PHBEwISLAyyBs0ogA 9VCtgqsrpN/j30xFcpY7U3XSlk+4pCf/VXpjwcnY57wk87+46TLhwtVHRdYmrA/b3GWiWV5 QJTyN4TZPKcp1wJameq0g== X-UI-Out-Filterresults: notjunk:1;V01:K0:Cpn9JzavmHI=:P6xEcYOwIhnCFV+jINPQp4 9ivURvl7FfKntxAlR6DkSoeRszLk0ljhgBHpSzFaPkcV/ZodC/x7ietOoiNJmIbhN0tRLwF4s a8ERdZbFLpE1rERREONDu/Bd+SiNq44gLVHZr/nt3UT0bf9baKZTwJgOzbGCsC2/l+2pqZU2+ YAgfuRfsDv41k/LdUC1WYVGc4ZdQCq8EC1PJDe6yCU1PLdylMLxQtfetgctwgwVifUMQqhadP KSUbX3Cy2a3pV87oMHPS5YmpWSzFClJnnoS5abZqkRjUijVGG8t5jEOrDQz3Sn37Jq6JJMQkQ 6yDX96ySD8YfwBU66Kh4yKEEDyvjP5p2u7RwVmNBYJYRgYwzee5bGT3Sg3jQpInrV5RaaDY0f vKnO9GacEVInCC+BoAQlQEeYQEwdym+cPde7PeNUZ0+ukW49u81QFn3VtsQYXIYdBX+I/zEAg S5fS0akgaG7hTL08l9+vY3lMgvLT+3UP1VCJY8ypaXMgCx/JdlT1VoLr/A7cMU5BNHToqf9VG lPiwlpt1XGHzlLnjrCpCVY4Sk47gMrxoz4/NxK38PVEvTmDPL9UwVVXdxtmkx2BA7AtqPZzSf mHJqmHUIYjVq0bPMcapMfsgslSyfB2RJER5eBrzEHVHGfXycFPTy6toRwGdw69gWu43yeI3cc 2IG/3YcLjKNwv/hpRFdo9zHkJLKI+51I2xtjTXZIBJnlGWz7w2piQxoNdDbPxwh6meziRVp2K JWE6/3cnNrRJ1erscQ9i8dslZYvXg5xODAETub+x3xXmxKr18rLY9ZolwoszCqOoqoHR9sVVQ TPTZpfR Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 18 Jan 2017 22:38:04 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. Signed-off-by: Markus Elfring --- arch/um/drivers/ubd_kern.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index 6d686f735538..50327d5a9a01 100644 --- a/arch/um/drivers/ubd_kern.c +++ b/arch/um/drivers/ubd_kern.c @@ -1386,8 +1386,7 @@ static void do_ubd_request(struct request_queue *q) req = dev->request; if (req_op(req) == REQ_OP_FLUSH) { - io_req = kmalloc(sizeof(struct io_thread_req), - GFP_ATOMIC); + io_req = kmalloc(sizeof(*io_req), GFP_ATOMIC); if (io_req == NULL) { if (list_empty(&dev->restart)) list_add(&dev->restart, &restart); @@ -1401,8 +1400,7 @@ static void do_ubd_request(struct request_queue *q) while(dev->start_sg < dev->end_sg){ struct scatterlist *sg = &dev->sg[dev->start_sg]; - io_req = kmalloc(sizeof(struct io_thread_req), - GFP_ATOMIC); + io_req = kmalloc(sizeof(*io_req), GFP_ATOMIC); if(io_req == NULL){ if(list_empty(&dev->restart)) list_add(&dev->restart, &restart); -- 2.11.0