From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbdIVUIc (ORCPT ); Fri, 22 Sep 2017 16:08:32 -0400 Received: from merlin.infradead.org ([205.233.59.134]:55678 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751911AbdIVUIa (ORCPT ); Fri, 22 Sep 2017 16:08:30 -0400 Subject: Re: [PATCH] auxdisplay: fix broken menus To: Geert Uytterhoeven Cc: LKML , Linus Torvalds , Andrew Morton , stable , Miguel Ojeda Sandonis References: <4287974f-111e-793a-008b-d20b8a134eda@infradead.org> From: Randy Dunlap Message-ID: <8a5731dc-5ea4-ca1a-ae8e-12a6f8b4f8c4@infradead.org> Date: Fri, 22 Sep 2017 13:08:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22/17 12:46, Geert Uytterhoeven wrote: > Hi Randy, > > On Fri, Sep 22, 2017 at 8:23 PM, Randy Dunlap wrote: >> On 09/22/17 11:15, Geert Uytterhoeven wrote: >>> On Fri, Sep 22, 2017 at 6:24 PM, Randy Dunlap wrote: >>>> From: Randy Dunlap >>>> >>>> Having the CHARLCD Kconfig symbol between "menuconfig AUXDISPLAY" >>>> and "if AUXDISPLAY" breaks the AUXDISPLAY submenus, so move the >>>> CHARLCD Kconfig symbol above the "menuconfig" so that the menu >>>> display is continuous. >>>> >>>> Fixes: 39f8ea46724e (auxdisplay: charlcd: Extract character LCD core from misc/panel) >>> >>> Oops, sorry for that. >>> >>>> Cc: stable@vger.kernel.org # v4.12 >>>> Cc: Geert Uytterhoeven >>>> Cc: Miguel Ojeda Sandonis >>>> Signed-off-by: Randy Dunlap >>>> --- >>>> drivers/auxdisplay/Kconfig | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> --- lnx-414-rc1.orig/drivers/auxdisplay/Kconfig >>>> +++ lnx-414-rc1/drivers/auxdisplay/Kconfig >>>> @@ -5,6 +5,9 @@ >>>> # Auxiliary display drivers configuration. >>>> # >>>> >>>> +config CHARLCD >>>> + tristate "Character LCD core support" if COMPILE_TEST >>>> + >>> >>> What about moving it inside (i.e. right below) the "if AUXDISPLAY" instead? >> >> That works. >> But why? PANEL also selects CHARLCD, so it isn't specific to AUXDISPLAY. > > OK, I thought PANEL was under AUXDISPLAY, but apparently it isn't. > Perhaps it should be, just like ARM_CHARLCD? > I.e. move everything inside the big if AUXDISPLAY block? ARM_CHARLCD does not depend on AUXDISPLAY either. I wouldn't mind if all of them were inside the AUXDISPLAY if/endif for menu cleanness, but AFAIK it's not necessary for code dependencies. I was just working on a separate patch to change PANEL from config to menuconfig. That makes the PANEL sub-menu presentation cleaner. > >>>> menuconfig AUXDISPLAY >>>> bool "Auxiliary Display support" >>>> ---help--- >>>> @@ -13,9 +16,6 @@ menuconfig AUXDISPLAY >>>> >>>> If you say N, all options in this submenu will be skipped and disabled. >>>> >>>> -config CHARLCD >>>> - tristate "Character LCD core support" if COMPILE_TEST >>>> - >>>> if AUXDISPLAY >>>> >>>> config HD44780 -- ~Randy