From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARC: Don't check presense of Timer1 in SMP builds
Date: Tue, 13 Feb 2018 11:53:23 -0800 [thread overview]
Message-ID: <8a595f83-150c-443c-8aa6-b850877d841f@synopsys.com> (raw)
In-Reply-To: <20180213193504.28671-1-abrodkin@synopsys.com>
On 02/13/2018 11:35 AM, Alexey Brodkin wrote:
> In case of SMP we use GFRC from ARconnect and Timer1 is left
> untouched. Still with that check in place we're panicing if Timer1
> is missing in current hardware which is quite unexpected.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> ---
> arch/arc/kernel/setup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index cf97f7d88934..1142d76a7e8f 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -391,8 +391,10 @@ static void arc_chk_core_config(void)
> if (!cpu->extn.timer0)
> panic("Timer0 is not present!\n");
>
> +#ifndef CONFIG_SMP
> if (!cpu->extn.timer1)
> panic("Timer1 is not present!\n");
> +#endif
Curious, you have a config w/o TIMER1, so is this a fallout of recent discussions !
-Vineet
prev parent reply other threads:[~2018-02-13 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 19:35 Alexey Brodkin
2018-02-13 19:53 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a595f83-150c-443c-8aa6-b850877d841f@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®