mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jean Delvare <khali@linux-fr.org>,
	Guenter Roeck <guenter.roeck@ericsson.com>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: [PATCH 20/32] drivers/hwmon/pc87427.c: Use pr_fmt and pr_<level>
Date: Tue, 19 Oct 2010 23:51:44 -0700	[thread overview]
Message-ID: <8a5f258d9b494988e1ca2ded006423d9cdab8e54.1287556801.git.joe@perches.com> (raw)
In-Reply-To: <20101020035346.GA20178@ericsson.com>
In-Reply-To: <cover.1287556800.git.joe@perches.com>

Added #define pr_fmt KBUILD_MODNAME ": " fmt
Converted printks to pr_<level>
Coalesced any long formats
Removed prefixes from formats

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/hwmon/pc87427.c |   26 +++++++++++++-------------
 1 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/hwmon/pc87427.c b/drivers/hwmon/pc87427.c
index 9ec4daa..78c3e32 100644
--- a/drivers/hwmon/pc87427.c
+++ b/drivers/hwmon/pc87427.c
@@ -22,6 +22,8 @@
  *  mode, and voltages aren't supported at all.
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
@@ -1077,7 +1079,7 @@ static int __devinit pc87427_probe(struct platform_device *pdev)
 	data = kzalloc(sizeof(struct pc87427_data), GFP_KERNEL);
 	if (!data) {
 		err = -ENOMEM;
-		printk(KERN_ERR DRVNAME ": Out of memory\n");
+		pr_err("Out of memory\n");
 		goto exit;
 	}
 
@@ -1196,28 +1198,26 @@ static int __init pc87427_device_add(const struct pc87427_sio_data *sio_data)
 	pdev = platform_device_alloc(DRVNAME, res[0].start);
 	if (!pdev) {
 		err = -ENOMEM;
-		printk(KERN_ERR DRVNAME ": Device allocation failed\n");
+		pr_err("Device allocation failed\n");
 		goto exit;
 	}
 
 	err = platform_device_add_resources(pdev, res, res_count);
 	if (err) {
-		printk(KERN_ERR DRVNAME ": Device resource addition failed "
-		       "(%d)\n", err);
+		pr_err("Device resource addition failed (%d)\n", err);
 		goto exit_device_put;
 	}
 
 	err = platform_device_add_data(pdev, sio_data,
 				       sizeof(struct pc87427_sio_data));
 	if (err) {
-		printk(KERN_ERR DRVNAME ": Platform data allocation failed\n");
+		pr_err("Platform data allocation failed\n");
 		goto exit_device_put;
 	}
 
 	err = platform_device_add(pdev);
 	if (err) {
-		printk(KERN_ERR DRVNAME ": Device addition failed (%d)\n",
-		       err);
+		pr_err("Device addition failed (%d)\n", err);
 		goto exit_device_put;
 	}
 
@@ -1249,23 +1249,23 @@ static int __init pc87427_find(int sioaddr, struct pc87427_sio_data *sio_data)
 
 		val = superio_inb(sioaddr, SIOREG_ACT);
 		if (!(val & 0x01)) {
-			printk(KERN_INFO DRVNAME ": Logical device 0x%02x "
-			       "not activated\n", logdev[i]);
+			pr_info("Logical device 0x%02x not activated\n",
+				logdev[i]);
 			continue;
 		}
 
 		val = superio_inb(sioaddr, SIOREG_MAP);
 		if (val & 0x01) {
-			printk(KERN_WARNING DRVNAME ": Logical device 0x%02x "
-			       "is memory-mapped, can't use\n", logdev[i]);
+			pr_warn("Logical device 0x%02x is memory-mapped, can't use\n",
+				logdev[i]);
 			continue;
 		}
 
 		val = (superio_inb(sioaddr, SIOREG_IOBASE) << 8)
 		    | superio_inb(sioaddr, SIOREG_IOBASE + 1);
 		if (!val) {
-			printk(KERN_INFO DRVNAME ": I/O base address not set "
-			       "for logical device 0x%02x\n", logdev[i]);
+			pr_info("I/O base address not set for logical device 0x%02x\n",
+				logdev[i]);
 			continue;
 		}
 		sio_data->address[i] = val;
-- 
1.7.3.1.g432b3.dirty


  parent reply	other threads:[~2010-10-20  6:54 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 23:13 [PATCH] drivers/hwmon: " Joe Perches
2010-10-20  3:29 ` Guenter Roeck
2010-10-20  3:34   ` Joe Perches
2010-10-20  3:53     ` Guenter Roeck
2010-10-20  4:07       ` Joe Perches
2010-10-20  6:04         ` Henrik Rydberg
2010-10-20  7:34         ` Jean Delvare
2010-10-20 14:46           ` Guenter Roeck
2010-10-20 16:08             ` Joe Perches
2010-10-20 16:45               ` Jean Delvare
2010-10-20 16:38             ` Jean Delvare
2010-10-20 16:43               ` Guenter Roeck
2010-10-20 16:46                 ` Jean Delvare
2010-10-20 18:03                   ` Guenter Roeck
2010-10-20 16:27           ` Joe Perches
2010-10-20 16:42             ` Jean Delvare
2010-10-20  6:51       ` [PATCH 00/32] " Joe Perches
2010-10-20  6:51         ` [PATCH 01/32] drivers/hwmon/abituguru.c: " Joe Perches
2010-11-09 16:25           ` [01/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 02/32] drivers/hwmon/abituguru3.c: " Joe Perches
2010-11-09 16:28           ` [02/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 03/32] drivers/hwmon/adt7470.c: " Joe Perches
2010-11-09 16:29           ` [03/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 04/32] drivers/hwmon/applesmc.c: " Joe Perches
2010-10-20  9:54           ` Henrik Rydberg
2010-11-09 16:35           ` [04/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 05/32] drivers/hwmon/asb100.c: " Joe Perches
2010-11-09 16:35           ` [05/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 06/32] drivers/hwmon/asus_atk0110.c: " Joe Perches
2010-11-09 16:37           ` [06/32] " Guenter Roeck
2010-11-09 20:15             ` Luca Tettamanti
2010-11-09 20:34               ` Guenter Roeck
2010-10-20  6:51         ` [PATCH 07/32] drivers/hwmon/coretemp.c: " Joe Perches
2010-11-09 16:38           ` [07/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 08/32] drivers/hwmon/dme1737.c: " Joe Perches
2010-11-09 16:39           ` [08/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 09/32] drivers/hwmon/f71805f.c: " Joe Perches
2010-11-09 16:40           ` [09/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 10/32] drivers/hwmon/f71882fg.c: " Joe Perches
2010-11-09 16:41           ` [10/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 11/32] drivers/hwmon/hp_accel.c: " Joe Perches
2010-11-09 16:42           ` [11/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 12/32] drivers/hwmon/hwmon-vid.c: " Joe Perches
2010-11-09 16:43           ` [12/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 13/32] drivers/hwmon/hwmon.c: " Joe Perches
2010-11-09 16:44           ` [13/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 14/32] drivers/hwmon/ibmaem.c: " Joe Perches
2010-11-09 16:44           ` [14/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 15/32] drivers/hwmon/it87.c: " Joe Perches
2010-11-09  9:21           ` Jean Delvare
2010-10-20  6:51         ` [PATCH 16/32] drivers/hwmon/lis3lv02d.c: " Joe Perches
2010-11-09 16:46           ` [16/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 17/32] drivers/hwmon/lm70.c: " Joe Perches
2010-11-09 16:47           ` [17/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 18/32] drivers/hwmon/lm78.c: " Joe Perches
2010-11-09  9:25           ` Jean Delvare
2010-10-20  6:51         ` [PATCH 19/32] drivers/hwmon/pc87360.c: " Joe Perches
2010-11-09  9:31           ` Jean Delvare
2010-11-09  9:59             ` Joe Perches
2010-11-09 12:08               ` Jean Delvare
2010-10-20  6:51         ` Joe Perches [this message]
2010-11-09  9:35           ` [PATCH 20/32] drivers/hwmon/pc87427.c: " Jean Delvare
2010-10-20  6:51         ` [PATCH 21/32] drivers/hwmon/pcf8591.c: " Joe Perches
2010-11-09 16:49           ` [21/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 22/32] drivers/hwmon/pkgtemp.c: " Joe Perches
2010-11-09 16:50           ` [22/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 23/32] drivers/hwmon/sis5595.c: " Joe Perches
2010-11-09 16:51           ` [23/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 24/32] drivers/hwmon/smsc47b397.c: " Joe Perches
2010-11-09 16:51           ` [24/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 25/32] drivers/hwmon/smsc47m1.c: " Joe Perches
2010-11-09 16:52           ` [25/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 26/32] drivers/hwmon/via-cputemp.c: " Joe Perches
2010-11-09 16:53           ` [26/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 27/32] drivers/hwmon/via686a.c: " Joe Perches
2010-11-09 16:54           ` [27/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 28/32] drivers/hwmon/vt1211.c: " Joe Perches
2010-11-09 16:57           ` [28/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 29/32] drivers/hwmon/vt8231.c: " Joe Perches
2010-11-09 16:58           ` [29/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 30/32] drivers/hwmon/w83627ehf.c: " Joe Perches
2010-11-09 16:59           ` [30/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 31/32] drivers/hwmon/w83627hf.c: " Joe Perches
2010-11-09 17:00           ` [31/32] " Guenter Roeck
2010-10-20  6:51         ` [PATCH 32/32] drivers/hwmon/w83781d.c: " Joe Perches
2010-11-09  9:39           ` Jean Delvare
2010-11-09 10:04             ` Joe Perches
2010-10-20  7:42 ` [PATCH] drivers/hwmon: " Jean Delvare
2010-10-20 15:59   ` Joe Perches
2010-10-20 16:49     ` Guenter Roeck
2010-10-20 16:54       ` Joe Perches
2010-10-20 17:18         ` Guenter Roeck
2010-10-20 17:28           ` Joe Perches
2010-10-20 17:48             ` Guenter Roeck
2010-10-20 18:02               ` Joe Perches
2010-10-20 18:35                 ` Guenter Roeck
2010-10-20 19:08                   ` Joe Perches
2010-10-20 19:57                   ` Jean Delvare
2010-10-20 19:19   ` Davidlohr Bueso
2010-10-20 19:38     ` Jean Delvare
2010-10-20 19:52       ` Joe Perches
2010-10-20 19:59         ` Joe Perches
2010-10-20 20:36           ` Jim Cromie
2010-10-20 20:13         ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a5f258d9b494988e1ca2ded006423d9cdab8e54.1287556801.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=guenter.roeck@ericsson.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®