From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753477AbdA3NN6 (ORCPT ); Mon, 30 Jan 2017 08:13:58 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:56489 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753341AbdA3NNg (ORCPT ); Mon, 30 Jan 2017 08:13:36 -0500 Subject: Re: [PATCH] acpi: nfit: use %u format string specifier for unsigned ints To: wharms@bfs.de References: <20170130112502.24426-1-colin.king@canonical.com> <588F2A7F.8020501@bfs.de> Cc: "Rafael J . Wysocki" , Len Brown , Dan Williams , Vishal Verma , joeyli.kernel@gmail.com, Toshi Kani , linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: <8a5f5edd-a28d-892c-8d37-54ef2a1ea141@canonical.com> Date: Mon, 30 Jan 2017 12:01:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <588F2A7F.8020501@bfs.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/01/17 11:58, walter harms wrote: > > > Am 30.01.2017 12:25, schrieb Colin King: >> From: Colin Ian King >> >> scrub_mode and scrub_count are both unsigned ints, however, the %d >> format string specifier is being used instead of %u. Trivial fix, >> use %u. >> >> Signed-off-by: Colin Ian King >> --- >> drivers/acpi/nfit/core.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c >> index 2f82b8e..093b768 100644 >> --- a/drivers/acpi/nfit/core.c >> +++ b/drivers/acpi/nfit/core.c >> @@ -906,7 +906,7 @@ static ssize_t hw_error_scrub_show(struct device *dev, >> struct nvdimm_bus_descriptor *nd_desc = to_nd_desc(nvdimm_bus); >> struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc); >> >> - return sprintf(buf, "%d\n", acpi_desc->scrub_mode); >> + return sprintf(buf, "%u\n", acpi_desc->scrub_mode); >> } >> >> /* >> @@ -967,7 +967,7 @@ static ssize_t scrub_show(struct device *dev, >> if (nd_desc) { >> struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc); >> >> - rc = sprintf(buf, "%d%s", acpi_desc->scrub_count, >> + rc = sprintf(buf, "%u%s", acpi_desc->scrub_count, >> (work_busy(&acpi_desc->work)) ? "+\n" : "\n"); >> } >> device_unlock(dev); > > looks ok, > would it be an option to move the "\n" into the format string ? > this is much more common (see sprintf() above). yep, "%u%s\n" - I'll resend > > re, > wh > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >