From: Sinan Kaya <okaya@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration
Date: Sat, 19 Mar 2022 15:55:18 -0400 [thread overview]
Message-ID: <8a5fdf42-d457-7f47-b66a-8447fb297be0@kernel.org> (raw)
In-Reply-To: <08b7604d-f528-ecb7-a8b2-7c9c36518143@wanadoo.fr>
On 3/19/2022 2:24 AM, Christophe JAILLET wrote:
> Le 22/01/2022 à 19:05, Sinan Kaya a écrit :
>> On 1/15/2022 2:35 AM, Christophe JAILLET wrote:
>>> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
>>> dev->dma_mask is non-NULL.
>>> So, if it fails, the 32 bits case will also fail for the same reason.
>>>
>>> Simplify code and remove some dead code accordingly.
>>>
>>> [1]:
>>> https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t
>>>
>>
>> Can we please document this?
>
> Hi, the patch has been applied, but [1] is sometimes given as an
> explanation link.
>
> CJ
>
>
> [1]:
> https://lists.linuxfoundation.org/pipermail/iommu/2019-February/033674.html
Sounds good, please carry my
Acked-By: Sinan Kaya <okaya@kernel.org>
prev parent reply other threads:[~2022-03-19 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 7:35 Christophe JAILLET
2022-01-22 18:05 ` Sinan Kaya
2022-03-19 6:24 ` Christophe JAILLET
2022-03-19 19:55 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a5fdf42-d457-7f47-b66a-8447fb297be0@kernel.org \
--to=okaya@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®