mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pan Xinhui <xinhui@linux.vnet.ibm.com>
To: Jia He <hejianet@gmail.com>, linux-nfs@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32
Date: Mon, 12 Dec 2016 02:03:27 +0800	[thread overview]
Message-ID: <8a609db8-b715-4aad-913e-62fe8f6ec45d@linux.vnet.ibm.com> (raw)
In-Reply-To: <819a5924-6fd4-adce-c03f-2a83c99d0a27@linux.vnet.ibm.com>



在 2016/12/12 01:43, Pan Xinhui 写道:
>
> hi, jia
>     nice catch!
> However I think we should fix it totally.
> This is because do_proc_dointvec_conv() try to get a int value from a bool *.
>
> something like below might help. pls. ignore the code style and this is tested :)
									_untested_.

  reply	other threads:[~2016-12-11 18:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-11 15:36 [PATCH v2 0/1] " Jia He
2016-12-11 15:36 ` [PATCH v2 1/1] " Jia He
2016-12-11 17:43   ` Pan Xinhui
2016-12-11 18:03     ` Pan Xinhui [this message]
2016-12-12  2:48     ` hejianet
2016-12-12 12:54   ` kbuild test robot
2016-12-11 17:56 ` [PATCH v2 0/1] " Pan Xinhui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a609db8-b715-4aad-913e-62fe8f6ec45d@linux.vnet.ibm.com \
    --to=xinhui@linux.vnet.ibm.com \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=hejianet@gmail.com \
    --cc=jlayton@poochiereds.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®