From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 021E3C433ED for ; Thu, 6 May 2021 03:27:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9C43613CD for ; Thu, 6 May 2021 03:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231154AbhEFD2H (ORCPT ); Wed, 5 May 2021 23:28:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:59932 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbhEFD2F (ORCPT ); Wed, 5 May 2021 23:28:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3DE47B01C; Thu, 6 May 2021 03:27:07 +0000 (UTC) Subject: Re: [PATCH -next v4] bcache: Use DEFINE_MUTEX() for mutex lock To: Zheng Yongjun Cc: Hulk Robot , kent.overstreet@gmail.com, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210505110655.1461896-1-zhengyongjun3@huawei.com> From: Coly Li Message-ID: <8a60b85c-b4c3-5b4c-af1f-877980800ba7@suse.de> Date: Thu, 6 May 2021 11:27:03 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210505110655.1461896-1-zhengyongjun3@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/5/21 7:06 PM, Zheng Yongjun wrote: > Mutex lock can be initialized automatically with DEFINE_MUTEX() rather > than explicitly calling mutex_init(). > > This patch will reduce the size of bcache.ko about 16 bytes, the > reason as follows: > > Though this patch will increase the size of .data segment about 32 > bytes, it will also reduce the size of .init.text and > .rodata.str1.1(at x86_64), .rodata_str1.8(at arm64) total about 48 > bytes which reduce the size more than .data segment; > > Here is the statistics: > Sections: (arm64 platform) > Idx name size > -.init.text 00000240 > +.init.text 00000228 > > -.rodata.str1.8 000012cd > +.rodata.str1.8 000012b5 > > -.data 00000c60 > +.data 00000c80 > > Sections: (x86 platform) > Idx name size > -.init.text 000001d9 > +.init.text 000001bf > > -.rodata.str1.1 00000c80 > +.rodata.str1.1 00000c6d > > -.data 00000cc0 > +.data 00000ce0 > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun Added in my for-test queue. Thanks. Coly Li [snipped]