From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbdLFUZD (ORCPT ); Wed, 6 Dec 2017 15:25:03 -0500 Received: from mout.web.de ([212.227.15.14]:58698 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbdLFUZA (ORCPT ); Wed, 6 Dec 2017 15:25:00 -0500 To: kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML From: SF Markus Elfring Subject: [PATCH] tty: synclinkmp: Delete an error message for a failed memory allocation in startup() Message-ID: <8a63c9bc-77c3-5b7e-6911-86397e63abd7@users.sourceforge.net> Date: Wed, 6 Dec 2017 21:24:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Tl9abPqRbkWx/YLPrPOU616vlCX9fMfl5uZNUoqJnooFV736UJj CwTHo2eAgnwsemN0vkshkqipjN7FBB+Sy1nXlMo1GJy7z0zJYvphN07JfN01hhpEak09tMH JI+LNbgVpyV7XcHusL3kl7mfuVJMG/j3C9nXEQNSPNLRXvtImaan4LKz6V0fTsD4WCn7zdM pGAc1OmWrUNl30GI+48Tg== X-UI-Out-Filterresults: notjunk:1;V01:K0:NwDnyqgCggo=:GvVqTYb0SlwwRl8f+SPp5Y G6/tn3hGt3/almw1avoWvFxpCODIDBiRvgezOnD/mXEAUMx4zLj946vME0w2x34ttDmyrowfE D2mwaCahdtOvw3QX7ayN11e7aJ6eaLq15oToTHkrZel8U4qNJDW8ET8Yft5gPgGsI7EBaA/88 P3xw7brfb5ZpxqT21trVvALWeXBTJVCY9PGlqx2v4qAHev5TZwk/Cg1edp8Bt0yDXDlamxJ/F 97EcZ4lwL6fez52Q6n+yNx2WnsffUgtf2oqYwgFtiUTF/2MtSd+PZll+d3mb0KwAl+Fp6r+Cy fvZcBfS0MCebVoMZCKwZXjakDezCtBEaIftcSL3Fg700w5En3TqWuFPtcts24q8n/g6I+9aX6 1zYVtu3DXy25P4/M0kqfkZm6rmhPhAvUo6L1YdP8oTjrT94rHyD0HtrapZZ2QY0dFHN8V9l4x UutdxqZublhc9DIq7psJpLLbG2Pz9evnJo/cln6h5W0NbFUm8why98BaFajk50QwnYYeHTYph Yo3E5IMgCjcYQmYmUZLBL5rgPdzBxQWjbhm/IoSm84Zcb4t3WBZUuK2ORE0A2bYjQmrFATL/s 9yb493iQTXWX9kYWOemVgLA/V8pG0Vo3XmaFwVx7alBkIgD2escmmAdwV3zCqOV9HxqtJu3qJ HsPGrI0VJE8T88Es/eV5YWpPpn8po1Q7Yicfb1fpVd7hYzjrY9j83ICGsJn/x/2F3ZFmuDF3a 0nDo21EtKWL8C0wtbN1AdqZGAb15zVb+wHBE8SpguZTtBDTugUhgSk5BG95KMjIWGENUDbF81 a9k59WwvTwOpZJ/SynhNDy9q/mM5AXFW0+5cYW3eWKolQW6k7E= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 6 Dec 2017 21:21:07 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/synclinkmp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/synclinkmp.c b/drivers/tty/synclinkmp.c index d45f234e1914..e47d19bbe87a 100644 --- a/drivers/tty/synclinkmp.c +++ b/drivers/tty/synclinkmp.c @@ -2640,11 +2640,8 @@ static int startup(SLMP_INFO * info) if (!info->tx_buf) { info->tx_buf = kmalloc(info->max_frame_size, GFP_KERNEL); - if (!info->tx_buf) { - printk(KERN_ERR"%s(%d):%s can't allocate transmit buffer\n", - __FILE__,__LINE__,info->device_name); + if (!info->tx_buf) return -ENOMEM; - } } info->pending_bh = 0; -- 2.15.1