From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F5A62192F4 for ; Mon, 29 Dec 2025 20:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767038975; cv=none; b=DNH5oTRjFZFTAyaMbpbLZ6pF7edeeD7INeAU8OKxy3PS9hYkDyBCnXflIz2U8aiN9LmGiFjrDoFsDA9J6zy3ZdF4+sKMcd1O+MKY9ru2AzQuR1YRDddqQS1Fw3QPIiWWqXa90/XhsAtdSN+9xhpEvEywhgZtbrwVtwGZSfzIlUU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767038975; c=relaxed/simple; bh=yhRIb5panPmdiq/RTZpc/8+okJ5tM8TCCMxOoRkoV8w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z4dwEdGom133NV3jb5crg0776IBIDXGh/CBBgHHwXR5K1pDXL5zp7i0oWs/+AJg/pPacgV4rhQgHYGZjZxWwf2VNZwrF34u5ZLMgwa1yQWsZ+1Es/wQDCNOr7xE5oai1NDGJH0bJ0HelpWbbGcpPXfP/WH5y16m0bPW36N4Lfh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WKS8R7U0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AMihevzF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WKS8R7U0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AMihevzF" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BTJrSVZ2286694 for ; Mon, 29 Dec 2025 20:09:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f9tLp6hB3CCjo6tl7cSfSd8cgyhOHRdEAok0lYgrgqk=; b=WKS8R7U0ELykYWeg Rk4296f0hNNWP+N8zzag4y6s1ujDPXjrEDOv0QQV08agymcEPJ5xJqpFvkT4JZyx CAS9/LVqE7mLe3aV4ta5mOaaYicWhRjJbb3NeObo2a1/jjv3ObcZN1qsWVD/WV7h t9+T+nJhoW6QsfaIXqO2cWeQH/N61XHVGYVNCruZRoNDLh6bjc8HBs6BLW8e5bKH MRNEyeRzEocpHfH6jvQkCr1PtaVxspAumvsimH034KNgljQGiq9uwSPKDDEOw6yK YunUCiY9gmSnAlA2+zRSaKGARZC1usbGioje+NRHKvrkZu2wj5noFmFgis0G67fF GGUMuA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc06gr12y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 20:09:33 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4edaa289e0dso31314921cf.3 for ; Mon, 29 Dec 2025 12:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767038972; x=1767643772; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f9tLp6hB3CCjo6tl7cSfSd8cgyhOHRdEAok0lYgrgqk=; b=AMihevzFkJcgv4n56DO5WeewBeWsERB7j25x34Uebq+oJWrcYN94mFusesdXjlW2/p hLPlFFOHjAoPc9/yp0egdp30qlGTNVKkOIOFMtqtwP/K/Kpymv/rT3zoRFbRNCHO19a5 jKjKmRSUdfvL/rriIfuZbeHLfPZnZN0SF4eJKOSkOxZKFSBRuk3Q6+duRUb6/kFjwq1E fDO/MH6h3mD2xpHidFMbywxiPrrYxk4i0irhvhvuRqYXrIKY0afXFlH+6TY5uWlB2AXE 7Y9MK+Q/stQThCIrqxx/+23fjTGpVxwmeZ8Q60FNhCnpXGOYpwBta1oK/0iYDQsl2ppN poYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767038972; x=1767643772; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f9tLp6hB3CCjo6tl7cSfSd8cgyhOHRdEAok0lYgrgqk=; b=RjwClUYh1Kk4LV+NvQ8fp4wZsudRuCgw0wdBmiGq977KrC4H7hYqjqMqRaIxYfNyYl GmhFkx/57gD15d63HXHepPm3Uo/SAdX/DwR2XgUvmfT9WEhexDk/s4TcxyOGr0+cD3RH PZY44niZEhQUNJvqIDfWaaphRv+uzpqCc0C9xiktRb9fWvpvlLd5yhaQqyON+0LKj3vp CuUocsJQ/KLWWv4K+C0DCG7zd0yaNUaHIEsvaOCk+XDmytNCqZ2FoONbwFPAQJeTHK0X pprgGLP96CPGnOB+ssIfvgGNJwMxtdoeNcmaRwBubJ8aHn1TJv2uwpeJ4z9wv9Yw/lk3 Hl1A== X-Forwarded-Encrypted: i=1; AJvYcCUgZEttESU9s68mAuhBxIgIt6eB0D0W/S6sFDdM9TR0uFsoNZ3///tWQd/Jl5l0YqV/7eBZ5eTQkBiyf0o=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/X4XKH75FMTn0j9FEbpmawZ7DDQdVPuPZxPTb7hxaP7WfRTEs ALCTC9AlJ5TiGTwwNs1+JfJ5pfWGAB9SSKRkzawJKZg6fMm0BqG66v9RDdEzh6W+fLkzukOuMfH GN0nOW2zZnyY4Jvjb51IYz7tm21GAchvubf/h6GtjHSxC/2GDsAxgWnZ3Bao6bW8U3PM= X-Gm-Gg: AY/fxX7JkTyEfEpmvcrhlEaVNU7uP0cOsPDLOMl7dunEf9HS4gul1FaE/Odpkg64gTx Sm6yqkIbhSU3HuLhY5vHg6OReIDFsVrehsL/EOh274OfMDFtu23Bb2Q8ZLxNG3eJZ0qmS4DSVkh X75qhYwu7gGHc5elmYvW3MlGLnUCGaR7+9crHoSxabKsMsOKmTequ92pDiB6NOJF1UlJf84tXli JkuKL+8FGS/KnUA+3B1msEmiNdXUoMu5ZDw3/jRzTnziTIHAHMlnGh+YaVwa8Qeb0KrPS0k6Q13 cTcb2Uyyf8Qawl00d6SZq+1u//U0YJ96P51NeURmC7fywsxPWjmmd1tiCnQpDjd38NfwVTE4KnG vSJyCty5/Zshhml7LYkDLZN4CyK4Xil7aA8cNVOyX9RR08SpgI18GWGOtn8j6TLmCRQ== X-Received: by 2002:a05:622a:1819:b0:4ee:87e:dedf with SMTP id d75a77b69052e-4f4abdc433cmr358682331cf.8.1767038972459; Mon, 29 Dec 2025 12:09:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGm0o4PJ1efZdK7cCCaywgTcLp9LChUwOU7faNlTclPAySRBXp99GhA9cWhyaw0KrIm5+FEdA== X-Received: by 2002:a05:622a:1819:b0:4ee:87e:dedf with SMTP id d75a77b69052e-4f4abdc433cmr358681971cf.8.1767038972051; Mon, 29 Dec 2025 12:09:32 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f0cb27sm3352659966b.51.2025.12.29.12.09.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 12:09:31 -0800 (PST) Message-ID: <8a64f70b-8034-45e7-86a3-0015cf357132@oss.qualcomm.com> Date: Mon, 29 Dec 2025 21:09:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: display/msm/gpu: Narrow reg and reg-names for Adreno 610.0 and alike To: Krzysztof Kozlowski , rob.clark@oss.qualcomm.com Cc: Krzysztof Kozlowski , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251227110504.36732-3-krzysztof.kozlowski@oss.qualcomm.com> <2a35d31a-1a3e-4cd4-ac3a-27104ff12801@kernel.org> <8288af85-13da-46e3-8d89-71995fbd17f8@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <8288af85-13da-46e3-8d89-71995fbd17f8@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: T7uLl2TrpvDpvS3JGkmsxyQ_umllJmMF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDE4NCBTYWx0ZWRfXyRwClIRCIkJA +xIv78nH6cUDawgoc0HocEB6AiVrZa6bpsnzUNP5mpyea3fSJtCbs3DzIoVqltp+MEoK1ZkdeKo n74Djo3D4fBpe4URen3VFtSYIhq0BObpu1jFkKxR6MUu4l3Estk0vXJDjnJO2xdwODmklsvUMH4 uABIDmNba+kIxMsM6xmXx1SzVA+eX7/PoXq1hGTqJlhxDBU/pmDKQmMOUL1nCyFGy9iYSkukEdD 2yC45sdjGMXjwyZT+1J5YAwA3RQJeEuSDh7mHMESTaBzS3LUGL/BtyKhmpjpG4xzztUt6oyxx8U DleemZHb7OGtNn37WZgIOG2gZ+/NxyLZ/e+abzlJySPaaaKLWcMXK3e67QWYR3CR4eQOLyqPc+b vEmvwLCNZpTTum0My+G2Obw18qe9DHgr6uH4JKS43ccv2O0MwiIEc49T+oGb0/Pzq1NBZOJAr7/ FOtvkpPVmmx6DIF3NmA== X-Authority-Analysis: v=2.4 cv=A45h/qWG c=1 sm=1 tr=0 ts=6952dffd cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=wQVahuwBDa5KTzDLV_QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: T7uLl2TrpvDpvS3JGkmsxyQ_umllJmMF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_06,2025-12-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 bulkscore=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290184 On 12/29/25 8:23 AM, Krzysztof Kozlowski wrote: > On 28/12/2025 15:59, Rob Clark wrote: >> On Sat, Dec 27, 2025 at 11:56 PM Krzysztof Kozlowski wrote: >>> >>> On 27/12/2025 23:01, Rob Clark wrote: >>>> On Sat, Dec 27, 2025 at 3:05 AM Krzysztof Kozlowski >>>> wrote: >>>>> >>>>> DTS files for qcom,adreno-610.0 and qcom,adreno-07000200 contain only one >>>>> "reg" entry, not two, and the binding defines the second entry in >>>>> "reg-names" differently than top-level part, so just simplify it and >>>>> narrow to only one entry. >>>> >>>> I'll defer to Akhil about whether this is actually needed (vs just >>>> incomplete gpu devcoredump support for certain GPUs). In general >>>> cx_dbgc is needed to capture state for gpu devcoredump state >>>> snapshots, but not directly used in normal operations. It seems >>>> similar to the situation with mapping gpucc as part of gmu, ie. not >>>> something the CPU normally deals with directly, but necessary to >>>> capture crash state. >>> >>> I don't get why binding was added with cx_dbgc, but DTS not. Neither >>> binding nor DTS depends on actual usage, so I assume someone >>> intentionally did not want DTS to contain cx_dbgc and binding should >>> follow. Otherwise we should make the DTS complete and make the binding >>> strict (leading to warnings if DTS is not updated). >> >> I'm not sure about the history.. but I can say that cx_dbgc is only >> used for gpu state snapshot / devcoredump. So it would be easy to not >> notice if it were missing. >> >> We have a similar slightly ugly thing where gpucc is included in the >> gmu map.. only for devcoredump. Maybe we need a different way to >> handle these things that are only mapped for state capture? > > No. Either hardware has it or not. If hardware has it, then both DTS and > binding should have it. If people decided that DTS should not have it > (for whatever reason), then apparently that's the desired hardware > description and let's remove it from the binding to match the ABI. I don't recall why it was never added. It's <0x0 0x05961000 0x0 0x800> for both 6115 and 2290 though. I'll send a patch to fix that up. It seems like (at a glance) that there shouldn't be much of an issue with the crashdumper, but I'm not super sure either.. Konrad