Re: [PATCH 1/1] lib: remove leading spaces before tabs

[Joe Perches <joe@perches.com>]

On Tue, 2021-06-08 at 17:00 +0800, Leizhen (ThunderTown) wrote:
> On 2021/6/8 16:44, Andy Shevchenko wrote:
> > On Tue, Jun 8, 2021 at 10:14 AM Zhen Lei <thunder.leizhen@huawei.com> wrote:
> > > 
> > > 1) Run the following command to find and remove the leading spaces before
> > >    tabs:
> > >    find lib/ -type f | xargs sed -r -i 's/^[ ]+\t/\t/'
> > 
> > Hint for the future, try to use what Git provides, for example `git
> > ls-files -- lib/`.
> 
> Okay, thanks. I learned a new trick.

Perhaps another 'trick'.

checkpatch has SPACE_BEFORE_TAB which does this for any spaces before
a tab, not just at the start of lines.  But as you've no doubt seen,
many maintainers do not care for this sort of whitespace only change
so it's best to do this sparingly or only in drivers/staging/ paths.

For instance:

$ git diff --stat lib
$ git ls-files lib/ | \
  xargs ./scripts/checkpatch.pl --types=SPACE_BEFORE_TAB --fix-inplace
<checkpatch output>
$ git diff --stat lib
 lib/atomic64_test.c             |   2 +-
 lib/bitmap.c                    |   4 +-
 lib/btree.c                     |   4 +-
 lib/decompress_bunzip2.c        |   6 +-
 lib/fonts/font_mini_4x6.c       | 512 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------
 lib/locking-selftest.c          |  12 ++--
 lib/lockref.c                   |   2 +-
 lib/lru_cache.c                 |   2 +-
 lib/math/rational-test.c        |   2 +-
 lib/nlattr.c                    |   4 +-
 lib/raid6/neon.c                |   2 +-
 lib/raid6/sse2.c                |  12 ++--
 lib/reed_solomon/reed_solomon.c |   4 +-
 lib/scatterlist.c               |   4 +-
 lib/string.c                    |   4 +-
 lib/test_firmware.c             |   2 +-
 lib/test_kmod.c                 |   2 +-
 lib/test_overflow.c             |   2 +-
 lib/textsearch.c                |   2 +-
 lib/ts_bm.c                     |   2 +-
 lib/zlib_deflate/deflate.c      |   2 +-
 21 files changed, 294 insertions(+), 294 deletions(-)