From: vitor <vitor.soares@synopsys.com>
To: Matthew Wilcox <willy@infradead.org>,
Vitor soares <vitor.soares@synopsys.com>
Cc: <boris.brezillon@bootlin.com>, <wsa@the-dreams.de>,
<linux-i2c@vger.kernel.org>, <corbet@lwn.net>,
<linux-doc@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<arnd@arndb.de>, <psroka@cadence.com>, <agolec@cadence.com>,
<adouglas@cadence.com>, <bfolta@cadence.com>, <dkos@cadence.com>,
<alicja@cadence.com>, <cwronka@cadence.com>,
<sureshp@cadence.com>, <rafalc@cadence.com>,
<thomas.petazzoni@bootlin.com>, <nm@ti.com>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<geert@linux-m68k.org>, <linus.walleij@linaro.org>,
<Xiang.Lin@synaptics.com>, <linux-gpio@vger.kernel.org>,
<nsekhar@ti.com>, <pgaj@cadence.com>, <peda@axentia.se>,
<mshettel@codeaurora.org>, <swboyd@chromium.org>,
<joao.pinto@synopsys.com>, <luis.oliveira@synopsys.com>,
<manuel.abreu@synopsys.com>, <gustavo.pimentel@synopsys.com>
Subject: Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP
Date: Wed, 7 Nov 2018 15:15:17 +0000 [thread overview]
Message-ID: <8a71cb94-ccf5-8ec0-446a-37a29405f585@synopsys.com> (raw)
In-Reply-To: <20181029134100.GD28520@bombadil.infradead.org>
Hi Matthew,
Thank for your feedback.
On 29/10/18 13:41, Matthew Wilcox wrote:
> On Mon, Oct 29, 2018 at 10:06:56AM +0000, Vitor soares wrote:
>> +config DW_I3C_MASTER
>> + tristate "Synospsys DesignWare I3C master driver"
>> + depends on I3C
>> + depends on !(ALPHA || PARISC)
> why?
Please check this email thread: https://lkml.org/lkml/2018/10/8/393
>
>> + help
>> + Support·for·Synopsys·DesignWare·MIPI·I3C·Controller.
> These strange characters (displayed as a centred dot on my terminal)
> should probably be spaces.
Something went wrong here. I need to check it.
>
>> +static struct dw_i3c_xfer *
>> +dw_i3c_master_alloc_xfer(struct dw_i3c_master *master, unsigned int ncmds)
>> +{
>> + struct dw_i3c_xfer *xfer;
>> +
>> + xfer = kzalloc(sizeof(*xfer) + (ncmds * sizeof(*xfer->cmds)),
>> + GFP_KERNEL);
> You should be using struct_size() here.
This seem to be recent. I will use it next version :D
Best regards,
Vitor Soares
next prev parent reply other threads:[~2018-11-07 15:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 10:06 [PATCH 0/3] Add driver for Synopsys DesignWare I3C master IP Vitor soares
2018-10-29 10:06 ` [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP Vitor soares
2018-10-29 13:41 ` Matthew Wilcox
2018-11-07 15:15 ` vitor [this message]
2018-11-07 15:34 ` Geert Uytterhoeven
2018-11-07 17:16 ` vitor
2018-11-07 17:05 ` Matthew Wilcox
2018-11-07 17:30 ` vitor
2018-11-07 17:37 ` Matthew Wilcox
2018-10-29 10:06 ` [PATCH 2/3] dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings Vitor soares
2018-10-29 10:06 ` [PATCH 3/3] MAINTAINERS: Add myself as the dw-i3c-master module maintainer Vitor soares
2018-10-29 18:58 ` Joe Perches
2018-10-29 11:56 ` [PATCH 0/3] Add driver for Synopsys DesignWare I3C master IP Wolfram Sang
2018-10-29 13:21 ` Boris Brezillon
-- strict thread matches above, loose matches on Subject: below --
2018-07-20 20:57 Vitor soares
2018-07-20 20:57 ` [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP Vitor soares
2018-07-21 15:35 ` Andy Shevchenko
[not found] ` <9fdfaf4e-5a20-af81-82ef-0d9e327f9133@synopsys.com>
2018-07-25 16:56 ` Andy Shevchenko
2018-08-08 17:01 ` vitor
2018-07-27 13:38 ` Boris Brezillon
2018-08-08 17:28 ` vitor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a71cb94-ccf5-8ec0-446a-37a29405f585@synopsys.com \
--to=vitor.soares@synopsys.com \
--cc=Xiang.Lin@synaptics.com \
--cc=adouglas@cadence.com \
--cc=agolec@cadence.com \
--cc=alicja@cadence.com \
--cc=arnd@arndb.de \
--cc=bfolta@cadence.com \
--cc=boris.brezillon@bootlin.com \
--cc=corbet@lwn.net \
--cc=cwronka@cadence.com \
--cc=devicetree@vger.kernel.org \
--cc=dkos@cadence.com \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joao.pinto@synopsys.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.oliveira@synopsys.com \
--cc=manuel.abreu@synopsys.com \
--cc=mark.rutland@arm.com \
--cc=mshettel@codeaurora.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=peda@axentia.se \
--cc=pgaj@cadence.com \
--cc=psroka@cadence.com \
--cc=rafalc@cadence.com \
--cc=robh+dt@kernel.org \
--cc=sureshp@cadence.com \
--cc=swboyd@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=willy@infradead.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®