From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4771C48BE5 for ; Fri, 11 Jun 2021 17:45:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABA0B613CF for ; Fri, 11 Jun 2021 17:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230387AbhFKRrO (ORCPT ); Fri, 11 Jun 2021 13:47:14 -0400 Received: from mail-il1-f181.google.com ([209.85.166.181]:34801 "EHLO mail-il1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbhFKRrN (ORCPT ); Fri, 11 Jun 2021 13:47:13 -0400 Received: by mail-il1-f181.google.com with SMTP id w14so5937798ilv.1 for ; Fri, 11 Jun 2021 10:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5ijyroFp+98lSqnS5hYLTzKlmPzT6WfBJO8AA2eOMqw=; b=DUOyuwOium8uOtGloLPa2VcJroQ4qNKS6RSmUljVcBADDdOJDaQA4UsAUkuLri5So7 OObRNDN3g3u7/a5IrNcLvhURtokaoaJG6OyXq9Vka12e4VW9wXuzkZT73oN6uf0KDbNd 58+lIcXKh8u1DT0StKzB+SvGKJ55Fr/Y004JQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5ijyroFp+98lSqnS5hYLTzKlmPzT6WfBJO8AA2eOMqw=; b=NzhlkI5YorUfTOLT8YP61o+0/G1ly49VhixSvh+sDc32d2m60/NHXX65otpKiWY5Xh R41/ax6VM++FNa/iJPkPp2LxsGicR1gd12jCZNjC5CSlCjBoRZc4vZVQ23+HaZFXhidU EBVVs40jEgJuqOhpYV6h6XxAFN60mn5zjG8cpVFx7P+y6TJt9hWO82cQ2SsKssMhjiG7 4dRZiAk/JNU6N8pE0Yf9R4+93jA13bcYuk6dLhYKIXY4Rz4ZAHGa/Pam/1b1PvPiDe0s znUnPTi4nGGlJX6FVJSq1Ne0GPQeL7NdQRgwigeVCR1k0y0FPzfywXKWbWaJsJtCReJ8 J7rQ== X-Gm-Message-State: AOAM531Ldu1hCtqKeNNrFUPAhFTludb7bZkIfoLF+u0UpzNXI5rKZdoE 1A9EhZxwN+HFRRE8SpN8NqZh4A== X-Google-Smtp-Source: ABdhPJy7kad9tNY57/QiYORDCPdWEE9wmXOvWaoeTqcWMf6TkTJr/JkDeInO1JjwlrOgs3aRymSzYw== X-Received: by 2002:a92:c90d:: with SMTP id t13mr4163128ilp.172.1623433443190; Fri, 11 Jun 2021 10:44:03 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id i139sm3524563ioa.20.2021.06.11.10.44.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 10:44:02 -0700 (PDT) Subject: Re: [PATCH] kunit: Fix result propagation for parameterised tests To: Marco Elver , David Gow , Brendan Higgins Cc: Arpitha Raghunandan <98.arpi@gmail.com>, KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , Shuah Khan References: <20210611035725.1248874-1-davidgow@google.com> From: Shuah Khan Message-ID: <8a7e6806-97f5-6f13-5e97-328cf0d3a95d@linuxfoundation.org> Date: Fri, 11 Jun 2021 11:44:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/11/21 2:29 AM, Marco Elver wrote: > On Fri, 11 Jun 2021 at 05:57, David Gow wrote: >> >> When one parameter of a parameterised test failed, its failure would be >> propagated to the overall test, but not to the suite result (unless it >> was the last parameter). >> >> This is because test_case->success was being reset to the test->success >> result after each parameter was used, so a failing test's result would >> be overwritten by a non-failing result. The overall test result was >> handled in a third variable, test_result, but this was disacarded after >> the status line was printed. >> >> Instead, just propagate the result after each parameter run. >> >> Signed-off-by: David Gow >> Fixes: fadb08e7c750 ("kunit: Support for Parameterized Testing") > > Reviewed-by: Marco Elver > > Would Cc: stable be appropriate? > > Thanks, > -- Marco > >> --- >> >> This is fixing quite a serious bug where some test suites would appear >> to succeed even if some of their component tests failed. It'd be nice to >> get this into kunit-fixes ASAP. >> Will apply this with cc stable. >> (This will require a rework of some of the skip tests work, for which >> I'll send out a new version soon.) >> Thanks for the heads up. I will wait for new version. thanks, -- Shuah