From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E122FF662 for ; Mon, 26 Jan 2026 13:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769435492; cv=none; b=khumLDFabFg3uS9dnshhLLsVTv3LUR2gYXebw9MtgQkENIJIetQOKDYFg7wduh5NW5/i9pT6MTl/m1X5sQaK9EO4cI613J9Pa80fgePuimprlGR7vzI+alkjMB6e3YIqKhfaFArHE8CRYVcyV3p4gUek4AffZqlkMzcEPfo0Qss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769435492; c=relaxed/simple; bh=tgOUVefbY1NaweMNMgrdBc6Oy3vMy3/oPKtbIqwkA20=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZgF4Fn+sz6E+HrO21gkte78IfzbjzRRaUjOrOrRaSAdINcV7HjSMDJv7N9VLrpJkgkRqhk/ktT0LHVdHSEC/cbtIz+OjGezPnzIBUS+1MFf2Muk5Svteg66L6hITvaOZXAhgORMP1NB+tkN92Tfn2c0aHjVP/0IaSkiRgEXCTOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FNITiiM/; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FNITiiM/" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-81e9dd8fe25so304020b3a.0 for ; Mon, 26 Jan 2026 05:51:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769435491; x=1770040291; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G18aNb5G1BfpTzLJA/gXuSRUPPR96Y4IT4X76araThA=; b=FNITiiM/RHdsYL4tv3bVff0q/FahinPo8ogPrsCTaeMB8nyFzeAS9pSZK1YHqaSnOI +KmJlnnqDxqI6dB6FqakfBcc2pWRLopStwqIWI9H6D5tUeJxf4XN8Q+QbAF6mqyQzMum MbafGmn+N0r+IGOZCZqflDu1x5Qna1Mu1cM9OoK4zADt1giQbuK7je8XRscBTm0FmN8K HXdm/lDL2pVN/DJvKnmd14z8LlgCc0Wxj7qjEmwec6OIXUFzJ1gUMdX17Ic3X3DISFKs FdLAyeFfeMUE61S8Uy46AnTwg3p8Kg1DVXZHKW7Vj52fav7ST2x2xhnatM5P+yMleElJ OstQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769435491; x=1770040291; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G18aNb5G1BfpTzLJA/gXuSRUPPR96Y4IT4X76araThA=; b=K5V15zEsawGdArXB7WHBOF+7eAHpA9kC4zpnVxPpj8l0yLu5MdOSBU00OYlK2x0FQu HvV+keuJHL6aKzUOdylZz4qKj07PPAND6RjYQ67jTJjSqpSqZ2B3uD0y+o+qf3YNp2qm ysEnwkPfBwRhYKo6cnW97cPhhAzzU4KVpunWIOnZkgYo2iqAxpE/2HLAkxnjuzS+xT/0 F5W0Zp0iDSUhxOFIfeEakSgC6JhYipdy+mS446LaF3ihVmzH9Erw4fDl9rssrSC1Prtj /kdITgV8BIU05VlD3lpzeNj4pFU2pWY5w8F6vPaDwhXLiO9vh+ykEd2yv+GNv6lh4ul7 fLYw== X-Forwarded-Encrypted: i=1; AJvYcCV4x7+a9XtlNS1bPwCSSafg9gnrGPjdpkJNX6rivecO70/dlXRRJfaaBieG8LYe00HEuoUEmpsyWNM4pJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YxCJc6ILXYzQQqOAabmQMVoIqVku21kDsahFvPHkgPQE1whz1O8 t1IxZyUW6xiQgFF8FM+hEILWogkGsm+hGORrHLnO5mFPP1igfvhwB1CC X-Gm-Gg: AZuq6aJ0zvxszQvX5lmbhnUoqJLJCvAPUxYicwEK2v3y03xY+BvL1cfSoPshFsLXScm fWIW9FlZ51NAW8W4ufvEYxSqVAPtV8y46PtSjEDLbTRlx9sblaGGLjcbTiizOoOJOICEgtF3wct /aE6AwlqrPzn6zfx8WEbEqgyhWcDwHsOMUCJHiu2JWvTYMZo932MxaY2GImRmun7tLh+EGaejvv OWJSvdAC0Gj0+ihU+1JfL7aUCa3/OrfvrwOCbr4dCzzVe+39ddQHiWIokqOv4gnYXrZ8j3YEVaw FkTwE8C48CA7DoSuLhoabZPL+SaxGlJJQn+/EcKPFH5Ne+j5qp6edvG94DBL3xM+UR99x02jZ9p vOLVKczCMaTipW9TPdv+2ukKYsglSwU01mUEEVZY9VOUQpHcelpqOT/vRlsMZ8ojTxo+E5qvkJk aqt2cxSKfoF9kuEdiL21se X-Received: by 2002:a17:90b:5546:b0:352:d19c:684f with SMTP id 98e67ed59e1d1-353c41bb581mr3280300a91.8.1769435490724; Mon, 26 Jan 2026 05:51:30 -0800 (PST) Received: from [192.168.1.7] ([159.192.80.104]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c635a142b5csm8685831a12.10.2026.01.26.05.51.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 05:51:30 -0800 (PST) Message-ID: <8a7ed9d1-c667-418a-a72a-d8d24ed0f9f8@gmail.com> Date: Mon, 26 Jan 2026 20:51:25 +0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] usb: csc-acm: add Infineon/Comneon modem support (1519:0020) To: Svyatoslav Ryhel Cc: Oliver Neukum , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260122151746.7745-1-clamor95@gmail.com> <20260122151746.7745-2-clamor95@gmail.com> Content-Language: en-US From: Lars Melin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026-01-22 23:17, Svyatoslav Ryhel wrote: > чт, 22 січ. 2026 р. о 17:58 Lars Melin пише: >> >> On 2026-01-22 22:17, Svyatoslav Ryhel wrote: >>> Add support for Infineon/Comneon XMM626X modem that used in many Tegra30 >>> devices with GSM capablities like LG Optimus 4X (P880) and Vu (P895). >>> >>> The Vendor Id is 0x1519 >>> The Product ID is 0x0020 >>> >>> Output of lsusb: >>> Bus 001 Device 002: ID 1519:0020 Comneon HSIC Device >>> >>> Signed-off-by: Svyatoslav Ryhel >> >> Hi, >> please include a full lsusb output, ie lsusb -vd 1519:0020 so we can >> verify that union descriptors are missing. >> (I have seen a full lsusb output where they are included.) >> > Hello there! Sure, here is what I get if I use lsusb -vd 1519:0020 > > lg-p895:~$ lsusb > Bus 001 Device 001: ID 1d6b:0002 Linux 6.16.0+ ehci_hcd EHCI Host Controller > Bus 001 Device 002: ID 1519:0020 Comneon HSIC Device > lg-p895:~$ lsusb -vd 1519:0020 > Bus 001 Device 001: ID 1d6b:0002 Linux 6.16.0+ ehci_hcd EHCI Host Controller > Bus 001 Device 002: ID 1519:0020 Comneon HSIC Device > lg-p895:~$ lsusb -vd 1519:0020 > Bus 001 Device 001: ID 1d6b:0002 Linux 6.16.0+ ehci_hcd EHCI Host Controller > Bus 001 Device 002: ID 1519:0020 Comneon HSIC Device > > regular lsusb is added for reference. You are using a stripped down version of lsusb which doesn't give a verbose output, please install the full version and try again. If you don't have the full lsusb, how do you then know that your device has a faulty union descriptor? The full lsusb listing that I have for 1519:0020 has a correct union descriptor so doesn't need a quirk. thanks Lars