From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751920AbeAPL2I (ORCPT + 1 other); Tue, 16 Jan 2018 06:28:08 -0500 Received: from mx2.suse.de ([195.135.220.15]:36882 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbeAPL2G (ORCPT ); Tue, 16 Jan 2018 06:28:06 -0500 Subject: Re: [PATCH 2/2] nvme: add tracepoint for nvme_complete_rq To: Johannes Thumshirn , Christoph Hellwig Cc: Sagi Grimberg , Keith Busch , Linux Kernel Mailinglist , Linux NVMe Mailinglist References: <20180116103401.7883-1-jthumshirn@suse.de> <20180116103401.7883-3-jthumshirn@suse.de> From: Hannes Reinecke Message-ID: <8a7eef2d-6977-2999-8dff-2751e020a077@suse.de> Date: Tue, 16 Jan 2018 12:28:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180116103401.7883-3-jthumshirn@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/16/2018 11:34 AM, Johannes Thumshirn wrote: > Signed-off-by: Johannes Thumshirn > --- > drivers/nvme/host/core.c | 2 ++ > include/trace/events/nvme.h | 31 +++++++++++++++++++++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 4b6a56fe6ccf..bac4559d6134 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -258,6 +258,8 @@ static inline bool nvme_req_needs_retry(struct request *req) > > void nvme_complete_rq(struct request *req) > { > + trace_nvme_complete_rq(nvme_req(req), req->tag); > + > if (unlikely(nvme_req(req)->status && nvme_req_needs_retry(req))) { > if (nvme_req_needs_failover(req)) { > nvme_failover_req(req); > diff --git a/include/trace/events/nvme.h b/include/trace/events/nvme.h > index 2e93bc7d4f84..d47bd9223241 100644 > --- a/include/trace/events/nvme.h > +++ b/include/trace/events/nvme.h > @@ -9,6 +9,8 @@ > #include > #include > > +#include "../../../drivers/nvme/host/nvme.h" > + > #define nvme_opcode_name(opcode) { opcode, #opcode } > #define show_opcode_name(val) \ > __print_symbolic(val, \ > @@ -58,6 +60,35 @@ TRACE_EVENT(nvme_setup_cmd, > __parse_nvme_cmd(__entry->cmnd)) > ); > > +TRACE_EVENT(nvme_complete_rq, > + > + TP_PROTO(struct nvme_request *req, int tag), > + > + TP_ARGS(req, tag), > + > + TP_STRUCT__entry( > + __field( int, cid ) > + __field( __le64, result ) > + __field( u8, retries ) > + __field( u8, flags ) > + __field( u16, status ) > + ), > + > + TP_fast_assign( > + __entry->cid = tag; > + __entry->result = req->result.u64; > + __entry->retries = req->retries; > + __entry->flags = req->flags; > + __entry->status = req->status; > + ), > + > + TP_printk("command_id=%u, result=%llu, retries=%u, flags=0x%x, status=%u", > + __entry->cid, > + (unsigned long long)le64_to_cpu(__entry->result), > + __entry->retries, __entry->flags, __entry->status) > + > +); > + > #endif /* _TRACE_NVME_H */ > > /* This part must be boutside protection */ > Again, 'boutside' protection ... Other than that: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)