From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FED03C3C15 for ; Mon, 19 Oct 2026 09:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792402604; cv=none; b=IEIZYN9gIEXBy4g2L0S/M+fRIGOyhKDhGoq+SZcm4gLTQx6j9HO9zlvRgI0Ro8/1QUdbtAwumm8MiydmalqMQ9RCOi8+hi5Wty8hX4Yq/zsjLvAIfRNqUkqhSP/CX2KNFpNMJ8TJkOucsYYDJJG8goow5m3dn0PhT6g1nSzDodY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792402604; c=relaxed/simple; bh=iBFTmkMP8PuN6ZW3szsaOElyFMbaPaWUjSQ2ZEvUTP4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LSTq8d9c0ZI+w/nCQTuMYkkLKA9afGgSoqGMRfBOtkCY86ioV/alBeiyecIGyuBnDde30lCDnfxcmfnb9pVh92WI5wAijYvZ3ADvfzS0d1rBKS5bKzOHCLDXdqHLtlfbGzmOdlyv+icewZB7yYC4k7dAsvyVGIHwUA9q14q4jgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yAlaZzv4; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yAlaZzv4" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4a1682bff3cso8418475e9.1 for ; Mon, 19 Oct 2026 02:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1792402600; x=1793007400; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=44Qa1LQ6eICE2navxqvBq6MbiOP9jzE+4MSaCPYPCfE=; b=yAlaZzv4BRxQkJWm2Dii7cwjsnJLJBXGggPZGnWWarA1ZKGS291eNBbFX72C8Our+j Dj6tBKFgA9OsSGN5Q+uX/sBsNewUqYg8HpKRW4PVyxU5mdATaG0TPe4s1zg+TljXt6B3 8efHJecOIarat2oL3VzMJkyZdr2NMuZ/kZP8kUqFKSxz8ZHaw9X5xRAo2TovrfxThFdG RDEmYQKACEbBpFzr+KstAoB+GggfD1LnZ90ckVtWZGbK5RcG8J2MZ0+WZ1j3lyRmbo04 TF27Bwt7ZWgXABnY8x0NG9mwzWcio06I/4Q1s8ytSAVm/S3/+p9czcv26JQs4p3GnHKQ v56w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792402600; x=1793007400; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=44Qa1LQ6eICE2navxqvBq6MbiOP9jzE+4MSaCPYPCfE=; b=Mv2ptzApiOBW6JW4VzIXPybSJ2TJXfqN6oJyskFaE99f4WYjLxU6jbc+VYkkG1SL6j Pgfg+y5SoN+e6JB14gvZXFv1fl3psQM1ZY5btgXwWagDgZ1L4asU0lh9MMUI+jEyOj6l xKT+SWZ7m3hETEGdnaFo+xMlY9/GtFu5lBBAEuwqDcEuciKz865XtZDzKdL9kOiWRAvD R/KctyxA5T3RdhQgBVjrYvO4pxiD5YvqjCLJ+nYrUz7Ic7SLvgTiqsycTiZ3ymgNUz03 2VCz6QFBjGK/B6hZUvuP00sPRtNb7Rrq15H1ISJTYdpEdVvh+TzToMTIRcD8TEo3eq98 y2Eg== X-Forwarded-Encrypted: i=1; AKwUvBwI3/WMg5UdH56TE/UbHcB8TqLcRPR341YQdkYPJf68rBDJbz45pcjkEEtCXJTH2z+jean/oJio7JgPhs4=@vger.kernel.org X-Gm-Message-State: AFq9FYIOXt5FpvBRA2V4qWjYf9+u8ppoXSM9tfDsasCAyG6eDs8pZ8a5 LePeFZ8wck2sny1Fu4+drLYo5AHkXsvFYHIghrposY73Qpk9ZJkuRf1Dpo9ke3rhb9E= X-Gm-Gg: AYBFou2WgaNd/l7zJoMQGov6kvPcp8jL4pjNnRl9xbeF+UnmBS85iMui4yQUxMvA5xm WXl3vore73+9bljioFeRbZ4HZ+pfvqCeD4kVe+4oiEsv+Uh96nIrrvAsfyVkfZcOrRO13akeODR GBVDUE94VgqYfqalPIB6wbKGQs31nW+3cBB0l+53NiiWf3ro2NwGUdwmO3h3iC9IRaTMDusWhJ4 B1lnJTmPM4eSakE8ID8nB+pW/0AesETe8gVgvPJqVP99BSUzbvviEpzv849j4fvF4duN7d6aBYk jqH7uMMBTzPejCpcW9lXuZ6NyJOVmbSBnbvIxFY03QSX+C9vC7Yv06eIQi+2pkoDu73jRe0o+y5 B74DP1zZOrdAF4F0CRpfwUKOqEQ5szJkZvgNAR6d5I/pcwjazsnYmPqadbfLQ1af35ztcY785uO QN0TXq5CrHKep/2HcpOCT8FF5ozhcB2mlZABXlggTuuirSonv9NvGJX3gBKR5L6UNyJULJ7+5Xm rg0S1spz1u1rFTYvUZdzRhJiWjQdOJuqee1t5hsbnIR5f+Unw== X-Received: by 2002:a05:600c:3b23:b0:4a1:cd83:b240 with SMTP id 5b1f17b1804b1-4a1d75ab20bmr188477405e9.1.1792402600230; Mon, 19 Oct 2026 02:36:40 -0700 (PDT) Received: from ?IPV6:2a0a:ef40:eb0:c501:2c4e:44f:2449:8978? ([2a0a:ef40:eb0:c501:2c4e:44f:2449:8978]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd4ecac3sm24062449f8f.27.2026.10.19.02.36.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2026 02:36:38 -0700 (PDT) Message-ID: <8a8313f1-d525-45d3-9044-b5f7a00b256d@linaro.org> Date: Mon, 19 Oct 2026 10:36:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/10] ARM: dts: omap: dm816x: Update USB node To: Andreas Kemnade , Ettore Chimenti Cc: Paul Walmsley , Aaro Koskinen , Kevin Hilman , Roger Quadros , Tony Lindgren , Russell King , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Christopher Obbard , Linus Walleij , Rouven Czerwinski , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org References: <20261016-patch-ektor5-dm8168-dts-v1-0-b4ce30217028@linaro.org> <20261016-patch-ektor5-dm8168-dts-v1-6-b4ce30217028@linaro.org> <20261017083957.7c2696f5@kemnade.info> Content-Language: en-GB From: Andrew Goodbody In-Reply-To: <20261017083957.7c2696f5@kemnade.info> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/10/2026 07:39, Andreas Kemnade wrote: > On Fri, 16 Oct 2026 16:41:21 +0200 > Ettore Chimenti wrote: > >> From: Andrew Goodbody >> >> USB node was not working correctly with DMA enabled as the supporting >> code had been updated without updating this SoC's device tree. Bring the >> device tree more up to date so that it works with DMA enabled. >> >> Signed-off-by: Andrew Goodbody >> Signed-off-by: Ettore Chimenti >> --- >> arch/arm/boot/dts/ti/omap/dm816x.dtsi | 41 +++++++++++++++++++++-------------- >> 1 file changed, 25 insertions(+), 16 deletions(-) >> >> diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi >> index 7f3ef3a00ab8..5be9efc60785 100644 >> --- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi >> +++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi >> @@ -574,18 +574,27 @@ uart3: serial@48024000 { >> }; >> >> /* NOTE: USB needs a transceiver driver for phys to work */ >> - usb: usb_otg_hs@47401000 { >> - compatible = "ti,am33xx-usb"; >> - reg = <0x47401000 0x400000>; >> - ranges; >> + usb: target-module@47400000 { >> + compatible = "ti,sysc-omap4", "ti,sysc"; >> + ti,hwmods = "usb_otg_hs"; > > Why do we still need this? It is depcrecated. > > Regards, > Andreas Without that line we get the following on boot and USB does not work [ 0.110148] omap_hwmod: usb_otg_hs: no dt node [ 0.110163] ------------[ cut here ]------------ [ 0.110169] WARNING: arch/arm/mach-omap2/omap_hwmod.c:2332 at _init+0x1a4/0x4c4, CPU#0: swapper/0/1 [ 0.110198] omap_hwmod: usb_otg_hs: doesn't have mpu register target base [ 0.110204] Modules linked in: [ 0.110221] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 7.3.0-rc7-g8e3242ad06d4 #11 VOLUNTARY [ 0.110235] Hardware name: Generic ti816x (Flattened Device Tree) [ 0.110242] Call trace: [ 0.110254] unwind_backtrace from show_stack+0x10/0x14 [ 0.110284] show_stack from dump_stack_lvl+0x54/0x68 [ 0.110307] dump_stack_lvl from __warn+0x8c/0x194 [ 0.110331] __warn from warn_slowpath_fmt+0x1a8/0x1b8 [ 0.110350] warn_slowpath_fmt from _init+0x1a4/0x4c4 [ 0.110367] _init from omap_hwmod_for_each+0x30/0x5c [ 0.110393] omap_hwmod_for_each from __omap_hwmod_setup_all+0x34/0xf8 [ 0.110412] __omap_hwmod_setup_all from do_one_initcall+0x54/0x2a4 [ 0.110431] do_one_initcall from kernel_init_freeable+0x208/0x2bc [ 0.110453] kernel_init_freeable from kernel_init+0x18/0x134 [ 0.110471] kernel_init from ret_from_fork+0x14/0x28 [ 0.110484] Exception stack(0xdf009fb0 to 0xdf009ff8) [ 0.110496] 9fa0: 00000000 00000000 00000000 00000000 [ 0.110507] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 0.110516] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 0.110611] ---[ end trace 0000000000000000 ]--- Andrew