From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A2EEB64DC for ; Mon, 10 Jul 2023 18:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231510AbjGJSfW (ORCPT ); Mon, 10 Jul 2023 14:35:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbjGJSfU (ORCPT ); Mon, 10 Jul 2023 14:35:20 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 393EDAB; Mon, 10 Jul 2023 11:35:19 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36ADrMGU031144; Mon, 10 Jul 2023 17:25:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=bzEbwR0TQhwP3H6/9WLQriTZaxfPzNPwjpCekJsIpKs=; b=Cu4nfM6i+MlB21q9hdoQF23AwPuNy+zdhag73EEGVgFNqDcHGu1t7cQU/M1ZUw0nqUmv TQhZHYTPk2FNSUNo1dneMwoRPfRK7CkQufiy4+vk+53MXWwi9H5Hra5aqqkhNfnz7IWj kHFPPibiWT/CMB1YDAxtJjKOfM3M4gVSQsQtuAsIbvjE26F2CSPg+UD21HtaB3XWvP2j a8JH+uMq3reqEQxr9QDa9eq7LvM8D/K56usijoaBQPW5yeiVCWZz6Ymv8jzaSSzDuXse D3dBxQfXklh82Qx6c+SDOV7KAq0qPO1bb+gbn8Q92w3lWZoKKjqe+yl1eZB0oELVAGar 3A== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rrg8193ke-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jul 2023 17:25:17 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36AHPGLg020222 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jul 2023 17:25:16 GMT Received: from [10.110.55.196] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 10 Jul 2023 10:25:15 -0700 Message-ID: <8a8b24ea-1abf-922c-439e-50a27cf2e5fa@quicinc.com> Date: Mon, 10 Jul 2023 10:25:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c Content-Language: en-US To: Abhinav Kumar , Dmitry Baryshkov CC: , , , , , , , , , , , , , , , References: <1688773943-3887-1-git-send-email-quic_khsieh@quicinc.com> <1688773943-3887-2-git-send-email-quic_khsieh@quicinc.com> <72cb729b-a9d3-3e5b-c70a-0761f47a6779@quicinc.com> <10de9309-19f9-18af-3e01-1cda7d76e73e@quicinc.com> From: Kuogee Hsieh In-Reply-To: <10de9309-19f9-18af-3e01-1cda7d76e73e@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: R__4hoOypJnSLxgzPrypwS9OBHYdgWoV X-Proofpoint-GUID: R__4hoOypJnSLxgzPrypwS9OBHYdgWoV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-10_13,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 impostorscore=0 malwarescore=0 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307100157 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/9/2023 1:32 PM, Abhinav Kumar wrote: > > > On 7/9/2023 11:00 AM, Dmitry Baryshkov wrote: >> On Sun, 9 Jul 2023 at 20:22, Abhinav Kumar >> wrote: >>> >>> >>> >>> On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote: >>>> On 08/07/2023 02:52, Kuogee Hsieh wrote: >>>>> Since both pm_runtime_resume() and pm_runtime_suspend() are not >>>>> populated at dp_pm_ops. Those pm_runtime_get/put() functions within >>>>> dp_power.c will not have any effects in addition to increase/decrease >>>>> power counter. >>>> >>>> Lie. >>>> >>> >>> Even if the commit text is incorrect, review comments like this are not >>> helping the patch nor the author and will just get ignored anyway. >> >> The review comment might be overreacting, excuse me. I was really >> impressed by the commit message, which contradicts the basic source >> code. pm_runtime_get() does a lot more than just increasing the power >> counter. >> > > It says within dp_power.c. Nonetheless, please let us know what is > missing in the context of this patch like Bjorn did to make it an > effective review and we can correct it. In its current form, the > review comment is adding no value. > I am new in pm. Any recommendation to revise this commit test? >>>>> Also pm_runtime_xxx() should be executed at top >>>>> layer. >>>> >>>> Why? >>>> >>> >>> I guess he meant to centralize this around dp_display.c. Will elaborate >>> while posting the next rev. >>> >>>>> >>>>> Signed-off-by: Kuogee Hsieh >>>>> --- >>>>>    drivers/gpu/drm/msm/dp/dp_power.c | 9 --------- >>>>>    1 file changed, 9 deletions(-) >>>>> >>>>> diff --git a/drivers/gpu/drm/msm/dp/dp_power.c >>>>> b/drivers/gpu/drm/msm/dp/dp_power.c >>>>> index 5cb84ca..ed2f62a 100644 >>>>> --- a/drivers/gpu/drm/msm/dp/dp_power.c >>>>> +++ b/drivers/gpu/drm/msm/dp/dp_power.c >>>>> @@ -152,8 +152,6 @@ int dp_power_client_init(struct dp_power >>>>> *dp_power) >>>>>        power = container_of(dp_power, struct dp_power_private, >>>>> dp_power); >>>>> -    pm_runtime_enable(power->dev); >>>>> - >>>>>        return dp_power_clk_init(power); >>>>>    } >>>>> @@ -162,8 +160,6 @@ void dp_power_client_deinit(struct dp_power >>>>> *dp_power) >>>>>        struct dp_power_private *power; >>>>>        power = container_of(dp_power, struct dp_power_private, >>>>> dp_power); >>>>> - >>>>> -    pm_runtime_disable(power->dev); >>>>>    } >>>>>    int dp_power_init(struct dp_power *dp_power) >>>>> @@ -173,11 +169,7 @@ int dp_power_init(struct dp_power *dp_power) >>>>>        power = container_of(dp_power, struct dp_power_private, >>>>> dp_power); >>>>> -    pm_runtime_get_sync(power->dev); >>>>> - >>>>>        rc = dp_power_clk_enable(dp_power, DP_CORE_PM, true); >>>>> -    if (rc) >>>>> -        pm_runtime_put_sync(power->dev); >>>>>        return rc; >>>>>    } >>>>> @@ -189,7 +181,6 @@ int dp_power_deinit(struct dp_power *dp_power) >>>>>        power = container_of(dp_power, struct dp_power_private, >>>>> dp_power); >>>>>        dp_power_clk_enable(dp_power, DP_CORE_PM, false); >>>>> -    pm_runtime_put_sync(power->dev); >>>>>        return 0; >>>>>    } >>>> >> >> >>