From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751988AbdJXSlw (ORCPT ); Tue, 24 Oct 2017 14:41:52 -0400 Received: from mail-cys01nam02on0059.outbound.protection.outlook.com ([104.47.37.59]:35200 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751511AbdJXSlo (ORCPT ); Tue, 24 Oct 2017 14:41:44 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gary.Hook@amd.com; Subject: Re: [Part2 PATCH v6 17/38] crypto: ccp: Implement SEV_PDH_GEN ioctl command To: Brijesh Singh , kvm@vger.kernel.org Cc: bp@alien8.de, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Borislav Petkov , Herbert Xu , Tom Lendacky , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171020023413.122280-1-brijesh.singh@amd.com> <20171020023413.122280-18-brijesh.singh@amd.com> From: Gary R Hook Message-ID: <8a8f02e2-f613-6da8-0e5c-5fc1cd22ec8f@amd.com> Date: Tue, 24 Oct 2017 13:41:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171020023413.122280-18-brijesh.singh@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR04CA0040.namprd04.prod.outlook.com (10.174.93.157) To MWHPR12MB1328.namprd12.prod.outlook.com (10.169.205.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3d4e961-0456-4cd1-13e6-08d51b0ede2b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:MWHPR12MB1328; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1328;3:83vKvG6Rvia8RZ1zP2o4nGSUp1kiOWZtP/rfOmYQymPfp3Zoq8oNNh/9duhwbYvR3JSrMc/7Eb7iJOkkKpkHDkGGmDKHoBsUZbZIyBTawQhukEotFjIVTLvHMX0fh23B88pobVTAHE50dxzl7GRdZvb9gte79VhJ1E1zhYRd9Uy3JcLVazn0kMklc7GFoYo9gY+PVr0W7YQugR+WfptSTeuoi2AVb+9R2FYlrvcXtnPkt0LwB2dUbHsYfa86rVK9;25:ABbH9Eq5C4fq5rN/19fi4UMArFUQ82CkCF6+Nk1l0NFNaxdEcJv+wQDah5vww11sQ33dpWDlGg5/xJI0+/+yDfgU3mfjO7rZLegn2XGhs4o66WB/quydOK2FE4ZjEaGpBmveYgEqW67QxCQPKuXMv5xJygHxD2r5juIF6wadzF+G9drI32FrIsJDIG7aB/H6Wt89NmIEqsmuG0CWy3WbYAILtzDOAW/8twT9/FvouSpjjLLCu17ObgTq2F1sa33YlFI+3PhKu3sA0wbgZf36c6oregyFf7MnRW7LN4OGFATC/6hij1fFT75prNHd9kR+MFsQKN34FBJePk3JiiFdBQ==;31:IA66mbWbXiJe8tn2ekt7KgXqDB3Rl3CHWYsQMg+5S7Rt+aQxqvA/tkUAuXrL6AI5UI665eL29bJMwM3UX7VQDSJxlfRg8WehuPPiE50PGd3yOliMSTVcF8GLPkO/HG8Hdm/ouPR4qflbKSRtzZVW6ZM+r6+lJR08rsALjUr0wy06DGZdUVFwRxPb4LzA/7rcDpMFwvs7/EKe0CmsEuAA78DO9oz2iH8ReYFu/6EC79s= X-MS-TrafficTypeDiagnostic: MWHPR12MB1328: X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1328;20:INbk3cM33MnHlEdeesmJp+cGH+ZbzRT+liSTx1eH2AZkCCnzjcXtApQm5kfN+RNT6TmNQssR6bKoFTXiOtwOmGM0Zdb4oeq0bKDzxmJO/fe77cJqfTDYT7/67nvx1kWx5IB6Td+V/QdWT02c5p9D67NYm62GGLIgriZWfAInDVr/vrWZlPY/j9rkh+3CgtkS8kno5/85LRq7HurcgZvPPM1aWjXkTH7Yu0H1S5fMc/oJvw/fnYfw/yg3KmpfwaYbhhDlhObTur8hP5PPpvySq1pDUuBQRs3o3w1iZgLsfl4oG924/OOybkvZtKWAJcf0jwlpq8QQjxVcaNAy1oNIUNZoxHlO7waPGBlrNe4iWKUM6hmnufXgeb9m7y2Y+Z9nRnWb2rI3nmfSRDCPkz3HeW4pWn5C5CfeOnUUqcReZ6t3N1pC7Ks5lmi7Qt0GKWmFm8AaT8Yda++DMRSzfWTlni9VN1wIkQvKJb6t6uuxP22G3LSEF2a6Yp6ZmpdZg0l7;4:nzMsOmLF4bgvQZ2e3c2rXMQbrHjpua3+8DK8h9LX9dzDFl6vPULHNFTD6sbkg5qIqeSku5btuMqQJxbE9L/aTRr6nsBcYOC5My+mTROvQ7KOY6NkxXRMd014vzCbdqTJ/2gJseRqSCD2SAnwdoULhFZSZbMW7p9PJHofbKbLo6IRcUFl9G6TjInyW4ntaUVP8YilK3dKrIZbezfF0JNSaOZipBDCFivKyjSoX0E5Co7g/DlPCyLU3ThFxgmH0ooVUoGNaE1bDAvw/MxB9fHO51D2W7BNzlHMMbHQLqjRXIwYeKjABeNXeWlfJwinMT0O X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231020)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123558100)(20161123564025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR12MB1328;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR12MB1328; X-Forefront-PRVS: 047001DADA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(39860400002)(376002)(346002)(24454002)(189002)(199003)(65826007)(478600001)(229853002)(72206003)(5660300001)(189998001)(36756003)(53936002)(68736007)(6246003)(105586002)(81166006)(7736002)(65806001)(8676002)(106356001)(2870700001)(65956001)(305945005)(66066001)(47776003)(97736004)(53546010)(23676002)(81156014)(54356999)(4326008)(76176999)(64126003)(54906003)(3846002)(6116002)(8936002)(50466002)(2950100002)(316002)(50986999)(83506002)(6666003)(86362001)(2906002)(33646002)(6486002)(31696002)(16576012)(58126008)(31686004)(16526018)(90366009)(101416001)(77096006)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1328;H:[10.236.19.127];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMzI4OzIzOkliMHRjbUNIWmtWRkhid1N5YVB4bmw4TVVS?= =?utf-8?B?T0VlZi8rYTkzRmxLVjFZTVdzMDVOTm9DSzVvaVhoUkNJWWYvNGpZQXpWVzIv?= =?utf-8?B?elgxUTFINXJpV3g1UXVaN1RMcjk1R0duOFROOHhVczMwV2tuNGl5SlZmNVd1?= =?utf-8?B?eFZMRzEybFo4dkgrcmZldnJsM09LNTJNbVprTU8xY0xCVXE2M1dZMkw5NTl5?= =?utf-8?B?eVVBZHQyQ3ZBbUxqVWdtay95enNUUlpvSzRlSGhXNWpjblhNbm1mSTFZcWhL?= =?utf-8?B?OExabTVqaTNFbGJGS0JpeGZVb1pUQkY3ZElJQjhmU3dLcFcrQnBHbkxldWRy?= =?utf-8?B?a3dhLzF3ekwwK0kwTXpJT0tkN1F1ajBtRDlVbnRDVEwrMDZxRWpBL0dxZkVh?= =?utf-8?B?UWRoS09KL0JVbmxTcDVsWk8xNnNVTlp0d1FlN0s5ZFN0N1dEVlc1V01TK0JJ?= =?utf-8?B?QU5qOUVFVUFWUDBQZC9BcGNGNXg5V2ppeXdCVUhvVExSbHNwalY0MTJmSmR4?= =?utf-8?B?M3Z6SUZqTnNPbWZTeWRveVB3RUtFRDJiQ3E5SUpwdkNNZGRkUU9mRnYwejQv?= =?utf-8?B?elZQM0s0MG9XRUNBd1NTNXFTSDNoa1M3VC9LSS9CVHlOUUxteEFIWW53OXcr?= =?utf-8?B?a3dnamtZdHpVMDdOeWM0cXZxSDhMbUVXTmx0U0RzNnVub29Gd3NHWURWa3lt?= =?utf-8?B?K2lRRmpMZjZJamlyTWt1Z2hKMjlqWmEvWDUxVXI1d1JKMFNNRU9IbHZSK1Bu?= =?utf-8?B?WG5PSU9WTitnSkpEM1hGMy9vaFZmL2dyWUEzRDB5UHFudExwUjlISXlwSmtY?= =?utf-8?B?Q0JCNzZ0dS9IZmVzSWRFUEhScU0vc2gvZkp6SUd1Rm1IV0ZOeFJHOHRSekRD?= =?utf-8?B?SjBON1hlSHduMWRnZVNLQ2VnaXEwTUs4Nms5RHlKVFR6aUFiSHhCMUwwb1g1?= =?utf-8?B?dUhZeUIvZGZBSDRqbDIrSmpQTHQ0Wnh5VFJyS0FuaExLTjBTbytTWkNQSDd0?= =?utf-8?B?UlFZVHlXQkNWN0VWK3lZUVBQQ2hjYnBQZjMyN2tBeWxYeG00bkRNb0Qrb2pS?= =?utf-8?B?RG5YeE5DOWJPWUdYeC9UZUR4bk9iMnZEOHFpTkZCODFpZDFwS3IzWDB4SmVZ?= =?utf-8?B?YzkvbVhUQXdmQVh3WExGM3NBOHo0dU1Na2lxNzl6eUh2S21RNEdDQlg4OGtP?= =?utf-8?B?K1V4VjB0UktwaVNmV0dUUmJEc3E2V21WQ1BjT0UyazZ4V2todVZQK0hqelYx?= =?utf-8?B?SzZqTk8xY1NHQXYvUkx3em9ycEZXMldZSUZDbmlvZVRqczd0QTdoYm85ZkJp?= =?utf-8?B?bGQwWE5EUkFNVkpHcVhhajRROUZXdTNQYzBNa3I4MnAxaUVCQWtWaXhwNU10?= =?utf-8?B?OE1YcWFBTWhKQW1Jam9pWXdKUStsaFU2UnREbTNCTi91SUR2S2xBOENBVVBo?= =?utf-8?B?L3pSNzUzZTNlZVpDUDc5S1o3VUlsWk9CMThGaGlqd0svUVhQeW5wVnp4dVlz?= =?utf-8?B?dDlSOHZqMGtndUlPRWdWa3U2dTNvUng4Smh4cUFzRlNueTZRTGk1NmVDeVZ0?= =?utf-8?B?cWhvYzBoVWFxZFNFanFIQnFLbmRMVjNlYnlSMXE4TTJHOFlaUmFqNU0yMzJW?= =?utf-8?B?TGM0czNvdXpWY0F1bXczTUR1OG1sYW5iWllRdXFxR2MxeSs4dnNvTWJDMlR4?= =?utf-8?B?aER1V1I3SUx5QmZMbXVkdzNVNkxTSXNNOXdueEFvTGpZdHZKanUrbXFzaWsz?= =?utf-8?B?aGVsTlZsdncwamh1Ym9pdDdjejIrQ2xaa21naCs2aGQ2TTJoU1k1MGQ2YU9F?= =?utf-8?B?WTN1R3A0WjBPNWVqYmdrcEV1NFpOamJlcWxKaHhJcDRIeEo2cGs5MWE5RzV3?= =?utf-8?Q?yWK2RsB29GM=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1328;6:YlvB3bln77ol+oYnrvfc0QnjgGWdSIDGG8sdIh284anTJjApn9Ynnh/uglhcLNmkEd6nxp3Ey6ljngnbly7nt3rxl6WXK9ZjEmEPhbkjAkqTPjUSeWjtJiCBAyHz/klfnv2ApdbZ76RwovW9ocpcCqUR4O7o10/SS5PW6Ounv1HuegZYs/GTMbUaqZroIjMDKzVM8k8QztTMk9425ZMKiudYgL3sQYiweDrxP9UEgIAVdVrZ4KPBgtFlGTA+46akCO/GYvzrtDJhVvMnpczKLccIJxnIjtde4WzoZKJmQOdr8hy4vzAD53c2RRM02BC09VbM3fkjXSgolmzs5y5SyA==;5:CN2GeY2OMFL3D3tOysFYmrhz3RLcZNDvrh5YETgkjQiWtVEUydz1EiLIZTAvi3Gp0W2DOd1+j5jFfA1s/sMGCAZQTcKxZbXxNwkspB8l6Vt/xXOJ+RJVxIVao/0wQn6AENTyH+buUYbZqHznBjHNKA==;24:+iNQi/tesIZYFSTmypgVnQY/jUIwa18xMPEC954s7e33F9cmxvRmZBlLvSAJvcOUejWwPPzPM+zpaWHnuCaYkg3OHfwlgVqth3K1Xm78rRE=;7:GKBbA3mo8x4fAUxhJ+zojtrffXBOFKUfPWPcxf6qSCi0R3zh8VKm0SQ0T0NYDrXJ63lrAcVfCvtgg3MBN5lMlmEqfwysZb9nTx2EQ0LTlrXzZsmgyrY5xXK6yaVtinZW386eENKTOBMACcxriSSHhocV/coaCGKuoaKWZcnVl04zZNkiX1MgPfvfqNuPm6OtOjUX1HRIATCLdbMns/+j+mkeyYRAnKZAtEV0Rb0l0G8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1328;20:+XrKvsVFCCtrwvyjMgFVjQ8UJAbwDoGd6AF9i3DTXtwezOJsSMls4RrUI8B5s80I3TYXIpihiP4GIYT+N4yrQNYoz5aQyI+lE0Ri01NM70VED1AfqzyaOQNni5V7A9vmgOCztGL9/k75zR7KIU2IprUodg1dkdp4bBfSq/Sgs8z3IrXyw2fU7o7wSLD3JJFcFnMR/4cPAGTHsqw52HJJI1elcyFt+F8IqLUSIIA8iGDp4IfysG3WHtwU1JumqLm1 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2017 18:41:39.9744 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b3d4e961-0456-4cd1-13e6-08d51b0ede2b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1328 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/2017 09:33 PM, Brijesh Singh wrote: > The SEV_PDH_GEN command is used to re-generate the Platform > Diffie-Hellman (PDH) key. The command is defined in SEV spec section > 5.6. > > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc: Borislav Petkov > Cc: Herbert Xu > Cc: Gary Hook > Cc: Tom Lendacky > Cc: linux-crypto@vger.kernel.org > Cc: kvm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Brijesh Singh Acked-by: Gary R Hook > --- > drivers/crypto/ccp/psp-dev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c > index 1d7212da25a5..d9771d104eea 100644 > --- a/drivers/crypto/ccp/psp-dev.c > +++ b/drivers/crypto/ccp/psp-dev.c > @@ -239,6 +239,9 @@ static long sev_ioctl(struct file *file, unsigned int ioctl, unsigned long arg) > case SEV_PEK_GEN: > ret = sev_ioctl_do_pek_pdh_gen(SEV_CMD_PEK_GEN, &input); > break; > + case SEV_PDH_GEN: > + ret = sev_ioctl_do_pek_pdh_gen(SEV_CMD_PDH_GEN, &input); > + break; > default: > ret = -EINVAL; > goto out; >