From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out28-97.mail.aliyun.com (out28-97.mail.aliyun.com [115.124.28.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 417F4218845 for ; Fri, 3 Apr 2026 05:29:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.28.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775194191; cv=none; b=kdQd/VRZg+eYRNBxN4usSogA6v96eoGnuz4114728O1rP7uZVvvxRGHjLfg+mKWpJ3vB4rlDcSEC8Zg6fYLVcdL9zMPKR30CSVsjvg+FGi4tKWpgHte/Jqp3+AA8ZcbR7PasrHgJ4TVWOY6TBCw/sKSiwdBJBJl8lcaiz27zpWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775194191; c=relaxed/simple; bh=OGA6F/rKtxMrdUf/KT1AaqzdXUPAGnmmAxf/Rw4GGtI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=teLmJQhkCYuPELzPTuFF9SccZEy2pS2sPYVs4RkMwpV3nLSCPwkgU3/DtuQcH8Zk1QDWcCl/N5N0zIzgWByLgRC52biM3B8pxJzDwpPeIdtL+rqy4WnpeITr5dOizP4rQTXMK9A/EUISD8jnpA3orbZJhSMcmvr7c15oVwVoTiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=open-hieco.net; spf=pass smtp.mailfrom=open-hieco.net; arc=none smtp.client-ip=115.124.28.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=open-hieco.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=open-hieco.net X-Alimail-AntiSpam:AC=CONTINUE;BC=0.1721768|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_news_journal|0.0252632-0.0032486-0.971488;FP=7925153442596217306|0|0|0|0|-1|-1|-1;HT=maildocker-contentspam033032027189;MF=wanglin@open-hieco.net;NM=1;PH=DS;RN=7;RT=7;SR=0;TI=SMTPD_---.h4HtKzd_1775194176; Received: from 172.18.24.170(mailfrom:wanglin@open-hieco.net fp:SMTPD_---.h4HtKzd_1775194176 cluster:ay29) by smtp.aliyun-inc.com; Fri, 03 Apr 2026 13:29:37 +0800 Message-ID: <8a90508f-04ef-4f6d-9f32-9b60e4a3aac8@open-hieco.net> Date: Fri, 3 Apr 2026 13:29:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 5/5] x86/amd_node: Support Hygon SMN roots by socket To: Borislav Petkov Cc: yazen.ghannam@amd.com, mario.limonciello@amd.com, tglx@kernel.org, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org References: <20260402111515.1155505-1-wanglin@open-hieco.net> <20260402111515.1155505-6-wanglin@open-hieco.net> <20260402235036.GDac8AzDPVVq-tBeG-@fat_crate.local> Content-Language: en-US From: Lin Wang In-Reply-To: <20260402235036.GDac8AzDPVVq-tBeG-@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Boris, On 4/3/2026 7:50 AM, Borislav Petkov wrote: > > All Hygon enablement goes into Hygon-specific files. If there's a piece of > functionality which is generic enough, then that can be extracted into > a function which can be called by both vendors code. > > But pls forget this piggy-backing on AMD code and thus turning AMD code into > an unmaintainable mess. > > Thx. > Thank you for the clear direction -- this is exactly the kind of architectural guidance we needed at this stage. Keeping Hygon enablement out of AMD code paths is the right call. We will rethink the integration approach for v2 with that principle in mind. Thx & br, Lin