From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457C4C433EF for ; Thu, 19 May 2022 11:54:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237589AbiESLyJ (ORCPT ); Thu, 19 May 2022 07:54:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237554AbiESLyC (ORCPT ); Thu, 19 May 2022 07:54:02 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19398B82EF for ; Thu, 19 May 2022 04:54:01 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id bq30so8702628lfb.3 for ; Thu, 19 May 2022 04:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ynDwu8qGPWur+txmdTa4k/0YDzFSlIMmuvwA/VUCzcg=; b=jWqkmG8QV2PoxNQ+o66kt3qtyZtYpeRrP0rJugh+e9gH7kcVEzZP/yKcacr0y3PwnM p6GWvmgX/7czZPAsvDZ4xZjdAlAzssas+2F3n7NaeCxka+Qx6SVxBqHy74aV1LUSP8wE b78Aubz4phDjpsq/KvNzv5s6HoFZGaagE66QShjpuCgkg85VUbpimlSM6/iTU/awIcqd eVdvZ90WBF24MmzYWZdtQfbJMQF4l7BxFR33NPOKECuK1l/MNwaGxcNgOYkAgWQoclVh Ho+xvNP3G7uobjrmOL7i2LM3vbraoxMEUu3ldCiaf3dlfttj4WWpDkrWcDHg0i1HIxCa 7oMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ynDwu8qGPWur+txmdTa4k/0YDzFSlIMmuvwA/VUCzcg=; b=kG+bkfaHrQhQ7DmcK7TJIzchzeHxnOVNBzimuSa+vu7biayF9EDntHtUeCd2oUPiR1 0xJwyu0qJaOs2TTGbEgxQpAjp4D+uwU9jcZd9F8VAVkSO9HCae9TdbD2RsJ0zjX/UZ2m 1Bv0WtsTMYsdY76p4WGr7gyaLhkG+WFZUE/8Lk7bI1//N+SaPdEiuHAF2QdiP6YBC9a8 hrTuBJXE3yzPvWPcbrlFmAB+FlQ5fNebypq1uV2sXi1VIk5q11Cx5EwiZpEH73byJGS1 61hiHs0XEE0PB19aZNpkkhb8zeH3Y+BiuKF7pAHmW6mO3Mjyv8KAXdxuyP5k3cOUE4XU N87Q== X-Gm-Message-State: AOAM530hFrmv4RsftbxV3GfPTyDmEXQpLEoLeuJq4O10ycPLjTNEFSWc 6qkux921Hz5Du8vm96Tt4MvYzXrvbtjvBiCr X-Google-Smtp-Source: ABdhPJyy+batuU6U7KxzGS5lRyhCFXqpKpfzC73MofPOeIr+/BfU8dM/DOOI35JzL47clkdUE0q8CQ== X-Received: by 2002:a05:6512:2397:b0:473:a6d9:5138 with SMTP id c23-20020a056512239700b00473a6d95138mr3117561lfv.332.1652961239433; Thu, 19 May 2022 04:53:59 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id o22-20020a2e9456000000b0024f3d1dae84sm571111ljh.12.2022.05.19.04.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 04:53:58 -0700 (PDT) Message-ID: <8a90ffbc-b376-9115-fb91-0b46d98873b7@linaro.org> Date: Thu, 19 May 2022 13:53:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: Removal of qcom,board-id and qcom,msm-id Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Rob Herring , Stephen Boyd , Arnd Bergmann , Andy Gross , Olof Johansson Cc: "devicetree@vger.kernel.org" , linux-arm-msm , Linux Kernel Mailing List References: <35051bec-98ea-b4c5-f734-06b3f22f3562@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <35051bec-98ea-b4c5-f734-06b3f22f3562@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/05/2022 13:39, Dmitry Baryshkov wrote: > On 19/05/2022 13:44, Krzysztof Kozlowski wrote: >> Hi, >> >> There was an old effort of removal of qcom,board-id and qcom,msm-id >> properties from Qualcomm SoC-based boards like [1]. >> >> First approach was to document them, which (obviously) was not well >> received [2] [3] [4]. >> >> The solution from Stephen was to encode these in the board compatible, >> so bootloader can extract that information. That seemed to receive >> positive comments, at least from Rob. [5] >> >> It was 2015... ~7 years later we are still things doing the same way, >> still with undocumented properties: qcom,board-id and qcom,msm-id. >> >> >> I would like to revive that topic, but before I start doing something >> pointless - any guidance on last patch from Stephen [5]? Was it ok? Some >> early NAKs? > > I do not quite fancy the idea of using extra tools to process dtb files. > At this moment it is possible to concatenate several kernel-generated > dtb files together. AOSP developers use this to have an image that boots > on both RB3 and RB5 boards. > > I think that changing compat strings only makes sense if Qualcomm would > use such compat strings in future. Otherwise we end up in a position > where we have custom bootloaders for the RB3/RB5/etc, but the majority > of the board requires extra processing steps. This was discussed in [2] [3] and [4] (previous links) and did not pass. Do you have any new arguments for above objections from Arnd, Olof and Rob? I don't think patch will get accepted if previous concerns during review are not addressed... > > So, I think, we should drop the unspecified usid aliases, document the > board-id/msm-id/pmic-id properties and stick with them. The existing properties need anyway documenting, probably as deprecated so the schema can pass, because we cannot fix the bootloaders easly. > They might be > ugly, but they are expected/processed by the majority of devices present > in the wild. Any change in DTS affects only future devices, so not in the wild... > >> [1] >> https://elixir.bootlin.com/linux/v5.18-rc7/source/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts#L14 >> >> [2] https://lore.kernel.org/all/7229476.C4So9noUlf@wuerfel/ >> [3] >> https://lore.kernel.org/all/1450371534-10923-20-git-send-email-mtitinger+renesas@baylibre.com/ >> [4] https://lore.kernel.org/all/20151119153640.GC893@linaro.org/ >> [5] >> https://lore.kernel.org/all/1448062280-15406-1-git-send-email-sboyd@codeaurora.org/ >> >> Best regards, >> Krzysztof > > Best regards, Krzysztof