From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Munehisa Kamata <kamatam@amazon.com>, linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Roger Pau Monne <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org, stable@vger.kernel.org
Subject: Re: [PATCH] xen-blkfront: use a right index when checking requests
Date: Wed, 9 Aug 2017 21:23:19 -0400 [thread overview]
Message-ID: <8a918f06-e348-a3e4-edf0-7a18aec48bcf@oracle.com> (raw)
In-Reply-To: <20170809223140.14298-1-kamatam@amazon.com>
On 08/09/2017 06:31 PM, Munehisa Kamata wrote:
> Since commit d05d7f40791c ("Merge branch 'for-4.8/core' of
> git://git.kernel.dk/linux-block") and 3fc9d690936f ("Merge branch
> 'for-4.8/drivers' of git://git.kernel.dk/linux-block"), blkfront_resume()
> has been using an index for iterating ring_info to check request when
> iterating blk_shadow in an inner loop. This seems to have been
> accidentally introduced during the massive rewrite of the block layer
> macros in the commits.
>
> This may cause crash like this:
>
> [11798.057074] BUG: unable to handle kernel NULL pointer dereference at 0000000000000048
> [11798.058832] IP: [<ffffffff814411fa>] blkfront_resume+0x10a/0x610
> ....
> [11798.061063] Call Trace:
> [11798.061063] [<ffffffff8139ce93>] xenbus_dev_resume+0x53/0x140
> [11798.061063] [<ffffffff8139ce40>] ? xenbus_dev_probe+0x150/0x150
> [11798.061063] [<ffffffff813f359e>] dpm_run_callback+0x3e/0x110
> [11798.061063] [<ffffffff813f3a08>] device_resume+0x88/0x190
> [11798.061063] [<ffffffff813f4cc0>] dpm_resume+0x100/0x2d0
> [11798.061063] [<ffffffff813f5221>] dpm_resume_end+0x11/0x20
> [11798.061063] [<ffffffff813950a8>] do_suspend+0xe8/0x1a0
> [11798.061063] [<ffffffff813954bd>] shutdown_handler+0xfd/0x130
> [11798.061063] [<ffffffff8139aba0>] ? split+0x110/0x110
> [11798.061063] [<ffffffff8139ac26>] xenwatch_thread+0x86/0x120
> [11798.061063] [<ffffffff810b4570>] ? prepare_to_wait_event+0x110/0x110
> [11798.061063] [<ffffffff8108fe57>] kthread+0xd7/0xf0
> [11798.061063] [<ffffffff811da811>] ? kfree+0x121/0x170
> [11798.061063] [<ffffffff8108fd80>] ? kthread_park+0x60/0x60
> [11798.061063] [<ffffffff810863b0>] ? call_usermodehelper_exec_work+0xb0/0xb0
> [11798.061063] [<ffffffff810864ea>] ? call_usermodehelper_exec_async+0x13a/0x140
> [11798.061063] [<ffffffff81534a45>] ret_from_fork+0x25/0x30
>
> Use the right index in the inner loop.
>
> Fixes: d05d7f40791c ("Merge branch 'for-4.8/core' of git://git.kernel.dk/linux-block")
> Fixes: 3fc9d690936f ("Merge branch 'for-4.8/drivers' of git://git.kernel.dk/linux-block")
> Signed-off-by: Munehisa Kamata <kamatam@amazon.com>
> Reviewed-by: Thomas Friebel <friebelt@amazon.de>
> Reviewed-by: Eduardo Valentin <eduval@amazon.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Roger Pau Monne <roger.pau@citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Cc: stable@vger.kernel.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
next prev parent reply other threads:[~2017-08-10 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 22:31 Munehisa Kamata
2017-08-10 1:23 ` Boris Ostrovsky [this message]
2017-08-10 9:43 ` Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a918f06-e348-a3e4-edf0-7a18aec48bcf@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=kamatam@amazon.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome