From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
"Michael Trimarchi" <michael@amarulasolutions.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Shengjiu Wang" <shengjiu.wang@nxp.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] pmdomain: imx: gpcv2: replace dev_err() with dev_err_probe()
Date: Thu, 24 Oct 2024 12:58:37 +0200 [thread overview]
Message-ID: <8a96c142-0d2d-4bdb-8211-06958250841b@linaro.org> (raw)
In-Reply-To: <20241024103540.3482216-1-dario.binacchi@amarulasolutions.com>
On 24/10/2024 12:35, Dario Binacchi wrote:
> The patch standardizes the probe() code by replacing the two occurrences
> of dev_err() with dev_err_probe(). Indeed, dev_err_probe() was used in all
> other error paths of the probe() function.
But why? Does not simplify the code and called function cannot defer. It
prints error, but your commit does not mention this as benefit.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-24 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 10:35 Dario Binacchi
2024-10-24 10:58 ` Krzysztof Kozlowski [this message]
2024-10-24 11:01 ` Marco Felsch
2024-10-24 17:26 ` Uwe Kleine-König
2024-10-24 18:08 ` Marco Felsch
2024-10-25 7:14 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a96c142-0d2d-4bdb-8211-06958250841b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®