From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1788828-1525113752-2-4793645366093531520 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='utf-8' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1525113751; b=Dwq+1W82YdBzCt9H1/mYo9EXgZwi/weZBHqgOWOa8eD57G2D8w YvAfyhRWaKF8YY2jmm3+fdeMUj9gAfWBfN6ZWcRtqQJ2Wrp8emFE7Y/xd9zRBpLm rkKW+VfmxIZEjGr6DcNkSVmXVcHuXqnjba5XpyhfTZ9IG13o2eKrYE8kGOByb2Sz EnCEZU9ixvK2n1e0Rnx02n3XQjo66wMMWdIIDjYknNh067VIQZKymnuf9obS3rr/ gBnnPMqZIiSZrO80x5zkrBfq+BjERvS6eCcn1viv1a18ashcaCT+ZTF3+BDFnRpX 6ymbXUzHBK4orqvoY7I6joprsD6uAUBcFcPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=reply-to:subject:to:cc:references:from :date:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:sender:list-id; s=fm2; t= 1525113751; bh=8OvqQlIhVn2EVeHdCCcHvgjImFvgORdFmKfyBeGXbGA=; b=i 86gMZ25lDNpRhUQslNarrz0rpEyTG5vaFNjDqm7ZrNHhDi93pJOHjcCx4olNUgvn wf6ZYGjxVSm0v7pdzFamXvkTaPKlc7JT5lxQ9CA73PW/j4Ocuyl7EGiL9LPtNrm1 UCoQYUlmztW3jsmY8yeEsQ6hPTG2eN/FBqNgmAM89+hqy4Bz4gAw5X3sr/jc7920 sjO8Aw9alxx53G1WdRRQeDM5UTjNuSfEmSojUadhPCupjHuU1B0CKELPkHW5/HlG 5QibNmMHNRVLvIuGT0WoL1vEsVIoRWquBrQbnVvQ/ETCzGOpNnyR5/aY7HC8qWaP Rcnk9ACYB7FTPSbVyiu7w== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=linux.ibm.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linux.ibm.com header.result=pass header_org.domain=ibm.com header_org.result=pass header_is_org_domain=no; x-vs=clean score=-100 state=0 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=linux.ibm.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linux.ibm.com header.result=pass header_org.domain=ibm.com header_org.result=pass header_is_org_domain=no; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfLZotYxi5/EoRoHlYOUAFIqdGxgEx9/u06wKLwdV/e4SEJUl/50SI3Js0+pZLw58WlbbqYn8xfO+1JN5afFPtYVESHtdv1k/1YYot9NbeJUCC6GobMh2 0pQrZvCdPCdJRs10Mh9XbSS3ibsrN8QHehD23c7dAOQeukQrq6T/dgWBRpFaEfok4DeM9nm6w9IxjD1jYtDt4udeHu97MjalP8ZyqVAjFwD8tBIIVMORN2Sk X-CM-Analysis: v=2.3 cv=E8HjW5Vl c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=BlP6yNvZOLzwPO152XkA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754628AbeD3Sm3 (ORCPT ); Mon, 30 Apr 2018 14:42:29 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:53006 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754625AbeD3Sm2 (ORCPT ); Mon, 30 Apr 2018 14:42:28 -0400 Reply-To: muriloo@linux.ibm.com Subject: Re: [PATCH] perf session: Fix undeclared 'oe' To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Alexander Shishkin , Andi Kleen , Arnaldo Carvalho de Melo , David Carrillo-Cisneros , He Kuang , Ingo Molnar , Jiri Olsa , Masami Hiramatsu , Paul Mackerras , Paul Turner , Peter Zijlstra , Sasha Levin , Simon Que , Stephane Eranian , Wang Nan , Namhyung Kim , Adrian Hunter References: <20180411184135.27664-1-muriloo@linux.ibm.com> <20180411193353.GA5656@kroah.com> <82d8f577-bbbb-0419-bf41-057522eb3f30@linux.ibm.com> <81025fb9-bab8-58ff-8f82-b1da9a1202ec@linux.ibm.com> <20180430172008.GA4266@kroah.com> <20180430174934.GB10052@kroah.com> From: Murilo Opsfelder Araujo Openpgp: preference=signencrypt Autocrypt: addr=muriloo@linux.ibm.com; prefer-encrypt=mutual; keydata= xsBNBFC2LJYBCADMXZCh0JjMe5T/r1QaUHwCCCvyVaMVniJyTBaqUXPujCaddOKJF+Qhnpnp 0QJfOr/mnpeXe/HXHw1ICEBlMLfgR+VzQKvb7PHCtrKLEhCKeQOhmII4sxvpUfV/zjZBqp9z 1ljZ+QJLr2j7mkKwdc1tZ2fyhev1OkbeeRgs3vAN1YMzN4BA1qRvID6BJBVE0SaMM0V4TxOH kjmA91n+B9rC3PQk03gN+7UAbrat3DQEAhLvrRyL3ncOWO6uayN7a5LvxxtrJrHJpaNcWdGD aUWXEfLsD4wD3xzldReOejqgxn2NOhvWa1P7MptwgXNYgPNLZ5nEVQLtD/CP37lS5KibABEB AAHNLk11cmlsbyBPcHNmZWxkZXIgQXJhdWpvIDxtdXJpbG9Ab3BzZmVsZGVyLmNvbT7CwHsE EwECACUCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJQti/pAhkBAAoJEJThzGhIzw44 IaAIALToGEGjp1E4Cvr6BoznLPDoWMmfiGeyekZihS/SsANM4hAV9982x4BXRjde4wICSMEt sBy+t0FUKr4gbNGzAb10P1OifLfqwlPfpHkolvd71hCBS3CDvnwoADDKcIttKqSy6EsSFPX7 5qqX/G2gVBjmZTxfj54EjQ7QE2EQdkqX1Rj/BBaiUyDtWjpIzieRdnkAkjKY0iOU7jX9Z8aD LcIijXgD6x594peuhORXMeBMmcdKOylKeS7JzRln37xHs5HYzSr2BMFm9Cvh7L4n4zL2UuJ9 7HhcXbAyhlU/slRjeBNnn0X4JRZmmgpYoxOcrP/3iZvlXDf+qMzoxd4H0I3OwE0EULYslgEI AJpuIIHFGV4l3aneSjMLRRX94w+n9HmOQWG3pcqVyv0rnhr9qnov7HTNQ+kPw6eXFWTxHXJD 4++eGizTHdtptcw73G8bzBs8hj9N85DTYon3doIEtQwRQdvd3I/oLL8PyKvRGmrJ17Aecprf 69OIqp43SIuH5rQ9u7uIS2dKxql+3v0VE5IcARyF82k8Ys7Jf0OtIFoIZRIF8sQkGFGJHlfa w0dMdfkvm9+ASUYJyCi1ggyyd46l4XTjAPs1wQwyLRmJ4aleL5FiXdTNNQ8SmYGDy17werKL fWcgqOZC/Z3cEK1LvYUzcqGrf8/3bsP2QMfvFmPEV4W2Co0DqPDxg1UAEQEAAcLAXwQYAQIA CQUCULYslgIbDAAKCRCU4cxoSM8OOJPBB/4ld3N0LoT57XIZj2ZCJ0C9VdknlE9QTEG2huD0 mVAL2Em3ZydgJz/TWXEKAMO50OHDvHiRFutFGZtHZuhCDgENQCaRvyI/xfi/UUA29J8Ahg2l zaICSEXwAuFZnecurvgTX2ioZNPrri2rgjKqEB+uJhkYXAziMCFSq1m+blREfjipiPKnTcLB EYizy8CewE2qHW2whXiYO7E+UPg186pF86bXiNYpEJSWB9z7ZlFsHE+ABngUjqrrCAmoteTK URTzrqPMFaiUrColsoulJamkbEn7amM9pN285U3CFREnsRv5m7TmSnPhZbBzAbEeHEaeqwO3 xFlpAuK/RlKTJ/9D Organization: IBM Date: Mon, 30 Apr 2018 15:41:32 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180430174934.GB10052@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18043018-0052-0000-0000-000002E666F9 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008952; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000257; SDB=6.01025569; UDB=6.00523721; IPR=6.00804800; MB=3.00020867; MTD=3.00000008; XFM=3.00000015; UTC=2018-04-30 18:41:43 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18043018-0053-0000-0000-00005C83B95D Message-Id: <8a9a895b-6647-d3b1-ef78-31f0ec34192b@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-30_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804300179 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 04/30/2018 02:49 PM, Greg Kroah-Hartman wrote: > On Mon, Apr 30, 2018 at 10:20:08AM -0700, Greg Kroah-Hartman wrote: >> On Mon, Apr 30, 2018 at 02:11:55PM -0300, Murilo Opsfelder Araujo wrote: >>> On 04/11/2018 05:21 PM, Murilo Opsfelder Araújo wrote: >>>> On 04/11/2018 04:33 PM, Greg Kroah-Hartman wrote: >>>>> On Wed, Apr 11, 2018 at 03:41:35PM -0300, Murilo Opsfelder Araujo wrote: >>>>>> Using linux-3.18.y branch, perf build fails with the following: >>>>>> >>>>>> $ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=/usr DESTDIR=/tmp/builddir/build all >>>>>> [...] >>>>>> util/session.c: In function ‘__perf_session__process_pipe_events’: >>>>>> util/session.c:1093:36: error: ‘oe’ undeclared (first use in this function) >>>>>> ordered_events__set_copy_on_queue(oe, true); >>>>>> ^ >>>>>> util/session.c:1093:36: note: each undeclared identifier is reported only once for each function it appears in >>>>>> >>>>>> This patch fixes it for linux-3.18.y branch. >>>>> >>>>> Why is this failing now? Has it always been broken? Is there an >>>>> upstream patch that fixed this instead? >>>>> >>>> >>>> Hi, Greg. >>>> >>>> We've caught this build issue this week. I'm not sure since when it's >>>> failing. >>>> >>>> The upstream patch that fixes this is: >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa713a4eb9cebe5dec71b1bd11429603e17d841d >>>> >>>> commit fa713a4eb9cebe5dec71b1bd11429603e17d841d >>>> Author: Arnaldo Carvalho de Melo >>>> Date: Tue Mar 3 11:48:12 2015 -0300 >>>> >>>> perf ordered_events: Untangle from perf_session >>>> >>>> But it doesn't apply straightforwardly. At >>>> fa713a4eb9cebe5dec71b1bd11429603e17d841d, perf API and perf_evlist >>>> struct are slightly different from linux-3.18.y. >>>> >>>> A list of upstream patches for a clean backport (I think) would be: >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=54245fdc357613633954bfd38cffb71cb9def067 >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75be989a7a18e9666efd92b846ee48bed79e8086 >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=313e53b08e99b1dacf9ea2b0fbe97890db1ea95f >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9fa8727aa4d98d35ca50ef9cd8a50c6468af921d >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa713a4eb9cebe5dec71b1bd11429603e17d841d >>>> >>>> Do you prefer all above patches backported to linux-3.18.y or just the >>>> one-line fix I sent? >>>> >>>>>> Fixes: 95b33b99cdd6 ("perf inject: Copy events when reordering events in pipe mode") >>>>> >>>>> Was this just a bad backport? >>>> >>>> Some patches were left behind, I guess. >>>> >>>>> >>>>> thanks, >>>>> >>>>> greg k-h >>> >>> Hi, Greg. >>> >>> I've realized that perf build on v3.18.107 is still broken, actually, it >>> got a bit worse than v3.18.104. >>> >>> After applying my patch to fix the undeclared 'oe', perf build fails >>> with the following errors: >>> >>> $ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 >>> HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 >>> prefix=/usr DESTDIR=/tmp/builddir/build all >>> [...] >>> tests/code-reading.c: In function ‘read_object_code’: >>> tests/code-reading.c:145:19: error: ‘KMOD_DECOMP_LEN’ undeclared (first >>> use in this function) >>> char decomp_name[KMOD_DECOMP_LEN]; >>> ^ >>> tests/code-reading.c:145:19: note: each undeclared identifier is >>> reported only once for each function it appears in >>> tests/code-reading.c:208:2: warning: implicit declaration of function >>> ‘dso__needs_decompress’ [-Wimplicit-function-declaration] >>> if (dso__needs_decompress(al.map->dso)) { >>> ^ >>> tests/code-reading.c:208:2: warning: nested extern declaration of >>> ‘dso__needs_decompress’ [-Wnested-externs] >>> tests/code-reading.c:209:3: warning: implicit declaration of function >>> ‘dso__decompress_kmodule_path’ [-Wimplicit-function-declaration] >>> if (dso__decompress_kmodule_path(al.map->dso, objdump_name, >>> ^ >>> tests/code-reading.c:209:3: warning: nested extern declaration of >>> ‘dso__decompress_kmodule_path’ [-Wnested-externs] >>> tests/code-reading.c:145:7: warning: unused variable ‘decomp_name’ >>> [-Wunused-variable] >>> char decomp_name[KMOD_DECOMP_LEN]; >>> ^ >>> >>> Apparently, this was introduced by commit >>> 091b3b4ba55daf8b28f40794aefdaa0bdb5af7a1: >>> >>> commit 091b3b4ba55daf8b28f40794aefdaa0bdb5af7a1 >>> Author: Namhyung Kim >>> Date: Thu Jun 8 16:31:07 2017 +0900 >>> >>> perf tests: Decompress kernel module before objdump >>> >>> >>> Namhyung, are you fixing this? >> >> Ugh, I can fix this, I just did so on 4.4.y... > > Nope, this is a mess. When did perf last build on 3.18.y? It really > looks like no one cares about it... perf build is broken since v3.18.101. v3.18.100 works just fine. Cheers Murilo