From: Michal Simek <michal.simek@xilinx.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
Rajan Vaja <rajan.vaja@xilinx.com>,
Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: zynqmp-zcu100-revC: correct interrupt flags
Date: Mon, 21 Sep 2020 10:09:55 +0200 [thread overview]
Message-ID: <8a9aabc4-d030-5750-2c63-8747b758cae5@xilinx.com> (raw)
In-Reply-To: <20200917185052.5084-1-krzk@kernel.org>
On 17. 09. 20 20:50, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted same
> logical behavior behind the name "ACTIVE_xxx", this is:
> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Not tested on HW.
>
> Changes since v1:
> 1. Correct title
> ---
> arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index d60110ad8367..c9460693f4e9 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -186,7 +186,7 @@
> compatible = "ti,tps65086";
> reg = <0x5e>;
> interrupt-parent = <&gpio>;
> - interrupts = <77 GPIO_ACTIVE_LOW>;
> + interrupts = <77 IRQ_TYPE_LEVEL_LOW>;
> #gpio-cells = <2>;
> gpio-controller;
> };
>
Applied to https://github.com/Xilinx/linux-xlnx/tree/zynqmp/dt.
M
prev parent reply other threads:[~2020-09-21 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 18:50 Krzysztof Kozlowski
2020-09-21 8:09 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a9aabc4-d030-5750-2c63-8747b758cae5@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=anurag.kumar.vulisha@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajan.vaja@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®