From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938588AbdAIPkk (ORCPT ); Mon, 9 Jan 2017 10:40:40 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:56401 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760057AbdAIPjb (ORCPT ); Mon, 9 Jan 2017 10:39:31 -0500 Subject: Re: [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths To: Krzysztof Kozlowski , Alan Stern , Greg Kroah-Hartman , Kukjin Kim , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170107084141.3731-1-krzk@kernel.org> From: Javier Martinez Canillas Message-ID: <8a9d9fe4-5f24-e162-0adc-866c8eefd387@osg.samsung.com> Date: Mon, 9 Jan 2017 12:39:22 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170107084141.3731-1-krzk@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 01/07/2017 05:41 AM, Krzysztof Kozlowski wrote: > Returning from for_each_available_child_of_node() loop requires cleaning > up node refcount. Error paths lacked it so for example in case of > deferred probe, the refcount of phy node was left increased. > > Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs") > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America