From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BE2A201113 for ; Wed, 22 Jul 2026 15:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784735251; cv=none; b=RH9OyAMxlGfSndjVh8sUZI+zlkEsY64SPjpdFy02m388rWGYo74VlRD7F2IBISiCjxT/8AQmFi+Tziu4lGfVDxSff2qpKKRGEEWhxmbZsZpIoG66KlTo19rZsUqfXD+dy6AeGnjws+DHSV4iMGJ5iTLo1A/K79fp7akJW1nYGhs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784735251; c=relaxed/simple; bh=s/yVHps2FyLHyi2vB3TxS79OykfUq5grmQdJyi6j6Qo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sW+nHb3/qiDY4ObLxwpd89hLT9+pTP7N3OLmLH1MYC86SV6Qe+yWk8HqQN1dCg82vjkSsnlZdUkGbwNBvfhZToxuINpBeDn6E5EnwloXMM7ivgN3q4szu5kTXKgOtfGuKiDu4OFqPrUXDohbrHf7xwMs33elBpNCkJrRDazlo4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1wmZAK-000000006i7-0ApZ; Wed, 22 Jul 2026 15:47:24 +0000 Date: Wed, 22 Jul 2026 16:47:20 +0100 From: Daniel Golle To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Hermes Wu , Allen Chen , Pin-yen Lin , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Chen-Yu Tsai Subject: [PATCH v5 09/11] drm/bridge: it6505: hold endpoint OF node reference while parsing it Message-ID: <8a9ec00b8464f0dec0242792f7f9d990d33589a0.1784717129.git.daniel@makrotopia.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: it6505_parse_dt() drops the reference to each endpoint node right after looking it up and then keeps reading its properties, racing with the node being freed under CONFIG_OF_DYNAMIC. Put the node only once parsing is done. Fixes: 380d920b582d ("drm/bridge: add it6505 driver to read data-lanes and link-frequencies from dt") Signed-off-by: Daniel Golle --- v5: new patch drivers/gpu/drm/bridge/ite-it6505.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index e9208d827ce3..6f23203d5f2a 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -3364,7 +3364,6 @@ static void it6505_parse_dt(struct it6505 *it6505) } ep = of_graph_get_endpoint_by_regs(np, 1, 0); - of_node_put(ep); if (ep) { len = it6505_get_data_lanes_count(ep, 1, 4); @@ -3377,13 +3376,13 @@ static void it6505_parse_dt(struct it6505 *it6505) *max_lane_count = MAX_LANE_COUNT; dev_err(dev, "error data-lanes, use default"); } + of_node_put(ep); } else { *max_lane_count = MAX_LANE_COUNT; dev_err(dev, "error endpoint, use default"); } ep = of_graph_get_endpoint_by_regs(np, 0, 0); - of_node_put(ep); if (ep) { len = of_property_read_variable_u64_array(ep, @@ -3403,6 +3402,7 @@ static void it6505_parse_dt(struct it6505 *it6505) dev_err(dev, "error link frequencies, use default"); *max_dpi_pixel_clock = DPI_PIXEL_CLK_MAX; } + of_node_put(ep); } else { dev_err(dev, "error endpoint, use default"); *max_dpi_pixel_clock = DPI_PIXEL_CLK_MAX; -- 2.55.0