From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D48C92A1BA for ; Tue, 31 Dec 2024 16:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=96.67.55.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735662666; cv=none; b=jdsXtbqunTyZ4qzRzOqg2PkUhQddBdUJXAcJPw6ODhJYTAQF6w3T7Mh2BiD5h6IY+/zyPz1fRe+PDYuSiPsJcxPd9eItbM6ToTreRpwSWkM1flN3JSJYJL6Na9z1uBZIVQWQ20kbz7C6D5FIseguFFo91diiPmzZnwwsGPi8pVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735662666; c=relaxed/simple; bh=HR7CArQyxmAYVZENgfZFXxvYRDZ+39SeDd6/ixhGHsw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=WhFc3rBf6hNyR7UVT7DSGPQ1MMpVU1FzBRrYIFBMUj0JphcdYUIjkc21ychpJl7ry+yirqL9GWcZAMqdF9I2nyVVXocEo6LR8wP1ZxbJfBcrAXiscLtexMavk5kS7IulhUbjr1Gx7r+8NJmh4XFaWrqjtEa2z95IhgnGrxsxJLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com; spf=pass smtp.mailfrom=shelob.surriel.com; arc=none smtp.client-ip=96.67.55.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tSf8q-000000003eV-2OhO; Tue, 31 Dec 2024 11:30:48 -0500 Message-ID: <8aa196d4c781444cf55993faea56161b926cb311.camel@surriel.com> Subject: Re: [PATCH 01/12] x86/mm: make MMU_GATHER_RCU_TABLE_FREE unconditional From: Rik van Riel To: Borislav Petkov Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Date: Tue, 31 Dec 2024 11:30:48 -0500 In-Reply-To: <20241231161931.GFZ3QZk8kSgiImE90y@fat_crate.local> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-2-riel@surriel.com> <20241230184118.GMZ3LpTn3dHvu_bq-p@fat_crate.local> <20241231161931.GFZ3QZk8kSgiImE90y@fat_crate.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: riel@surriel.com On Tue, 2024-12-31 at 17:19 +0100, Borislav Petkov wrote: > On Tue, Dec 31, 2024 at 11:11:51AM -0500, Rik van Riel wrote: > > Will do. Between your feedback, the suggestions > > from Qi and Nadav, and the kernel test robot > > flagging some build issues without CONFIG_CPU_SUP_AMD, > > there's enough to warrant a v4 :) >=20 > Yes, just take your time pls. I need to get through the rest, first, > in the > coming days. >=20 I'm incorporating the feedback I have so far, and will test with those improvements. I'll wait for you to finish making your way through before coming up with a v4 :) I do have a question about the second to last patch "x86/mm: enable AMD translation cache extensions" It looks like with this patch the translation cache extensions get enabled (when I read back the MSR), but the AMD manual suggests I may need to enable EFER.TCE separately on every CPU? --=20 All Rights Reversed.