From: Arthur Grillo <arthurgrillo@riseup.net>
To: Maira Canal <mairacanal@riseup.net>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Maxime Ripard <mripard@kernel.org>,
Javier Martinez Canillas <javierm@redhat.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>
Cc: tales.aparecida@gmail.com, andrealmeid@riseup.net,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kunit-dev@googlegroups.com
Subject: Re: [PATCH 1/3] drm/tests: Fix kunit_release_action ctx argument
Date: Wed, 27 Sep 2023 19:52:25 -0300 [thread overview]
Message-ID: <8aab614e-1624-413d-693a-5934be6cdf8e@riseup.net> (raw)
In-Reply-To: <771e3ddf-aa15-5ff9-9689-ec0e02bc803a@riseup.net>
On 27/09/23 19:47, Maira Canal wrote:
> Hi Arthur,
>
> On 9/20/23 03:11, Arthur Grillo wrote:
>> The kunit_action_platform_driver_unregister is added with
>> &fake_platform_driver as ctx, but the kunit_release_action is called
>> pdev as ctx. Fix that by replacing it with &fake_platform_driver.
>>
>> Fixes: 4f2b0b583baa ("drm/tests: helpers: Switch to kunit actions")
>> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
>
> Reviewed-by: Maíra Canal <mairacanal@riseup.net>
>
> Do you need me to apply this patch to drm-misc-fixes?
Yes, please do, if possible.
Thanks,
~Arthur Grillo
>
> Best Regards,
> - Maíra
>
>> ---
>> drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
>> index 3d624ff2f651..3150dbc647ee 100644
>> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
>> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
>> @@ -118,7 +118,7 @@ void drm_kunit_helper_free_device(struct kunit *test, struct device *dev)
>> kunit_release_action(test,
>> kunit_action_platform_driver_unregister,
>> - pdev);
>> + &fake_platform_driver);
>> }
>> EXPORT_SYMBOL_GPL(drm_kunit_helper_free_device);
>>
next prev parent reply other threads:[~2023-09-27 22:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 6:11 [PATCH 0/3] Fix a couble of bugs in drm_kunit_helpers.c Arthur Grillo
2023-09-20 6:11 ` [PATCH 1/3] drm/tests: Fix kunit_release_action ctx argument Arthur Grillo
2023-09-20 6:29 ` Maxime Ripard
2023-09-27 22:47 ` Maira Canal
2023-09-27 22:52 ` Arthur Grillo [this message]
2023-09-30 15:17 ` Maira Canal
2023-09-20 6:11 ` [PATCH 2/3] kunit: Add kunit_move_action_to_top_or_reset() to reorder actions Arthur Grillo
2023-09-22 8:00 ` David Gow
2023-09-25 9:59 ` Maxime Ripard
2023-09-20 6:11 ` [PATCH 3/3] drm/tests: Fix a use-after-free bug in __drm_kunit_helper_alloc_drm_device() Arthur Grillo
2023-09-20 6:40 ` Maxime Ripard
2023-09-20 6:54 ` Arthur Grillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aab614e-1624-413d-693a-5934be6cdf8e@riseup.net \
--to=arthurgrillo@riseup.net \
--cc=airlied@gmail.com \
--cc=andrealmeid@riseup.net \
--cc=brendan.higgins@linux.dev \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mairacanal@riseup.net \
--cc=mripard@kernel.org \
--cc=tales.aparecida@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®