From: Shuah Khan <skhan@linuxfoundation.org>
To: Nick Desaulniers <ndesaulniers@google.com>,
Mark Brown <broonie@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev,
Guillaume Tucker <guillaume.tucker@collabora.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: kselftest_deps.sh: Support LLVM
Date: Thu, 15 Oct 2026 08:57:10 -0600 [thread overview]
Message-ID: <8aad13a4-1097-40d1-a0ed-c44ef84838b4@linuxfoundation.org> (raw)
In-Reply-To: <CAKwvOdnoZfE3bqNnRBTR4G805V4-iooe9YwS8ZO0ka2h9bgDQg@mail.gmail.com>
On 10/14/26 10:42, Nick Desaulniers wrote:
> On Tue, Oct 13, 2026 at 3:01 PM Mark Brown <broonie@kernel.org> wrote:
>>
>> On Tue, Oct 13, 2026 at 02:07:28PM -0700, Nick Desaulniers wrote:
>>> On Tue, Oct 13, 2026 at 12:40 PM Mark Brown <broonie@kernel.org> wrote:
>>
>>>> + clang_target[riscv]=riscv64-linux-gnu
>>>> + clang_target[s390]=s390x-linux-gnu
>>>> + clang_target[x86]=x86_64-linux-gnu
>>
>>> ^ should this be either i386-linux-gnu or i686-linux-gnu, or does
>>> `-m32` get set somewhere?
>>
>> Hrm, that'll just be a cut'n'paste from lib.mk which does not so far as
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/lib.mk
>
>> I can see set -m32 - it sets i386-linux-gnu for _i386. Does that need a
>> fix too, or am I missing something with how it works?
>
> Ah, no looking at
> commit 624c60f326c6 ("selftests: fix LLVM build for i386 and x86_64")
>
> it looks like selftests have i386, x86, and x86_64 where x86 is x86_64
> IIUC. I see you also have a distinct i386 target. My bad.
>
> Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Thank you. Applied kselftest next for 7.4-rc1
thanks,
-- Shuah
prev parent reply other threads:[~2026-10-15 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 19:40 Mark Brown
2026-10-13 20:04 ` Shuah Khan
2026-10-13 21:07 ` Nick Desaulniers
2026-10-13 22:00 ` Mark Brown
2026-10-14 16:42 ` Nick Desaulniers
2026-10-15 14:57 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aad13a4-1097-40d1-a0ed-c44ef84838b4@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=guillaume.tucker@collabora.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®