From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 375053358D6 for ; Sat, 7 Feb 2026 17:34:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770485653; cv=none; b=CWb+btjutjd3qUXg8d2ucAlHvygGW4yZysf06l0qoRGOYIPEcokcuU8jwt0kilbfpbuV5HWuqqmXfzpCTEM3v1DyMGpZ0EmLicykAKsR8W6Z3CkK5AA21EScX0NbFFLx9E8Uu2pctWyfmZdpz3AH9V2si34TJYr1t7IXodFEs4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770485653; c=relaxed/simple; bh=x3dSlFE9Ty2D0TuGFufALmSD7yE0B0bMm9bdTzyqCqM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lvRONhy/YomyJwc+uBhz08j/58ZJ1c/4G71wMgeX5OXxRjC/dgzQcKPh0gbOibK3BWXL82UQSPEHYjmeqBO+ILXxVi3A35yhqqkjFDj9XyBVdgbHVzcRRAGTvE64Bhy68EHva89cwMXVo8EidxexxeBNhB5XCjMCLdJCdfTGhbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IELnriTq; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IELnriTq" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2ba64b5a53aso148834eec.0 for ; Sat, 07 Feb 2026 09:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770485652; x=1771090452; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=vWfIfyHpKZoIYtYm4HS2wsePgRkfeYlFHZpIDaa5Qds=; b=IELnriTqePkWEuBLDBo6p2vLiYH1ejuLKdY4m1/W4xcceNb1phidnz3e5Yl6qDHuxH cvJTxd5jDDF/dPcA1j6JG/8oewnqnRhemO8UphpsvmQNF2DbymoV0mZU16m7kI/U8df8 LZBn/b8XqhMFheXbXskyrDOJxkTEtyXmk29S4EYx9xO+wiXAZ9+C/5Rvty0EO4FqCcfD vJAm9+zZl+HDejCego+Ey9Bebl2TPzjF/RMMHh8dFr0fe+6NBzka6wP0Pqs9FhXFo81g w3MuJ1DUpUCB4rcIsmiexVCNp+dh4Y2Hv/9xkwmQ0u9lhg73d5TA20jTSbvgmOJeo6FU CafA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770485652; x=1771090452; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vWfIfyHpKZoIYtYm4HS2wsePgRkfeYlFHZpIDaa5Qds=; b=gg7dqJ1fAUORPhOwf+Po31x/TLwC2Oc32FkWj61QbeRtaNdtksGI9z0h/elH8h9w+W Rr5XdlELfjspGMov9BL3lJWU3LKep8CrkYmc6FvCnc3D52Qmy9nzo7Kgb3zblG9iUv9L 8kWWvxiba8sW068nT0kTcPVvaMfh5yZL1mHdZMfzBNjaZ979CPrB5LNpKpU8o/zvF7e0 nsUFuBCA6xfL6op3oMb6/AW/t9e9FEZlmq2ORtKKV3v7an01DUF/fwpnKX8I9P2Z9um5 O2sQQRRgeiZV3augSpRC6WvrMkIYh7+F3l1Fq2vEHXFFUmX4uVxF94eX3CKoBKq0/kME iaQw== X-Forwarded-Encrypted: i=1; AJvYcCWZm2vZcipXK+Yi/bATp3i90DDZQIeQtUbZXSiLfqv2HwXEOWPDDHs6G2vD+imZw3Amq5tmT00fL0VGS4U=@vger.kernel.org X-Gm-Message-State: AOJu0YxjNjgpXfBTvBnoqaX3I01NRqyVBW3DPVWjneqG7b72FjiqpPFW HOcNHV3JMUfUuPRWkwrsPY3DdyY2bEueUVcdgomAg2Y+ZfrCbujiHchF X-Gm-Gg: AZuq6aIwwIhcWEWWHzTILfjJAB4botMvWMMk+Avr3uFEQuERO12cZknk8qjey+08bYv uSazB4Rkcjxy9ujzYIR7pFdRgK7xm/g2few4CfaaEmEFMdz14lyBnj0CLcj/+R2gjgjzhiSCWPI qd17kbzP/FxD7hr8nINAjqp15Wv6bFFjGN6j00jAgLlsVFjTh9VyNyQCkUwTBN7EdRJx+MLg7RQ +0pjl+krpzxWySvLmrIChx9eYIluHmLiFrC3A6dlRf4yvAo6ALEM4tm78odc85Zw15Yc2Wm4ikL +ikEaziNV4SYqGGO8gvHRkvRb2J90P8KjMluWGikDmp1FvwSzlnv2Q5sTPmc3JKsdYjlO0yn3Dx tFuGx2qWYfS10Q3/V4C5kZEP4fj25gJy7DBV1SZ3NXndV6uSwU+O7Dg8qCecN+ru7yFmv7tPLc7 MibcbBEIvRgUNaV3pg2FPbykIOC9kNOL4NmsDtSuL2Dv6GZR53R2ZRLOnlC4AIpy0MRZ737ozgU D59DZt3SSo= X-Received: by 2002:a05:7300:f195:b0:2b7:26ab:1f74 with SMTP id 5a478bee46e88-2b85644eab5mr3151071eec.3.1770485652080; Sat, 07 Feb 2026 09:34:12 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1270433ab31sm5418990c88.11.2026.02.07.09.34.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Feb 2026 09:34:11 -0800 (PST) Sender: Guenter Roeck Message-ID: <8aae9201-b143-4433-889f-e32664adb9f8@roeck-us.net> Date: Sat, 7 Feb 2026 09:34:10 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master 10251/12094] drivers/hwmon/cros_ec_hwmon.o: error: objtool: cros_ec_hwmon_read+0x6c: can't find jump dest instruction at .text+0xd2d To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Tzung-Bi Shih , linux-kernel@vger.kernel.org References: <202602071311.Q6tATiyh-lkp@intel.com> <4db66fc2-dc8a-4499-bc9d-c1f85e2ba4c1@t-8ch.de> <957068ee-7368-4fd1-9e55-1449414238be@roeck-us.net> <317af5ed-fc8b-42d7-aa4a-143f8cf3ab04@t-8ch.de> <8edcc901-04aa-4d8d-a357-8653e29327e4@roeck-us.net> <9a2bfcad-f5b6-42c1-92fb-c8348909c909@t-8ch.de> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <9a2bfcad-f5b6-42c1-92fb-c8348909c909@t-8ch.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/7/26 08:43, Thomas Weißschuh wrote: > On 2026-02-07 08:26:37-0800, Guenter Roeck wrote: >> On 2/7/26 07:33, Thomas Weißschuh wrote: >>> On 2026-02-07 07:07:13-0800, Guenter Roeck wrote: >>>> On 2/7/26 02:56, Thomas Weißschuh wrote: >>>>> On 2026-02-07 13:14:53+0800, kernel test robot wrote: >>>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>>>>> head: 9845cf73f7db6094c0d8419d6adb848028f4a921 >>>>>> commit: 165c14597d53cfa7bc97b4ff8bc85f7bd98262b7 [10251/12094] hwmon: (cros_ec) Add support for temperature thresholds >>>>>> config: x86_64-randconfig-071-20260207 (https://download.01.org/0day-ci/archive/20260207/202602071311.Q6tATiyh-lkp@intel.com/config) >>>>>> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 >>>>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260207/202602071311.Q6tATiyh-lkp@intel.com/reproduce) >>>>>> >>>>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>>>>> the same patch/commit), kindly add following tags >>>>>> | Reported-by: kernel test robot >>>>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202602071311.Q6tATiyh-lkp@intel.com/ >>>>>> >>>>>> All errors (new ones prefixed by >>): >>>>>> >>>>>>>> drivers/hwmon/cros_ec_hwmon.o: error: objtool: cros_ec_hwmon_read+0x6c: can't find jump dest instruction at .text+0xd2d >>>>> >>>>> This is due to the call to unreachable() in cros_ec_hwmon_attr_to_thres(). >>>>> Replacing it with BUG() avoids the issue. >>>>> >>>>> Guenter, do you want to drop the patches for now and I'll resend them >>>>> next cycle? I can also send an incremental patch. Or you just fix it up >>>>> in your branch. >>>>> >>>> >>>> I strongly dislike BUG() because it means "I don't trust my own code". >>> >>> Agreed, I am not a fan either, which is why I used unreachable() >>> originally. >>> >>>> The final "else" in the code is not really necessary and should be dropped. >>> >>> That will trigger a compiler warning: >>> >>> drivers/hwmon/cros_ec_hwmon.c:170:1: error: control reaches end of non-void function [-Werror=return-type] >>> 170 | } >>> | ^ >>> >> >> I meant something like >> >> diff --git a/drivers/hwmon/cros_ec_hwmon.c b/drivers/hwmon/cros_ec_hwmon.c >> index 5b998cd5e506..6cf5ab0f4b73 100644 >> --- a/drivers/hwmon/cros_ec_hwmon.c >> +++ b/drivers/hwmon/cros_ec_hwmon.c >> @@ -165,10 +165,7 @@ static enum ec_temp_thresholds cros_ec_hwmon_attr_to_thres(u32 attr) >> return EC_TEMP_THRESH_WARN; >> else if (attr == hwmon_temp_crit) >> return EC_TEMP_THRESH_HIGH; >> - else if (attr == hwmon_temp_emergency) >> - return EC_TEMP_THRESH_HALT; >> - else >> - unreachable(); >> + return EC_TEMP_THRESH_HALT; /* attr == hwmon_temp_emergency */ >> } > > Welp, that was easy :-/ > Let's use it. Feel free to apply it directly. > Done - squashed into original patch. Thanks, Guenter