From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Igor Velkov <iav@iav.lv>,
Detlev Casanova <detlev.casanova@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Hans Verkuil <hverkuil+cisco@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Diederik de Haas <diederik@cknow-tech.com>,
Jonas Karlman <jonas@kwiboo.se>,
Francesco Saverio Pavone <pavone.lawyer@gmail.com>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] media: rkvdec: Do not keep the clocks enabled from probe
Date: Mon, 02 Nov 2026 10:21:20 -0500 [thread overview]
Message-ID: <8aafdbbf04a0d939c6b4d7d5577d97bb58d1c439.camel@collabora.com> (raw)
In-Reply-To: <20261030-rkvdec-runtime-pm-clocks-nicolas-reply-1@iav.lv>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
Hi,
Le vendredi 30 octobre 2026 à 20:05 +0200, Igor Velkov a écrit :
> On Fri, 30 Oct 2026 08:49:03 -0400, Nicolas Dufresne wrote:
> > So if CONFIG_PM is not set, the initial resume will never occur, and first mmio
> > access will likely hang the CPU. We need a clean pattern to handle this, and
> > perhaps review other similar drivers while at it.
>
> PM=n only happens with COMPILE_TEST: ARCH_ROCKCHIP selects PM on arm64 and
> arm. rkvdec had the same gap until 6a846f7d72c7; rga and rkisp1 have it today.
> v2 keeps the clocks enabled from probe when PM is off, as etnaviv and v3d do:
> https://lore.kernel.org/r/20261030-rkvdec-runtime-pm-clocks-v2-1-8ff510a231de@iav.lv
> rga and rkisp1 as separate patches?
Thanks for v2, and yes, best to send0 independent patches per driver assuming
you have time to do so.
regards,
Nicolas
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-11-02 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 1:33 Igor Velkov via B4 Relay
2026-10-30 12:49 ` Nicolas Dufresne
2026-10-30 18:05 ` Igor Velkov
2026-11-02 15:21 ` Nicolas Dufresne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aafdbbf04a0d939c6b4d7d5577d97bb58d1c439.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=detlev.casanova@collabora.com \
--cc=diederik@cknow-tech.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=hverkuil+cisco@kernel.org \
--cc=iav@iav.lv \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=pavone.lawyer@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®