From: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
To: Baoyou Xie <baoyou.xie@linaro.org>,
Subramanian Seetharaman <subbu.seetharaman@broadcom.com>,
Ketan Mukadam <ketan.mukadam@broadcom.com>,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, xie.baoyou@zte.com.cn, han.fei@zte.com.cn,
tang.qiang007@zte.com.cn
Subject: RE: [PATCH] scsi: be2iscsi: mark symbols static where possible
Date: Tue, 27 Sep 2016 09:49:10 +0530 [thread overview]
Message-ID: <8ab58b4a55f6cc0213156d536c6b15c9@mail.gmail.com> (raw)
In-Reply-To: <1474891259-20031-1-git-send-email-baoyou.xie@linaro.org>
> -----Original Message-----
> From: Baoyou Xie [mailto:baoyou.xie@linaro.org]
> Sent: Monday, September 26, 2016 5:31 PM
> To: subbu.seetharaman@broadcom.com; ketan.mukadam@broadcom.com;
> jitendra.bhivare@broadcom.com; jejb@linux.vnet.ibm.com;
> martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
arnd@arndb.de;
> baoyou.xie@linaro.org; xie.baoyou@zte.com.cn; han.fei@zte.com.cn;
> tang.qiang007@zte.com.cn
> Subject: [PATCH] scsi: be2iscsi: mark symbols static where possible
>
> We get 6 warnings when building kernel with W=1:
> drivers/scsi/be2iscsi/be_main.c:65:1: warning: no previous prototype for
> 'beiscsi_log_enable_disp' [-Wmissing-prototypes]
> drivers/scsi/be2iscsi/be_main.c:78:1: warning: no previous prototype for
> 'beiscsi_log_enable_change' [-Wmissing-prototypes]
> drivers/scsi/be2iscsi/be_main.c:97:1: warning: no previous prototype for
> 'beiscsi_log_enable_store' [-Wmissing-prototypes]
> drivers/scsi/be2iscsi/be_main.c:116:1: warning: no previous prototype
for
> 'beiscsi_log_enable_init' [-Wmissing-prototypes]
> drivers/scsi/be2iscsi/be_main.c:4587:5: warning: no previous prototype
for
> 'beiscsi_iotask_v2' [-Wmissing-prototypes]
> drivers/scsi/be2iscsi/be_main.c:4976:6: warning: no previous prototype
for
> 'beiscsi_hba_attrs_init' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
declared and
> don't need a declaration, but can be made static.
>
> So this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
[JB] Looks good.
Reviewed by: Jitendra Bhivare <Jitendra.bhivare@broadcom>
next prev parent reply other threads:[~2016-09-27 4:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 12:00 Baoyou Xie
2016-09-27 4:19 ` Jitendra Bhivare [this message]
2016-09-28 5:07 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ab58b4a55f6cc0213156d536c6b15c9@mail.gmail.com \
--to=jitendra.bhivare@broadcom.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=han.fei@zte.com.cn \
--cc=jejb@linux.vnet.ibm.com \
--cc=ketan.mukadam@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=subbu.seetharaman@broadcom.com \
--cc=tang.qiang007@zte.com.cn \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®