From: Sudeep Holla <sudeep.holla@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Andy Gross <andy.gross@linaro.org>
Subject: Re: [PATCH] drivers: cpuidle: assign enter_freeze to same as enter callback function
Date: Thu, 10 Nov 2016 10:34:31 +0000 [thread overview]
Message-ID: <8ab8322f-dcc8-d60e-3839-05ebedb6ffbc@arm.com> (raw)
In-Reply-To: <CAKfTPtDSwcEP6ViLjMBFs590mOsmafWqMRzkYZDJtJ=2tx0s6A@mail.gmail.com>
On 10/11/16 10:28, Vincent Guittot wrote:
> On 9 November 2016 at 19:48, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>>
>> On 09/11/16 18:39, Lorenzo Pieralisi wrote:
[..]
>>> I would just init the enter_freeze() pointer and be done with that,
>>> adding code to check whether the idle back-end enables IRQs when it
>>> enters idle is a major PITA that really is not worth the hassle and
>>> apart from coupled C-states (which we do not support in DT as you said)
>>> I can't find another example (and on top of that it is not even
>>> something we can solve through DT since it is not a property of the idle
>>> state but more related to its kernel implementation).
>>>
>>
>> Makes sense, I was just trying to avoid setting for a state like
>> CPU/Cluster retention but I agree, we need not do that.
>
> I agree with Lorenzo and would prefer to keep it simple
>
Sure I will respin accordingly.
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-11-10 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 17:43 Sudeep Holla
2016-11-09 18:39 ` Lorenzo Pieralisi
2016-11-09 18:48 ` Sudeep Holla
2016-11-10 10:28 ` Vincent Guittot
2016-11-10 10:34 ` Sudeep Holla [this message]
2016-11-10 14:24 ` [PATCH v2] " Sudeep Holla
2016-11-10 18:18 ` Andy Gross
2016-11-15 14:20 ` Sudeep Holla
2016-11-24 1:15 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ab8322f-dcc8-d60e-3839-05ebedb6ffbc@arm.com \
--to=sudeep.holla@arm.com \
--cc=andy.gross@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®