From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema
Date: Mon, 30 Mar 2026 11:46:45 +0200 [thread overview]
Message-ID: <8ac10933-0bf4-450b-a7b6-59731dfe4cd6@oss.qualcomm.com> (raw)
In-Reply-To: <r767islbwq2a3m6rf4wvl4hxzafdsw74jhev7jjz665kfymn56@vcn4p233n74f>
On 3/29/26 12:54 PM, Dmitry Baryshkov wrote:
> On Fri, Mar 27, 2026 at 11:40:51PM +0000, Bryan O'Donoghue wrote:
>> On 27/03/2026 23:23, Dmitry Baryshkov wrote:
>>> On Sat, Mar 28, 2026 at 01:12:22AM +0200, Vladimir Zapolskiy wrote:
>>>> On 3/28/26 00:29, Bryan O'Donoghue wrote:
>>>>> On 27/03/2026 20:51, Dmitry Baryshkov wrote:
>>>>>>> That's just not true. If you read the camx source code you can see
>>>>>>> split/combo mode 2+1 1+1 data/clock mode requires special programming of the
>>>>>>> PHY to support.
>>>>>> This needs to be identified from the data-lanes / clock-lanes topology.
>>>>>> And once you do that, there would be (probably) no difference in the
>>>>>> hardware definition.
>>>>>>
>>>>>>
>>>>>> In other words, I'd also ask to drop this mode from the DT. This
>>>>>> infromation can and should be deduced from other, already-defined
>>>>>> properties.
>>>>>
>>>>> It still needs to be communicated to the PHY from the controller,
>>>>> however that is not a problem I am trying to solve now.
>>>>>
>>>>> If I can't get consensus for PHY_QCOM_CSI2_MODE_SPLIT_DPHY then so be it.
>>>>>
>>>>> I'll aim for DPHY only and we can come back to this topic when someone
>>>>> actually tries to enable it.
>>>>>
>>>>
>>>> DPHY may be the only supported phy type in the driver, it does not matter
>>>> at this point, however it's totally essential to cover the called by you
>>>> 'split mode' right from the beginning in the renewed device tree binding
>>>> descriptions of CAMSS IPs to progress further.
>>>
>>> Okay. How would we describe that there are two sensors connected to the
>>> single PHY anyway? How would it be described with the current bindings?
>>>
>>> --
>>> With best wishes
>>> Dmitry
>>
>> Assuming you add endpoints to the PHY i.e. that is what Neil appears to be
>> asking for and I personally am _fine_ with that, then it should just be
>>
>> port@0
>> port@1
>>
>> if port@1 exists, you know you are in split-phy mode.
>>
>> Its actually straight forward enough, really. To be clear though I can write
>> that yaml - the _most_ support I'm willing to put into the PHY code is to
>> detect the port@1 and say "nope not supported yet", since like CPHY its not.
>
> SGTM. But let's define the schema for those usecases.
Let's perhaps also add a short example for both a single- and dual-sensor
cases in the YAML, even if there's no plans to support the latter
configuration now
Konrad
next prev parent reply other threads:[~2026-03-30 9:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 1:04 [PATCH v5 0/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver Bryan O'Donoghue
2026-03-26 1:04 ` [PATCH v5 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema Bryan O'Donoghue
2026-03-26 1:46 ` Vladimir Zapolskiy
2026-03-26 2:03 ` Bryan O'Donoghue
2026-03-26 10:28 ` Vladimir Zapolskiy
2026-03-26 14:42 ` Bryan O'Donoghue
2026-03-26 14:49 ` Vladimir Zapolskiy
2026-03-27 1:03 ` Bryan O'Donoghue
2026-03-27 7:54 ` Vladimir Zapolskiy
2026-03-27 20:51 ` Dmitry Baryshkov
2026-03-27 22:29 ` Bryan O'Donoghue
2026-03-27 23:12 ` Vladimir Zapolskiy
2026-03-27 23:23 ` Dmitry Baryshkov
2026-03-27 23:40 ` Bryan O'Donoghue
2026-03-29 10:54 ` Dmitry Baryshkov
2026-03-30 9:46 ` Konrad Dybcio [this message]
2026-03-28 0:41 ` Vladimir Zapolskiy
2026-03-26 2:31 ` Rob Herring (Arm)
2026-03-27 10:07 ` Konrad Dybcio
2026-03-27 10:10 ` Konrad Dybcio
2026-03-27 14:38 ` Bryan O'Donoghue
2026-03-27 15:28 ` Neil Armstrong
2026-03-27 17:42 ` Bryan O'Donoghue
2026-03-30 7:49 ` Neil Armstrong
2026-03-30 9:02 ` Bryan O'Donoghue
2026-03-30 9:17 ` Neil Armstrong
2026-03-30 9:25 ` Bryan O'Donoghue
2026-03-30 11:34 ` Konrad Dybcio
2026-03-30 11:41 ` Bryan O'Donoghue
2026-04-15 9:41 ` Konrad Dybcio
2026-03-30 11:49 ` Dmitry Baryshkov
2026-03-30 12:03 ` Bryan O'Donoghue
2026-03-30 10:39 ` Vladimir Zapolskiy
2026-03-26 1:04 ` [PATCH v5 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver Bryan O'Donoghue
2026-03-27 2:23 ` Hangxiang Ma
2026-03-27 10:07 ` Konrad Dybcio
2026-03-27 20:57 ` Dmitry Baryshkov
2026-03-27 20:54 ` Dmitry Baryshkov
2026-03-27 22:11 ` Bryan O'Donoghue
2026-03-27 22:30 ` Dmitry Baryshkov
2026-04-02 2:22 ` Vijay Kumar Tumati
2026-04-06 14:28 ` Abel Vesa
2026-04-06 15:37 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac10933-0bf4-450b-a7b6-59731dfe4cd6@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®