mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Juraj Pecigos <kernel@juraj.dev>, Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme-pci: mark Lexar NM760 as IGNORE_DEV_SUBNQN
Date: Sun, 26 Mar 2023 23:05:35 +0000	[thread overview]
Message-ID: <8ac7e3d7-c96a-26dc-17ef-3ce5d6bc03db@nvidia.com> (raw)
In-Reply-To: <20230326092948.147994-1-kernel@juraj.dev>

On 3/26/23 02:29, Juraj Pecigos wrote:
> A system with more than one of these SSDs will only have one usable.
> The kernel fails to detect more than one nvme device due to duplicate
> cntlids.
>
> before:
> [    9.395229] nvme 0000:01:00.0: platform quirk: setting simple suspend
> [    9.395262] nvme nvme0: pci function 0000:01:00.0
> [    9.395282] nvme 0000:03:00.0: platform quirk: setting simple suspend
> [    9.395305] nvme nvme1: pci function 0000:03:00.0
> [    9.409873] nvme nvme0: Duplicate cntlid 1 with nvme1, subsys nqn.2022-07.com.siliconmotion:nvm-subsystem-sn-                    , rejecting
> [    9.409982] nvme nvme0: Removing after probe failure status: -22
> [    9.427487] nvme nvme1: allocated 64 MiB host memory buffer.
> [    9.445088] nvme nvme1: 16/0/0 default/read/poll queues
> [    9.449898] nvme nvme1: Ignoring bogus Namespace Identifiers
>
> after:
> [    1.161890] nvme 0000:01:00.0: platform quirk: setting simple suspend
> [    1.162660] nvme nvme0: pci function 0000:01:00.0
> [    1.162684] nvme 0000:03:00.0: platform quirk: setting simple suspend
> [    1.162707] nvme nvme1: pci function 0000:03:00.0
> [    1.191354] nvme nvme0: allocated 64 MiB host memory buffer.
> [    1.193378] nvme nvme1: allocated 64 MiB host memory buffer.
> [    1.211044] nvme nvme1: 16/0/0 default/read/poll queues
> [    1.211080] nvme nvme0: 16/0/0 default/read/poll queues
> [    1.216145] nvme nvme0: Ignoring bogus Namespace Identifiers
> [    1.216261] nvme nvme1: Ignoring bogus Namespace Identifiers
>
> Adding the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk to resolves the issue.
>
> Signed-off-by: Juraj Pecigos <kernel@juraj.dev>
> ---
>

Just looking at the log in the commit message seems like
this is solving your problem, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck



      reply	other threads:[~2023-03-26 23:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-26  9:29 Juraj Pecigos
2023-03-26 23:05 ` Chaitanya Kulkarni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ac7e3d7-c96a-26dc-17ef-3ce5d6bc03db@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kernel@juraj.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®