From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD321657C4; Mon, 8 Apr 2024 11:32:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712575953; cv=none; b=qOgRC9JX60SXgW5qYE0kSShiBzRg/uBhauvveoduuriy61F8OC7KBtX5Kavk/+KUnr1gdgCFASi0txWHbtWNi/qf2H+4JUvsFeh/HjT6XNyRjlJBrpN5slLxzxWkZ1A/kDNivak/4Z586OHYLt1BCJUATECReMPUkJSVo2r3/Vg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712575953; c=relaxed/simple; bh=r4cliyGIwQDyX7Z9XcP+g//foiYQAn/zmPh0DKaJH7s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uG9b9YzxnIRQ+qsvOJ0BalPH96ZiUE8Ur1i8NmuQNNEQI9mSZlyBB81YIOap8DTVP4De6cXz1cxii/JsBEJqNABbtkLD/F5nOA3IqiDuukyndte/AgtVTaqg9qdMtJgSx/qB1h5YxQig41fYy6LJo+5hkmgXyqClYOgyI4yuPvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KkprdfwS; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KkprdfwS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712575952; x=1744111952; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=r4cliyGIwQDyX7Z9XcP+g//foiYQAn/zmPh0DKaJH7s=; b=KkprdfwSOFCBIjO5U180C2GaxW8SrAfzCwEdbltIzRkKSJX1L1boEuMc Iud+W7yp7a/EmgNj4OiJKknB/fr9Rw9AFiFCRdvz/bIWQfomk2NiMlcTC z1+HNK0rQ6CzVQnUezhT4Q+qF3rvEaco3LPtegqNndttAh5p3og+MAvX1 bEaqcWa9I4uI4fqRZT8eAnREeJp+8JEAiewJL3qGGHOUnB8tjCghV7FvP DPHTOBzTaQeAm+GdckQDk/bNnOK7K56bPVuYtEdL/dcqv6AVgT4QGrMf3 cCCpjZ0VVZclVBQdbQc777nyaXaA38gZWz3C71HkbGOCMnRV3uMXIsZHM Q==; X-CSE-ConnectionGUID: kPmrr3xJSLm33cLb+tr1RA== X-CSE-MsgGUID: Ri9pynbqQNuwLLeVo3ayzw== X-IronPort-AV: E=McAfee;i="6600,9927,11037"; a="7719787" X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="7719787" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 04:32:31 -0700 X-CSE-ConnectionGUID: YFNNf0xYSsqa5EBoqvlKtQ== X-CSE-MsgGUID: faB8glgyQ5WMfqxdzjvOfQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="20294427" Received: from naamamex-mobl.ger.corp.intel.com (HELO [10.12.48.215]) ([10.12.48.215]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 04:32:27 -0700 Message-ID: <8ac80d7b-340b-4b3f-b854-98a6a3c1fe41@linux.intel.com> Date: Mon, 8 Apr 2024 14:32:24 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH 3/3] igc: Remove redundant runtime resume for ethtool ops To: Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Sasha Neftin , netdev@vger.kernel.org, "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Bjorn Helgaas , intel-wired-lan@lists.osuosl.org, Zheng Yan , Konstantin Khlebnikov , Heiner Kallweit References: <20240325222951.1460656-1-helgaas@kernel.org> <20240325222951.1460656-4-helgaas@kernel.org> Content-Language: en-US From: "naamax.meir" In-Reply-To: <20240325222951.1460656-4-helgaas@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/26/2024 00:29, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > 8c5ad0dae93c ("igc: Add ethtool support") added ethtool_ops.begin() and > .complete(), which used pm_runtime_get_sync() to resume suspended devices > before any ethtool_ops callback and allow suspend after it completed. > > Subsequently, f32a21376573 ("ethtool: runtime-resume netdev parent before > ethtool ioctl ops") added pm_runtime_get_sync() in the dev_ethtool() path, > so the device is resumed before any ethtool_ops callback even if the driver > didn't supply a .begin() callback. > > Remove the .begin() and .complete() callbacks, which are now redundant > because dev_ethtool() already resumes the device. > > Signed-off-by: Bjorn Helgaas > --- > drivers/net/ethernet/intel/igc/igc_ethtool.c | 17 ----------------- > 1 file changed, 17 deletions(-) Tested-by: Naama Meir