From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbcJCIqZ (ORCPT ); Mon, 3 Oct 2016 04:46:25 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34884 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752187AbcJCIqS (ORCPT ); Mon, 3 Oct 2016 04:46:18 -0400 Subject: Re: [PATCH] drm/mediatek: fix a typo To: Bibby Hsieh References: <1475119322-58657-1-git-send-email-bibby.hsieh@mediatek.com> <1475121682.18843.2.camel@mtksdaap41> <1f324471-bebb-c8bf-75c1-391355c50a99@gmail.com> <1475205119.13345.6.camel@mtksdaap41> Cc: CK Hu , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Yingjoe Chen , Cawa Cheng , Daniel Kurtz , Philipp Zabel , YT Shen , Thierry Reding , Mao Huang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sascha Hauer From: Matthias Brugger Message-ID: <8ac926cb-e585-0a4c-97cc-8948d17b4bba@gmail.com> Date: Mon, 3 Oct 2016 10:46:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475205119.13345.6.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/09/16 05:11, Bibby Hsieh wrote: > On Thu, 2016-09-29 at 10:46 +0200, Matthias Brugger wrote: >> >> On 29/09/16 06:01, CK Hu wrote: >>> Acked-by: CK Hu >>> >>> On Thu, 2016-09-29 at 11:22 +0800, Bibby Hsieh wrote: >>>> Fix the typo: OD_RELAYMODE->OD_CFG >>>> >> > > Hi, Matthias > Thanks for your reply. > >> Although it is quite clear what the patch does, could you write one >> sentence to explain what it does. Maybe explain even which effect it >> has, which error get fixed etc. > > Ok, I will do that. > >> As we are getting public available boards now, we should take more care >> about fixes. If you have a fix for a commit introduced in an earlier >> version of linux and it should be fixed for this version as well (e.g. >> v4.6 does have the feature but it does not work correctly) then please >> add these two lines before your Signed-off-by: >> Fixes: ("") >> Cc: stable@vger.kernel.org # v4.6+ >> >> Where v4.6+ stands for the oldest version where this should get fixed. >> > > Ok, but the patch hasn't been merged into v4.8 (just in drm-next [1] and > linux-next [2]), how can I mark that? > If the commit get's into v4.9 then make sure that this patch get's merged into the fixes for v4.9 by the corresponding maintainer. Regards, Matthias > [1] > https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next&id=7216436420414144646f5d8343d061355fd23483 > [2] > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=7216436420414144646f5d8343d061355fd23483 > > >> Thanks a lot, >> Matthias >> >>>> Signed-off-by: Bibby Hsieh >>>> --- >>>> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >>>> index df33b3c..aa5f20f 100644 >>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >>>> @@ -123,7 +123,7 @@ static void mtk_od_config(struct mtk_ddp_comp *comp, unsigned int w, >>>> unsigned int bpc) >>>> { >>>> writel(w << 16 | h, comp->regs + DISP_OD_SIZE); >>>> - writel(OD_RELAYMODE, comp->regs + OD_RELAYMODE); >>>> + writel(OD_RELAYMODE, comp->regs + OD_CFG); >>>> mtk_dither_set(comp, bpc, DISP_OD_CFG); >>>> } >>>> >>> >>> >