From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B01329DB9A; Fri, 6 Mar 2026 12:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772799245; cv=none; b=p455hhYQQk8aWEYjMzBRNPyo9hek/52SD0HneuQ8uwnSndaSlEo3LZ3Jvm9377BD9dPbd2Gfo5mVGWOLQh6YvK5BC5rWsjUdrT6vrD7dkxHZPjNkMVc4zhe/h4ntXh+9hqJlWsYKFoBP1RBSowpRvCpP00BDqKwJrWAejgsxYS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772799245; c=relaxed/simple; bh=Aeql3Q18nbzOXyXxhu0vMzA3N0kdNt6Kxm9MrBYhJwc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dOJpIKTjfdHJ17A2jarQ6hRDBTfqidYs5uWLNM4vjFHrFOuJe3h1YqzpkrHfGb9QwopTWnnAdqkzTd99XxgNrZyU9l6XMjLqjSExJpFoZCb3Yvj6q8RR9yNDgaKb16MUxMczk4tT2YXtZOu8q+2SSgLUwuCtrnjrhCJ3GoSb50E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dVqQGJSF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dVqQGJSF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 829DEC4CEF7; Fri, 6 Mar 2026 12:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772799245; bh=Aeql3Q18nbzOXyXxhu0vMzA3N0kdNt6Kxm9MrBYhJwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dVqQGJSFiWX+fDD/OWZvs6Gl8EvNWdkhGAwY0jgLtpsGAh+dBK4hjzKSY1SnoVxJU Xn8o0QmPk7618RpV/ZP3BQon0ikZoZX/2Edj80XY9nHA/af8dILFPWfW54wd0CfK5J NNDPt/dl+gpaSa6q1arnlJ6LaGOiSvQqHc8RpLx+kRVj9NJ49/AzP4n1GT/dB3EozG MzrBFPGFBVBNv32TOIbQwG4bTmYYGJvCCLdYq7arv1NHHiBCMmGv2K2Sm+N0LRxzpC aFvJFL0+ixqlChqXpUk4/1NsRYhl/5ShnknPXYh+3W2ihDb5KHKe+eLdNWM7yGCDkz //0PKp6ZWU7fQ== Date: Fri, 6 Mar 2026 12:14:02 +0000 From: "Lorenzo Stoakes (Oracle)" To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Alice Ryhl , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v1 05/16] mm/oom_kill: use MMU_NOTIFY_CLEAR in __oom_reap_task_mm() Message-ID: <8ad03e9e-b14a-4348-aea3-fefd5d2b163d@lucifer.local> References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-6-david@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260227200848.114019-6-david@kernel.org> On Fri, Feb 27, 2026 at 09:08:36PM +0100, David Hildenbrand (Arm) wrote: > In commit 7269f999934b ("mm/mmu_notifier: use correct mmu_notifier events > for each invalidation") we converted all MMU_NOTIFY_UNMAP to > MMU_NOTIFY_CLEAR, except the ones that actually perform munmap() or > mremap() as documented. > > __oom_reap_task_mm() behaves much more like MADV_DONTNEED. So use > MMU_NOTIFY_CLEAR as well. > > This is a preparation for further changes. > > Signed-off-by: David Hildenbrand (Arm) LGTM, so: Reviewed-by: Lorenzo Stoakes (Oracle) > --- > mm/oom_kill.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 5c6c95c169ee..0ba56fcd10d5 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -551,7 +551,7 @@ static bool __oom_reap_task_mm(struct mm_struct *mm) > struct mmu_notifier_range range; > struct mmu_gather tlb; > > - mmu_notifier_range_init(&range, MMU_NOTIFY_UNMAP, 0, > + mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, > mm, vma->vm_start, > vma->vm_end); > tlb_gather_mmu(&tlb, mm); > -- > 2.43.0 >