From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752679AbdAYWmB (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Jan 2017 17:42:01 -0500
Received: from terminus.zytor.com ([65.50.211.136]:46258 "EHLO mail.zytor.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752659AbdAYWl7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Jan 2017 17:41:59 -0500
Subject: Re: [PATCH] x86/crypto: fix %progbits -> @progbits
To: Denys Vlasenko <dvlasenk@redhat.com>,
        Herbert Xu <herbert@gondor.apana.org.au>
References: <20170119212805.18049-1-dvlasenk@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
        Xiaodong Liu <xiaodong.liu@intel.com>, Megha Dey <megha.dey@intel.com>,
        George Spelvin <linux@horizon.com>, linux-crypto@vger.kernel.org,
        x86@kernel.org, linux-kernel@vger.kernel.org
From: "H. Peter Anvin" <hpa@zytor.com>
Message-ID: <8ad0ec8d-a7d2-b4ca-df7d-3b670b468baf@zytor.com>
Date: Wed, 25 Jan 2017 14:37:08 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <20170119212805.18049-1-dvlasenk@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/19/17 13:28, Denys Vlasenko wrote:
> %progbits form is used on ARM (where @ is a comment char).
> 
> x86 consistently uses @progbits everywhere else.

However, it looks like %progbits works on all architectures (at least
include/linux/init.h seems to imply so.)  Perhaps a tree-wide
replacement the other way would make more sense.

Personally I would also like to see these parameters macroized, to keep
someone from getting them wrong, just like we have __INIT, __INITRODATA
etc already, we should just have plain __TEXT __DATA __BSS...

	-hpa