From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FA39395AC7 for ; Thu, 30 Jul 2026 08:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785399117; cv=none; b=FUiQRYLtsfAu+2h8sy1sN5ch+dpmxm4NN7LvyBmS9CnVENMcyehTP+VisE6wp2obGnK9yv6m0ZFOzseCiY6mWb8YtP/X7LIroOhL9AeZ3nnn4Pi/j8kVPP8C0rUY2UbN7ASitX12QEm9fII57khtXF8nK2gLUaFaIsiwdKReaOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785399117; c=relaxed/simple; bh=4QPs/GUSJjXu3SMPCjbKcTjBPS5rwxyVwdUg4pQ30iY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k2bD2HqlRcBL1ghbk7gN8THTuFdnDvPPAWFTVl3QqFrLhaRzGtQ27X5h/So2m+VQG+UwDL7px57ceUnp/+ZUvWJX7Jhpg46BdDkj/odHUr+mU6ADyQwdawu5/Klip+icIcMHj3JmrSqEuC717+VWOJviEh494P/xJZKTP2dLeF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZPL/Ov1P; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KFW8n0Na; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZPL/Ov1P"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KFW8n0Na" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66U81hmT3921469 for ; Thu, 30 Jul 2026 08:11:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= u9UFoU4lYuyMXLSPiV/x+DNCpef+k8Qmi5vfYkwQM9o=; b=ZPL/Ov1PXckxn8rI NpElNpwLo67PAs0zeonbcKC0BDgiL/ZZiXMHP0TXWGlqOVfV7QMGGO95iSKcrdQ5 ZKL1nVoevIKFgkVJD7WNWSlbvivpu+fSx4OUy15+8YIbD6Zee14vPbn5J7k7dGe8 mj5Pw8aeJyZqjGxKItzQ1YFc81Nbamijpz8VFs9j0X0oCV5EO14Y3rthrkc6dzL3 n9eqJlUbIoVtGTg4m9f4qZGqt0t6/SKtHSSdfLDvj4CZvXhWzhSufSr4d0jVIuFj 5JGtNFoZKlY2MP9VLP8ui9OACbBP4kTW1VxDHCOumgdq0vILe4yO+RJpamY889Sn hlpzrA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr2r8r19f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 08:11:52 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c0e702df8so19446211cf.2 for ; Thu, 30 Jul 2026 01:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785399112; x=1786003912; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=u9UFoU4lYuyMXLSPiV/x+DNCpef+k8Qmi5vfYkwQM9o=; b=KFW8n0NanEwlDaZh+rDG5V3cQvbHNq4DqoUQD/u36xu5+i4qMwZ22VZ5BOzVS2Oqu+ gs4eB4YYNKlgknGpVD2NcwXWqN0w4EDKSoetbpa+yt8S5RfmqXMq4vdEx6re3G9sqk16 WFCX8q0BwFG6b6kB1TtNXOCzpKTr0668XlpJBRmfCii7lrIlu22/dw12TfUekSkMiWFj 5L38WptPBS2pVp1GYEhEPA3O1LZIX+Gss6ZKKO7fGCaF/yT0oTaMM6TvPlorFXMKeDq9 GG+q0gGUr+Es1mFa6Cm73fGCI1RChAnunipsUKmsJliRnxDzIKpEHJVRCDbhQbl/vu5G Cemg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785399112; x=1786003912; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=u9UFoU4lYuyMXLSPiV/x+DNCpef+k8Qmi5vfYkwQM9o=; b=A5l6qFhQmHja8cBiQ1zEc+0e7Y4IUFtCGDZOwmE8JsQ1QOhNFNQnYoYPhXnOLIgKgo LKcfpjs/3qb/eNgIiK/yvFbB8REhUgFLzoXMK2h6OJfwpYz44a4Jgw9k9DfDhv/mywN4 eYKHgwKjdl/GVDXQIwNiFewPqt3F22CXdun9IgSQdfidMcJ0WIe4VpPvIDFUzKZHnW5U eb8MqiluEHE2XR7Y7EvOCFbICUisA0pfLjAQj0CvpbvKUG/qm5UKHud1kHjn6EoDBtPz D6LnzTCfc5iq9o7MPOrhRH5rU/KdU6rsT3EQZk9pAgO+RiNYzIxtjyVxrEHfEwKfblnm XxSw== X-Forwarded-Encrypted: i=1; AHgh+RpVJ9Sq16yIzxW5RmqcCZ3G4tzetosZzU0/9nnJ/3Qp4P7ppHu43oA6E0W74eKSHC2oeTuXk1Pz8NR5jAs=@vger.kernel.org X-Gm-Message-State: AOJu0YxQT1YkPf8lJeG6e1KQTbW/TtelWmItsbURWFyLH/UYnJmf7QZk PRdf7FM7q+mv1sh+oEuAfSIA3qsqtGnnFvXT5WRwSbPQw6CH8eesHw//ByCKT/D208NzZexkRf6 xcAdhT9GCGTc9eZV+AGBpnx4ckvtNLD6X4RWCiiNBNcl3L7C2CBZ2d4pfmud9KDd+S5M= X-Gm-Gg: AR+sD12yGi38QSi7pcSVf9nhQrYO/MfMsV8a0/KSkIp5PM+sXWV5Y845jTaEq+SEnnI MxI0ATu5wiYfgNq0TN/hW1Vs2Ts4BzIW55TLqSZsxPsyDTj2WWKlltKR5r3K/0RSE3e9C30PPjF wh8WImBpYXdLbXvU50vdSzqvNnYdHdj2sQcjjvP4Ai9qhRmtIN5OrudSVAIh/MZrP6f/GNLSIOO iXC5IaNWclimStXHmwZVjn48jKIdkIY2+T0uE4C5uthxVhFo/XbiW5aspQlSIg09DaYg3PP4NcF Gq0QwNO5s0ViYuwPTJH0aSie+Gq7+GgtlYll9UxWM80tcwcCTPeV4KwK7KsCeAbh7zgJXEY1+Nr EgmdNnJSt1YGQVBXf2jEulfIO3kueJCtF0s0+DK/qluvBPSY9XYw= X-Received: by 2002:a05:622a:5910:b0:51c:1967:5091 with SMTP id d75a77b69052e-52b3866dd5emr18473421cf.41.1785399111539; Thu, 30 Jul 2026 01:11:51 -0700 (PDT) X-Received: by 2002:a05:622a:5910:b0:51c:1967:5091 with SMTP id d75a77b69052e-52b3866dd5emr18473131cf.41.1785399110956; Thu, 30 Jul 2026 01:11:50 -0700 (PDT) Received: from [192.168.69.212] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4980120b42csm39840115e9.10.2026.07.30.01.11.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 01:11:50 -0700 (PDT) Message-ID: <8ad47516-2747-45d1-ae25-e9ce068b7f3c@oss.qualcomm.com> Date: Thu, 30 Jul 2026 10:11:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v2 1/2] bpf, mips: Factor out div/mod emission helpers Content-Language: en-US To: Nicholas Dudar Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, tsbogend@alpha.franken.de, johan.almbladh@anyfinetworks.com, paulburton@kernel.org, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com, ihor.solodrai@linux.dev, visitorckw@gmail.com, bpf@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, martin.lau@kernel.org, clm@meta.com References: <20260729162931.2369353-2-main.kalliope@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: KvYRdrAeA6qvKnNUsExOkYIGAepV5-MH X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDA1OCBTYWx0ZWRfX4N0h+vUWeGpN 4i9vxL3TX97dMofx5uk4+RKAzG2GRablrEKiDR5vJyOo41kQFyma5PMP83HNScyRYdX9dP5fNuh /m7Gyq5fKUiAG4ZU/G+9M0q9bv4JTIs= X-Authority-Analysis: v=2.4 cv=VfXH+lp9 c=1 sm=1 tr=0 ts=6a6b0748 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=1tSEMpTH9XP_W59IOagA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: KvYRdrAeA6qvKnNUsExOkYIGAepV5-MH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDA1OCBTYWx0ZWRfX0F32PK0PEeVF +oeeJHit8bKjCLzqAjkM49beF+C2NEKar7GGeD+optx7uCW+RTy6KG3x5dGvrHkMWM0n39raMI7 u1uhxw6B6pFIcVv3QLJC8c8POTSCX3n3OAdZZXpgW4C+93x7UFEqlco5VijhH52/sE/X38+d1fd D3+3R0zsuyKy9OfOw+5XTec4S6G1HRKDDsdXYLNbi6abF0RcOB6ag7tWiWVdcqsYtebNFfHKpFy nSJi6l8b4Ofby0bLMfhl5sAx6m7aVU6ZnTjlIDWC6t79Gd5W0FolmxJ26FbwcnkLpYGZH4Pm2T5 xPaTFr1ySyjCzXWgMOSBxXIhdVzvkV7AgyMqPw4Swuu1raN67joVZYeoUtjER2dlrlUmXyT0GxL mPw3Gy+WY1jKX+T7S7eJUPFmRGu4/ZBWz1ts1zGVmqHPugAwMHH1IwCZwB2xkFqOIwD0bXzloRF VEEaGz9JsWKMg5+YUmQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_02,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 priorityscore=1501 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300058 On 29/7/26 20:54, Nicholas Dudar wrote: >> This isn't a bug, but would a short header comment on emit_div() and >> emit_mod(), in the style of the neighbouring '/* ALU register operation >> (32-bit) */', keep these consistent with the rest of the file? Every >> other emitter here carries one. >> >> Same for emit_div64() and emit_mod64() here. > > Agreed that short comments would match the surrounding emitter style. > I'll add them if the series needs another revision. Thanks for the v2. Reviewed-by: Philippe Mathieu-Daudé