From: <Mario.Limonciello@dell.com>
To: <greg@kroah.com>
Cc: <dvhart@infradead.org>, <andy.shevchenko@gmail.com>,
<linux-kernel@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <luto@kernel.org>,
<quasisec@google.com>, <pali.rohar@gmail.com>,
<rjw@rjwysocki.net>, <mjg59@google.com>, <hch@lst.de>
Subject: RE: [PATCH v5 08/14] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens
Date: Sat, 7 Oct 2017 11:56:04 +0000 [thread overview]
Message-ID: <8ad76b287f8a4f9aa13e7c809cc7b998@ausx13mpc120.AMER.DELL.COM> (raw)
In-Reply-To: <20171007065421.GA20756@kroah.com>
> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com]
> Sent: Saturday, October 7, 2017 1:54 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: dvhart@infradead.org; Andy Shevchenko <andy.shevchenko@gmail.com>;
> LKML <linux-kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org;
> Andy Lutomirski <luto@kernel.org>; quasisec@google.com;
> pali.rohar@gmail.com; rjw@rjwysocki.net; mjg59@google.com; hch@lst.de
> Subject: Re: [PATCH v5 08/14] platform/x86: dell-smbios: Add a sysfs interface for
> SMBIOS tokens
>
> On Fri, Oct 06, 2017 at 11:59:52PM -0500, Mario Limonciello wrote:
> > Currently userspace tools can access system tokens via the dcdbas
> > kernel module and a SMI call that will cause the platform to execute
> > SMM code.
> >
> > With a goal in mind of deprecating the dcdbas kernel module a different
> > method for accessing these tokens from userspace needs to be created.
> >
> > This is intentionally marked to only be readable as root as it can
> > contain sensitive information about the platform's configuration.
> >
> > MAINTAINERS was missing for this driver. Add myself and Pali to
> > maintainers list for it.
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > ---
> > .../ABI/testing/sysfs-platform-dell-smbios | 16 ++++++
> > MAINTAINERS | 7 +++
> > drivers/platform/x86/dell-smbios.c | 64 ++++++++++++++++++++++
> > 3 files changed, 87 insertions(+)
> > create mode 100644 Documentation/ABI/testing/sysfs-platform-dell-smbios
> >
> > diff --git a/Documentation/ABI/testing/sysfs-platform-dell-smbios
> b/Documentation/ABI/testing/sysfs-platform-dell-smbios
> > new file mode 100644
> > index 000000000000..d97f4bd5bd91
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-platform-dell-smbios
> > @@ -0,0 +1,16 @@
> > +What: /sys/devices/platform/<platform>/tokens
> > +Date: November 2017
> > +KernelVersion: 4.15
> > +Contact: "Mario Limonciello" <mario.limonciello@dell.com>
> > +Description:
> > + A read-only description of Dell platform tokens
> > + available on the machine.
> > +
> > + The tokens will be displayed in the following
> > + machine readable format with each token on a
> > + new line:
> > +
> > + ID Location value
> > +
> > + For example token:
> > + 5 5 3
>
> That's more than "one value per file" which is what sysfs requires, so
> this isn't acceptable, sorry.
What's more acceptable to you to relay this information?
Binary sysfs attribute and export the structure format in a uapi?
or a collection of sysfs files?
Eg:
tokens/$x/id
tokens/$x/location
tokens/$s/value
I'm guessing the latter is the better way to go.
>
> > +static ssize_t tokens_show(struct device *dev,
> > + struct device_attribute *attr, char *buf)
> > +{
> > + size_t off = 0;
> > + int to_print;
> > + int i;
> > +
> > + to_print = min(da_num_tokens, (int)(PAGE_SIZE - 1) / 15);
> > + for (i = 0; i < to_print; i++) {
> > + off += scnprintf(buf+off, PAGE_SIZE-off, "%04x\t%04x\t%04x\n",
> > + da_tokens[i].tokenID, da_tokens[i].location,
> > + da_tokens[i].value);
>
> Huge hint, if you are checking for the max size of the buffer for sysfs,
> something is really wrong, and you need to redo your design.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2017-10-07 11:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 4:59 [PATCH v5 00/14] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-10-07 4:59 ` [PATCH v5 01/14] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello
2017-10-07 4:59 ` [PATCH v5 02/14] platform/x86: dell-wmi: increase severity of some failures Mario Limonciello
2017-10-07 4:59 ` [PATCH v5 03/14] platform/x86: dell-wmi: clean up wmi descriptor check Mario Limonciello
2017-10-07 4:59 ` [PATCH v5 04/14] platform/x86: dell-wmi: allow 32k return size in the descriptor Mario Limonciello
2017-10-07 4:59 ` [PATCH v5 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Mario Limonciello
2017-10-07 4:59 ` [PATCH v5 06/14] platform/x86: wmi: Don't allow drivers to get each other's GUIDs Mario Limonciello
2017-10-07 4:59 ` [PATCH v5 07/14] platform/x86: dell-smbios: only run if proper oem string is detected Mario Limonciello
2017-10-07 4:59 ` [PATCH v5 08/14] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello
2017-10-07 6:54 ` Greg KH
2017-10-07 11:56 ` Mario.Limonciello [this message]
2017-10-07 12:39 ` Greg KH
2017-10-07 4:59 ` [PATCH v5 09/14] platform/x86: dell-smbios: Introduce dispatcher for SMM calls Mario Limonciello
2017-10-08 15:48 ` Andy Shevchenko
2017-10-08 18:13 ` Andy Shevchenko
2017-10-08 21:45 ` Mario.Limonciello
2017-10-08 23:10 ` Andy Shevchenko
2017-10-07 4:59 ` [PATCH v5 10/14] platform/x86: dell-smbios: add filtering capability for requests Mario Limonciello
2017-10-07 7:43 ` Greg KH
2017-10-07 4:59 ` [PATCH v5 11/14] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver Mario Limonciello
2017-10-07 4:59 ` [PATCH v5 12/14] platform/x86: dell-smbios-smm: test for WSMT Mario Limonciello
2017-10-07 4:59 ` [PATCH v5 13/14] platform/x86: wmi: create character devices when requested by drivers Mario Limonciello
2017-10-07 7:34 ` Greg KH
2017-10-07 11:59 ` Mario.Limonciello
2017-10-07 12:38 ` Greg KH
2017-10-07 4:59 ` [PATCH v5 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface Mario Limonciello
2017-10-07 7:41 ` Greg KH
2017-10-07 7:43 ` Greg KH
2017-10-07 12:15 ` Mario.Limonciello
2017-10-07 12:36 ` Greg KH
2017-10-07 13:13 ` Mario.Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ad76b287f8a4f9aa13e7c809cc7b998@ausx13mpc120.AMER.DELL.COM \
--to=mario.limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=greg@kroah.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjg59@google.com \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quasisec@google.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®