Re: [PATCH v2] PM: runtime: Update runtime_pm.rst for non-fatal resume errors

[Bart Van Assche <bvanassche@acm.org>]

On 11/4/26 7:16 AM, Stanley Jhu wrote:
 > +  * If the resume callback returns an error code, the PM core sets the
 > +    device's runtime PM status back to 'suspended' and returns the error
 > +    code from synchronous resume helpers.  Unlike with the suspend
 > +    callback, failures in the resume callback are never considered 
fatal,
 > +    so the helper functions described in `Section 4`_ are not 
blocked and
 > +    a subsequent resume request can run the resume callback again.

Hi Stanley,

This matches what rpm_resume() does since commit eef1d74bf88f. A nit:
suspend callback failures with -EBUSY / -EAGAIN are not fatal either,
so "Unlike most suspend callback errors" may be slightly more accurate.
Either way:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Additionally, the kerneldoc of @runtime_error in include/linux/pm.h
("Fatal error code returned by a failing callback") could be updated
in a follow-up patch to mention ->runtime_suspend() explicitly.

Thanks,

Bart.