From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A508C392818 for ; Tue, 17 Mar 2026 22:20:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773786006; cv=none; b=UeVCgpi4rMVotYQmZ/cZwipM0d/RSkFIrYOr75GIv8DQXx6OQJ0YDSiKt80YySmVxzdtM4YbaohfkJOMFlsO89Drse/jfLaQ+lpwii2FNStn2M5okrXhQGJk1NaLarOXh35koWlrFsB3lwKV25NunhKnq9IAWVBPBkXOR0TR0Ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773786006; c=relaxed/simple; bh=y/EmYIg0gRmVkSyOE3fKWNsZUImGNsUyuRa0ygA4/YM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cAd1R+kuP3OHPh0MjRVmPDXPBznT5sdsbg4YcnVVpT0yWYUAoESWhHYxChQDXOQh9NSsrvLfUPhsAkzeordmLCzEa7Qcs7jvTIcxOkkrxPCEiqpNIE0adzOMq+ZK9h5kSCE8GLhtVfHzc+HEAFA9Wnvbx5M2ayqXrIlsDFYxNQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W0YgK7gH; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W0YgK7gH" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-1271257ae53so8752866c88.1 for ; Tue, 17 Mar 2026 15:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773786005; x=1774390805; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=/yPZOqi1ryUibCEpvsqKM4HgGM7evfo9zGBJ9SdBBPQ=; b=W0YgK7gHc/sgaz4Yujm3o8Qs3rDhg6AVp+xfKH/+UQB8pJ3oUxrYBgAgLPXoAQDC4V vsebvbJTRoGOMXztaJeMjYdooCeoQHTEDkY3ugSHgvOHeQbqQDRFh7MLb6vlIpZHPc2Z YBeDCnGb0dHt3yevD4VqOhE8cWiQ9d1qNgo8GRhKDbGvzhKRLfIy5dChhqtZIaVL6bOF QEHfKD+sG0clVFqvGwC3Aq6Mpt2a2apsZsYi3JlBgbXXrO+SYE1M09UmQR5nlpE80ria QucN9fBBj8vmcvTcOiiuaAtvFVlDICjmMfMIYTUfrJsfir3+PrhMpSmhXgasdrIuySLX o4Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773786005; x=1774390805; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/yPZOqi1ryUibCEpvsqKM4HgGM7evfo9zGBJ9SdBBPQ=; b=fAz80JLiL5R+nae7jrTRRtLCIxEDI+9fuHoaJaT7CtWAK1I2raFXAH++Idlr0pEJWH WGiWXcupc7PhAMO9UOv/z5oS1aB0WrrzTDPOVDipj17CRoVXWQ3MhOBELWzrDSoeYUUp IhTOfKSYloP3nPm8D4KLGJa0rGkKio4NLNHr7ASL3d8kKSdDt2UAaju6WhOssP58vX62 1cuHCTFlXuTgKnOQ7zV8Gc3BlTgwfpG+hvjFOp9BkoJSEljoPr6ENKtM0PwEMQFwfcn+ BTru1pDalTAdleLdbtet2Od6jzpirl2lcIu3r+UZB3ghAZd6Iy8f+DtQ5BuLdCgQCj90 ICIA== X-Forwarded-Encrypted: i=1; AJvYcCVKChWisXQkp2zmyYITvlGBV9GbEE6yQeSKlaOwmYCT52lbTgrdljCPQIUHOuHy2N0f87zpatfoCQUN4pU=@vger.kernel.org X-Gm-Message-State: AOJu0YxjJDBmk/Kql7VDqH9EDWhF/0FYZOrGJ9MjyTe4nfvCOmZw7rM9 1PuGQScK9HYZ4IDPR32EZ0pMQPclbtJ8xz9UeQy0i4JQi1SZlawLh9kw X-Gm-Gg: ATEYQzwDJZfZutaOG8H1GDSnS1EDDylI/lN1Ch4i8flprNrVYAZxIRYIaBBZ46wOo1b wHTnEGxNvnhxy3LVHEum6ysn+olE4/ShDXOl6hPsLEvPUgzNb9z0r7wDVbt4eTWu0DtVWz/vwGt cUezpO9mLMfbveoCZ5hrcLEY5UovxNuizx0KEoiyKhok/RT9vyDAkjeA2wUja5OwgGNC9a8PPex 5PeFTicBB3eXI+J+hh2/KsS+qLHLvY0LwyPGOpF7YaU9iW+/qKeYJbMfA4O1OnhNsA/qkBQuuNt sP7ROyVbvP5cD4o0ZGBap0loOLbt6urzTD9VKuaSQczZMcvNm90U5Fs7N2rf9M+ebswmKaT8NjY /RqJRxv/qk8APbnBWNbld0//alV8iFwb/fVGhSzPNC0x7S+YBJsASSPiO2XOsZesV0LPAGS6UBP TNth+G5pVCLMNLqn1Bqo85pft938f8qCJSRT3ZtlJcKSMhmkQ= X-Received: by 2002:a05:7022:90e:b0:128:ca90:32e2 with SMTP id a92af1059eb24-1299ba8b9a6mr586674c88.7.1773786004776; Tue, 17 Mar 2026 15:20:04 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e5583533sm1291913eec.18.2026.03.17.15.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 15:20:04 -0700 (PDT) Sender: Guenter Roeck Date: Tue, 17 Mar 2026 15:20:03 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "vasileios.amoiridis@cern.ch" , "leo.yang.sy0@gmail.com" , "wensheng@yeah.net" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: Re: [PATCH 1/5] hwmon: (pmbus/hac300s) Add error check for pmbus_read_word_data() return value Message-ID: <8aec79cb-3884-4aa2-870f-6e136f6fb373@roeck-us.net> References: <20260317173308.382545-1-sanman.pradhan@hpe.com> <20260317173308.382545-2-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317173308.382545-2-sanman.pradhan@hpe.com> On Tue, Mar 17, 2026 at 05:36:53PM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > hac300s_read_word_data() passes the return value of pmbus_read_word_data() > directly to FIELD_GET() without checking for errors. If the I2C transaction > fails, a negative error code is sign-extended and passed to FIELD_GET(), > which silently produces garbage data instead of propagating the error. > > Add the missing error check before using the return value in > the FIELD_GET() macro. > > Fixes: 669cf162f7a1 ("hwmon: Add support for HiTRON HAC300S PSU") > Cc: stable@vger.kernel.org > Signed-off-by: Sanman Pradhan Applied. Thanks, Guenter