From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.69 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795108091; b=4s5hH4mXn3yVtJDItEBxAjYVokDREt7ncDLJWQfcUnpN7v1rn51roNZohZf0gA9YEGvW bs1snCBe0VLJxpXpFiXdv1vcTppl1nJNEvOsbR+Zs75TzWi+9uzROy05Q0BQz6KGwbQ9g 4MjvbDY2OWdzPZH/00urmgb0v28QN8ocnO93rdfB9FJ8hHkNUTjDKJ4Cuh3ZmJvIqblTv zDkZ1BUh4xM+Vxio+51DFa/PYWfh2UDMLeInpIH+7hPsYauZrD+w7AK6IK24Megn0MPCB IxL7dzYQK6yENCSmXR6AH76Zh5zWTPOqL8OsG0rVgCseW6wahCTiLanhLx9pM+g2Sow== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795108091; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=nb8Ts+L+z/DpTGbH2tq/3CpL8ayCSrXAUIaUzn6KeKM=; b=OgnHDCh4a2zKoNgU5Hd7Q/k5cFxvEVfw5djr+X4y2OAPnIyk1Oo9wIbb7pjsnRBkfdWB hH16YhcYhMSFxvVQZCmjnkWy27xO6Y9i3xYl6H5LkTyHu1s1FT1V2nO0fsLTsNGPlCZmb GmWNSCcAwHxVHcZxYBv09EuAEB3reuqeF5JKlk7+qqUz2CZdWcMt+YqU9VEE3JR2hpUTt YlYsBy7zh/piI13fc2yZNpj9m8nGCGPCX0p8bonz23HiYuAqBi/56HKJidtJYXNu7HDvp XSsGoEiSEZhePtD/klYCc3VMnx90+Q0JGfLcJxvrWIP9idIUzNfV6S5sjVz6o5H4BrQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=mt+Uvlc0; arc=none smtp.remote-ip=209.85.216.69 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B6D1606A330 for ; Thu, 19 Nov 2026 17:08:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5B6D1606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=mt+Uvlc0 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3b3a74ee77fso26316a91.0 for ; Thu, 19 Nov 2026 09:08:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795108091; x=1795712891; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nb8Ts+L+z/DpTGbH2tq/3CpL8ayCSrXAUIaUzn6KeKM=; b=mt+Uvlc0ci9UzOY5SdxKwQpbYeDDmxdZYa1g4FdQttSKyQ0M65AP7d7L/7rv539F4M 9ElHbrhLUKguXzt6hN5sIeq749PR2K6fIU/P4v96oJWoXt7ts+z41Fzm5zU9lhVicqEf uqZsXo2xAQoVRVrc355YgLTCid7O4YY1JtTrlOSdbfYPkNzcjWYv5l/QHA2PtZqnOP87 9iGjjyW2v8O/ZRGfGJPSWfsZuihQF6WXxbskpBusqgRvU9iTwrkPI6mAyBLv3BZTwvD1 ZzG8bfjPTYUYEe+iVnv4dg0wKm29+or0/hSxWegWMgZtskHVxtL0pMbqTZkSfzu7WGAk FNig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795108091; x=1795712891; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nb8Ts+L+z/DpTGbH2tq/3CpL8ayCSrXAUIaUzn6KeKM=; b=Gth4698+XIJCf+ZvAQD1aM215OoklD82dMdqDroo2nKtLgvSMU65y3kgPsGG0t03Pi s6uWujQzqzvt6cvYh6vQKbEB+i0D7rexLlicVMzB2tqRnL71DFN8gw+EflHkWXmnqzwB ilHfVLxzp28pRn0f3Na5olON16iHbpuaySTUGQXQqLHosi64oJvSKe4VbiGq5hgnQLtG 7FVU0l2LMwyuvIgBRYt3UnYwSzePNSJTqXklRJr5BRv+jVYFcr0rYFCVF/G5V7KNZ2W0 N6qA4cipikBhcxj3opBNFTAb/7KmvWDD+CtofvbI/r90uhMNqpSMSAM2JzybWX33gt4w DgGQ== X-Forwarded-Encrypted: i=1; AL+hErGmvXxMMvAp07LRJ55IjNwN8bfie+bLnI7kdqPJ6CDK7+HJwfLh6xNfk/yUvj0nXMw25CSyIjROeI8F0To=@vger.kernel.org X-Gm-Message-State: APuU4Z9PuWqoGMjyvcqQAzDr7puHkdMuU7WNQCtLUgxXUi7OqQT3qe3g 1IxlzAOrbXLD/Ds/eqRTA+tz+1lCBlHafAz1Fg9dakIqB6w++f1LVwGywL06UO8jD/Ugu5ThBmC 5TQJTeDhlnA== X-Received: from pjbds10.prod.google.com ([2002:a17:90b:8ca:b0:3b3:b3a3:5e41]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4c0a:b0:3b3:c998:6d6e with SMTP id 98e67ed59e1d1-3b3d07c68a0mr7206916a91.37.1795108090513; Thu, 19 Nov 2026 09:08:10 -0800 (PST) Date: Thu, 19 Nov 2026 09:07:58 -0800 In-Reply-To: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: X-Mailer: git-send-email 2.56.1.708.g77570a6a1d-goog Message-ID: <8af31a87f52c4cebc5ac7db6696a91545adb6ac4.1795106962.git.irogers@google.com> Subject: [PATCH 1/2] ASoC: codecs: lpass-rx-macro: Return early for non-HPH interpolators in HD2 control From: Ian Rogers To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Elkin Cruz , Ian Rogers Content-Type: text/plain; charset="UTF-8" rx_macro_enable_interp() invokes rx_macro_hd2_control() whenever rx->hph_hd2_mode is enabled, including for INTERP_AUX. However, rx_macro_hd2_control() only assigns hd2_scale_reg and hd2_enable_reg for INTERP_HPHL and INTERP_HPHR, leaving both u16 register offsets uninitialized on the stack for INTERP_AUX before testing 'if (hd2_enable_reg && ...)' and writing to random codec register addresses. Return immediately in the default branch of switch (interp_idx). Found via an x86_64 LLVM=1 (Clang 21.1.8) allyesconfig audit with -Wconditional-uninitialized enabled; fix and changelog drafted with an AI coding assistant. Build-tested under LLVM=1 W=1 (-Werror) and -Wconditional-uninitialized; not tested on Qualcomm LPASS audio hardware. Fixes: 4f692926f562 ("ASoC: codecs: lpass-rx-macro: add dapm widgets and route") Signed-off-by: Ian Rogers --- sound/soc/codecs/lpass-rx-macro.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c index ab8a1c2b0489..84a3a47cf932 100644 --- a/sound/soc/codecs/lpass-rx-macro.c +++ b/sound/soc/codecs/lpass-rx-macro.c @@ -2414,6 +2414,8 @@ static void rx_macro_hd2_control(struct snd_soc_component *component, hd2_scale_reg = CDC_RX_RXn_RX_PATH_SEC3(rx, 1); hd2_enable_reg = CDC_RX_RXn_RX_PATH_CFG0(rx, 1); break; + default: + return; } if (hd2_enable_reg && SND_SOC_DAPM_EVENT_ON(event)) { -- 2.56.1.708.g77570a6a1d-goog