From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9764A463B72 for ; Tue, 4 Aug 2026 11:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785841395; cv=none; b=OIwisP5T48ObvpQ1p2OtVEf+TGFYPajZG5anzZffBGeqflX1N5bBqKhsZwr2aAqZXhmDUBAwkxUTKmCI2TjBVNinmQDFnc+T212+shpzWRo0n7TuyTUHqwjPt8k3Jmhc0ZAMqhPTx3akY6bYqZIFV/3rjGhHCDbW9qtr8UbVaRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785841395; c=relaxed/simple; bh=VxsP9NGMGF+25YkA4c7VstbsKKvy4YQ/efSOUIb4TdA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Oe/56m/Fx0n7ypm/fBhC104ay9TNIr+p0rZ2ZSwC4p38zcEP35EfIEVUyy2aGdwvehnCEMbhdxQghXtx+TAAoRBUMUcAgQq2a0jwTOF/t5VE3bD1iyWAdBaW3ZGLJJi+2azYd2hbh9KNC5+Fcqc0YpdMxQhh2YwehFhJTkfT1GQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IRQDT2s8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P5xtsq9e; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IRQDT2s8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P5xtsq9e" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6748CEnT3034259 for ; Tue, 4 Aug 2026 11:03:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ii3L1jttNaTw9r5h11TG7kldFXqku4MVlQgGYfWZH7w=; b=IRQDT2s8K6yjg8na CMs4jkUXTsBg4xaZwFaUlUSbhvaLVnZr2fY+XMhZyEpXfzl9muzgiFPcOAgtENPu atueaZDKTISTHGA2V7w2Dnj7rV587GOFzlbrS0MhC4iJiHnJ2FOJZinmQJV1MbsN z4nga9x8FH6sgEwDz72JRVg/JRRMDZdNrxBMsiXIH/67y5YZG2aHmk7B61LIoOEQ wzkqcYfNqUwAnPrh+iObhDd50IHA/QFaZ6Cl6aRFSa/rpTd91O32K3Jw3D1I/XRs OLpLCcZnGeiW5tdXkfb5cugk0DaX86Oc0OOt2RRI/Rqx02cTyCOHvj+IvJk84xw+ JnZ/Lw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fty3qky75-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 11:03:13 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cacd6d37edso10494525ad.0 for ; Tue, 04 Aug 2026 04:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785841393; x=1786446193; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ii3L1jttNaTw9r5h11TG7kldFXqku4MVlQgGYfWZH7w=; b=P5xtsq9eHTDJNSLajRgt6qG7aHdsMLyCmxDCBDlHHr1gLdkUDnaF4clPzAEm5/zaal wgRX3e9E0dOLj8q4HuHopcUEQfygVbUj67JWRaOw7fKAiBkUMuVZD1KZlaY5jxDLC0+A wQbGunjzDaSqAWh0qDawuyzb+yoMsgLgQCPNZrf67YD+ntD6vLnW4bwlHrGjvOgbqS4e WOO86/l1NKjNT/ZEePtRDI2VkjKsSg0dp6RRKs5GbkPuYsg1OnSKPl1urTIifRBtGZ0n G+D9+GwZcaHw63BS9zdxJeHbt/lRp4CIUtf8dzJ8Ic+jGICsNdEQEuWfGNfzFa9YFbFI G4Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785841393; x=1786446193; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ii3L1jttNaTw9r5h11TG7kldFXqku4MVlQgGYfWZH7w=; b=qGo/nVZRBYridmsIXTyinMpk0xbHApbpXAAhiwkWUPebr59fyihITw8KQHS4JRD0wW HuoSggqnPN8lE6chKKMxO7J9GVUiVseHlB3ZNn5KP3VYOcXcuPpHFrspiUKmRKhkRO2N rM1vb+cRLGCGM1GlOAshxSb88K37N1Kfm7kfO7+zuoyOAiLSjy9f67yfjEtkGHm3JPnZ +AiWPzUxVHNW9w/qFdPDKk4W6Z1ov3gVahpceI7Dik3DqF7eKIDk0gSi2q4zbAmNz5u/ LLxL6efhixo9PZxCYx8LrpaR63HteYqjKCiIi3/kj48mI613kJSkqztt1BXIUVMhrUDD ojsw== X-Forwarded-Encrypted: i=1; AHgh+RpRZebkOoJiGhInCTYuKgyxXpzUWFAhtQICUbUPHsI44bIsbRqdGBDuIm2lMtjIAhQchTdckg4nq/5lmEk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx43YmkzBBAtQ4hLjgDUdiBXL7VxYMxOAB/WmC9Wzetovdp03H fLg7u0qStg+3Cnmlwks0CJZ1UL3v7uJUq8VuCzT/XqAtEVwpYDp51VVSV5oO7kTSeD4lpmZ9RS2 vkqR8wPBYWZF7XYaK3a4dbsC59JhkPmpvTPLnbSzn/qUBoe4w3x7+whOx6SMT7ySR83A= X-Gm-Gg: AR+sD10kvQNNwRB75B4T4YqtBDm65ndA/hUNitm1I3Wi7Lobh8ZjaJjQ1evjNMWQirx xlAeOx9DWlmbf+h9q7ScuV/TXOMUEyPXBJAF6l8b8HGStYRWRdpVk+5vaawbW4v7CxY6TE3wA5S vX3xeli8TDGbPZ0e0sXNVLLRo0/41THPOYp7dHSQ1Ax/s/JNq9iQmsRbm3IfEiX6d18i2ucqlhj skohdZ72j33lO3xxOTlyciIvoqQu5AnTXFkAJW1wkQ40EPLVCSQv9JMdYHIC/TfQI0RbZmcjfYe 7w0y/kwohDrWEfwEB2S5MWjqk2Vv5aAdSF8Vxv3y1BACLW31FkTqLH/+Z8dPuc16UFdUMvJIRsJ 66xlYNYY2sPke7Ly973JrTyqno0BPnqfqK4KqJxfGr+KK9nJ5/2srBazEDhCShBrzYQ== X-Received: by 2002:a17:903:4b4c:b0:2cc:6817:d9b1 with SMTP id d9443c01a7336-2d0524eb7f9mr133254195ad.41.1785841392886; Tue, 04 Aug 2026 04:03:12 -0700 (PDT) X-Received: by 2002:a17:903:4b4c:b0:2cc:6817:d9b1 with SMTP id d9443c01a7336-2d0524eb7f9mr133253725ad.41.1785841392461; Tue, 04 Aug 2026 04:03:12 -0700 (PDT) Received: from [10.133.33.161] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d0aa492772sm4979595ad.42.2026.08.04.04.03.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 04:03:10 -0700 (PDT) Message-ID: <8af46926-fecc-4396-973e-2290ae285998@oss.qualcomm.com> Date: Tue, 4 Aug 2026 19:03:06 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: ipq-cmn-pll: keep the CMN block bus clocks enabled To: Stanislaw Pal Cc: Bjorn Andersson , Stephen Boyd , Michael Turquette , Mieczyslaw Nalewaj , Brian Masney , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260730191353.557494-1-kuncy7@gmail.com> <20260803091003.15285-1-kuncy7@gmail.com> Content-Language: en-US From: Jie Luo In-Reply-To: <20260803091003.15285-1-kuncy7@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: qieGb_PfpJ9TIR0ulLXquRYFjtTalPSa X-Proofpoint-ORIG-GUID: qieGb_PfpJ9TIR0ulLXquRYFjtTalPSa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDA4NyBTYWx0ZWRfXzFXXEM4bX1pX enSKCCbIHxrXemVx9ozmSHTfw4OaoD9+yNYCbjWpPRM68VulafX+8YXdhUiVcKhwVZjwiESGmxD jRjsRhI23B7ah0kBcztdEq+oq+vKbuP0sMWH5/I3T8Gd16DpZZL5IrMCz2pdF/42yLVHkJjhtyn wGAQYKz8a/2gZkUO7ybPv1VzP17tKn/3ubfiyY/htP/zTVMJPKJmev/hKoGsKiDH/ZNEw5FVwdu p+j8ep4RG+m0GaQPhMPBFlmHDPQGCcNfnB+CyeEU7IAc8bheZ6E0S844AwuPL+PIDoTFMcYhscn KDlvLXg6orX/g18bGW+SE3s3H/XEtOuYghH74SLR3rtAyr8CplZSmoUOGtD+gZHF2KTXj2H0PbR be0CZEBXylTkVgNUlb0TEL/9GBoZYlsPymek8TBiRr0xToCmCHwP7EyDEPol2f2RXIFS4GgJfRr VzXmX572jmLdMocrDJw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDA4NyBTYWx0ZWRfXzw4RP7Bdc9ok HxW4PiUxC0hg10YorcqA9omUt8k6cV6QYWyhvZhVwpA3ga/vc/z0yvX6KHDVUKi6vkS/j8gaCRp 9M9BrOZXZutpcIccmDaHSAq6Hvbd0u8= X-Authority-Analysis: v=2.4 cv=ONEXGyaB c=1 sm=1 tr=0 ts=6a71c6f1 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=DPF5wdA_JBoVcR1QEgUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_02,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 bulkscore=0 spamscore=0 malwarescore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040087 On 8/3/2026 5:10 PM, Stanislaw Pal wrote: >> The CMN PLL AHB/SYS clocks will remain enabled as long as a downstream >> consumer of the CMN PLL clocks is active — this behaviour was confirmed >> experimentally on the IPQ9574 platform as example. > That is exactly the mechanism - and it is exactly what IPQ5018 does not > have. On IPQ9574 the nsscc node consumes the CMN PLL outputs in DT: > > ipq9574.dtsi: > nsscc: clock-controller@39b00000 { > clocks = <&xo_board_clk>, > <&cmn_pll NSS_1200MHZ_CLK>, > <&cmn_pll PPE_353MHZ_CLK>, ... > > so the device link holds the supplier active, which is what your > insmod/devmem experiment shows. > > On IPQ5018 there is no such consumer: nothing in ipq5018.dtsi references > any cmn_pll output clock - the only occurrences of the phandle are the > provider node itself and its own assigned-clocks. The actual users of > the CMN outputs on this SoC (the internal GE PHY and the uniphy blocks) > take them directly in hardware, with no DT linkage, so no device link > ever holds the provider active. A few ms after probe the autosuspend > gates the AHB/SYS clocks, and the box dies on the next bus access - > which is the measured behaviour the patch description quotes. The CMN PLL output clocks do not depend on the AHB or SYS clocks. They continue to operate correctly at the fixed rates even when the AHB and SYS clocks are disabled. Therefore, once the CMN PLL module is loaded, its output clocks are expected to operate at the correct frequencies. The downstream consumer is used to keep the AHB and SYS clocks enabled, allowing the CMN PLL registers to be accessed.