From: Peter Hong <peter_hong@fintek.com.tw>
To: Johan Hovold <johan@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <tom_tsai@fintek.com.tw>,
<yu_chen@fintek.com.tw>, <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V1 1/1] USB: serial: f81232: fix incomplete serial port generation
Date: Wed, 15 Oct 2025 10:24:56 +0800 [thread overview]
Message-ID: <8af5eb5f-0adb-4ea5-a4d5-554a7e883570@fintek.com.tw> (raw)
In-Reply-To: <aO5uAUknTLOWdvUY@hovoldconsulting.com>
Hi Johan,
Johan Hovold 於 2025/10/14 下午 11:36 寫道:
> On Wed, Oct 08, 2025 at 10:38:58AM +0800, Ji-Ze Hong (Peter Hong) wrote:
>> The Fintek F81532A/534A/535/536 family relies on the
>> F81534A_CTRL_CMD_ENABLE_PORT (116h) register during initialization to
>> both determine serial port status and control port creation. If the
>> driver experiences fast load/unload cycles, the device state may becomes
>> unstable, resulting in the incomplete generation of serial ports.
> Do I understand correctly that you're only seeing this issue if you're
> unloading and reloading the module (or rebinding the driver through
> sysfs)?
Yes, this issue has only been observed and reported during module unload
and reload operations currently.
>> Performing a dummy read operation on the register prior to the initial
>> write command resolves the issue. This clears the device's stale internal
>> state. Subsequent write operations will correctly generate all serial
>> ports.
> Does this mean that the retry loop is no longer needed? Can it now be
> removed in either or both accessor functions perhaps?
OK, we'll test the loop removal in the accessor. If successful, we'll prepare
and send V2.
Thanks,
prev parent reply other threads:[~2025-10-15 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 2:38 Ji-Ze Hong (Peter Hong)
2025-10-14 15:36 ` Johan Hovold
2025-10-15 2:24 ` Peter Hong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8af5eb5f-0adb-4ea5-a4d5-554a7e883570@fintek.com.tw \
--to=peter_hong@fintek.com.tw \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tom_tsai@fintek.com.tw \
--cc=yu_chen@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®