From: Bart Van Assche <bvanassche@acm.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 1/2] ufs: core: drop last_intr_status/ts stats
Date: Thu, 27 Mar 2025 07:40:14 -0400 [thread overview]
Message-ID: <8aff7086-5cf4-4212-b97f-cf0bffd79440@acm.org> (raw)
In-Reply-To: <20250326-topic-ufs-use-threaded-irq-v2-1-7b3e8a5037e6@linaro.org>
On 3/26/25 4:36 AM, Neil Armstrong wrote:
> Drop last_intr_status & last_intr_ts drop the ufs_stats struct,
> and the associated debug code.
Patch descriptions should not only explain what has been changed but
also why a change is being made. In this case, this change prepares for
making an interrupt handler threaded. If this patch series has to be
resent, please add this information to the patch description. Anyway,
since the patch itself looks good to me:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2025-03-27 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 8:36 [PATCH RFC v2 0/2] ufs: core: cleanup and threaded irq handler Neil Armstrong
2025-03-26 8:36 ` [PATCH RFC v2 1/2] ufs: core: drop last_intr_status/ts stats Neil Armstrong
2025-03-27 11:40 ` Bart Van Assche [this message]
2025-03-27 12:45 ` Neil Armstrong
2025-03-26 8:36 ` [PATCH RFC v2 2/2] ufs: core: delegate the interrupt service routine to a threaded irq handler Neil Armstrong
2025-03-27 11:56 ` Bart Van Assche
2025-03-27 12:47 ` Neil Armstrong
2025-03-28 17:14 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aff7086-5cf4-4212-b97f-cf0bffd79440@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®