From: Logan Gunthorpe <logang@deltatee.com>
To: Pavel Popov <pavel.e.popov@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Jim Chow <jim.chow@broadcom.com>,
Radu Rugina <radu.rugina@broadcom.com>,
Alexey Makhalov <alexey.makhalov@broadcom.com>,
Wei Liu <wei.liu@kernel.org>,
Michael Kelley <mhklinux@outlook.com>,
Lukas Wunner <lukas@wunner.de>,
Leon Romanovsky <leonro@nvidia.com>,
Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>,
bcm-kernel-feedback-list@broadcom.com,
virtualization@lists.linux.dev, linux-hyperv@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] PCI/P2PDMA: Allow P2PDMA in VMware guests on Intel hosts
Date: Fri, 16 Oct 2026 16:55:20 -0600 [thread overview]
Message-ID: <8b01d643-f62d-4118-a700-8874341d953b@deltatee.com> (raw)
In-Reply-To: <20261016223402.19991-2-pavel.e.popov@intel.com>
On 2026-10-16 16:34, Pavel Popov wrote:
> +#ifdef CONFIG_X86
> +/* CPUs whose host bridges support p2pdma, see pci_p2pdma_whitelist[] */
> +static const struct x86_cpu_id hypervisor_p2pdma_cpu_ids[] = {
> + X86_MATCH_VFM(INTEL_SKYLAKE_X, NULL),
> + X86_MATCH_VFM(INTEL_ICELAKE_X, NULL),
> + X86_MATCH_VFM(INTEL_ICELAKE_D, NULL),
> + X86_MATCH_VFM(INTEL_SAPPHIRERAPIDS_X, NULL),
> + X86_MATCH_VFM(INTEL_EMERALDRAPIDS_X, NULL),
> + X86_MATCH_VFM(INTEL_GRANITERAPIDS_X, NULL),
> + X86_MATCH_VFM(INTEL_GRANITERAPIDS_D, NULL),
> + X86_MATCH_VFM(INTEL_ATOM_CRESTMONT_X, NULL),
> + X86_MATCH_VFM(INTEL_ATOM_DARKMONT_X, NULL),
> + X86_MATCH_VFM(INTEL_DIAMONDRAPIDS_X, NULL),
> + {}
> +};
> +
> +static bool hypervisor_supports_p2pdma(void)
> +{
> + /* Hypervisor hides host topology, allow p2pdma on whitelisted CPUs */
> + if (hypervisor_is_type(X86_HYPER_VMWARE))
> + return x86_match_cpu(hypervisor_p2pdma_cpu_ids);
> +
> + return false;
> +}
One quick thought, after a very quick pass at this:
Why does this now need to be related to the hypervisor? Wouldn't it make
sense to do this check regardless of whether VMWare is involved?
Logan
next prev parent reply other threads:[~2026-10-16 22:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 22:34 [PATCH v2 0/2] PCI/P2PDMA: Allow P2PDMA in VMware and Hyper-V " Pavel Popov
2026-10-16 22:34 ` [PATCH v2 1/2] PCI/P2PDMA: Allow P2PDMA in VMware " Pavel Popov
2026-10-16 22:55 ` Logan Gunthorpe [this message]
2026-10-17 0:31 ` Popov, Pavel E
2026-10-17 7:48 ` Leon Romanovsky
2026-10-17 15:21 ` Popov, Pavel E
2026-10-19 19:48 ` Popov, Pavel E
2026-10-19 21:14 ` Logan Gunthorpe
2026-10-20 5:22 ` Leon Romanovsky
2026-10-16 22:34 ` [PATCH v2 2/2] PCI/P2PDMA: Allow P2PDMA in Hyper-V " Pavel Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b01d643-f62d-4118-a700-8874341d953b@deltatee.com \
--to=logang@deltatee.com \
--cc=alexey.makhalov@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=jim.chow@broadcom.com \
--cc=leonro@nvidia.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mhklinux@outlook.com \
--cc=nathan.d.ciobanu@linux.intel.com \
--cc=pavel.e.popov@intel.com \
--cc=radu.rugina@broadcom.com \
--cc=virtualization@lists.linux.dev \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®