From: "Arnd Bergmann" <arnd@arndb.de>
To: "Karl Mehltretter" <kmehltretter@gmail.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Piotr Wojtaszczyk" <piotr.wojtaszczyk@timesys.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: lpc32xx: only run SoC init on LPC32xx hardware
Date: Tue, 14 Jul 2026 08:12:06 +0200 [thread overview]
Message-ID: <8b04868e-1676-4c70-b14b-21609e01d791@app.fastmail.com> (raw)
In-Reply-To: <20260713192506.7782-1-kmehltretter@gmail.com>
On Mon, Jul 13, 2026, at 21:25, Karl Mehltretter wrote:
> lpc32xx_check_uid() and lpc32xx_pm_init() are arch_initcalls that poke
> LPC32xx-only registers. Since the multiplatform conversion they also
> run on other ARCH_MULTI_V5 boards where access faults e.g. on versatile:
>
> Unable to handle kernel paging request at virtual address f4004130
> PC is at lpc32xx_check_uid+0x2c/0x9c
>
> Drop the arch_initcall() registrations and call both functions directly
> from lpc3250_machine_init(), the machine's .init_machine hook.
> The calls are placed in link order (common.c, pm.c, phy3250.c) to
> keep their previous relative ordering.
>
> Fixes: 75bf1bd7d2f9 ("ARM: lpc32xx: allow multiplatform build")
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Looks good to me,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Vladimir, I assume you'll pick this up and forward it to
soc@lists.linux.dev. Let us know if you prefer Karl to send it
there directly and save you the extra pull request.
Arnd
next prev parent reply other threads:[~2026-07-14 6:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 19:25 Karl Mehltretter
2026-07-14 6:12 ` Arnd Bergmann [this message]
2026-07-16 23:00 ` Vladimir Zapolskiy
2026-07-17 6:29 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b04868e-1676-4c70-b14b-21609e01d791@app.fastmail.com \
--to=arnd@arndb.de \
--cc=kmehltretter@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®